[lworld] RFR: 8366270: [lworld] Fix ClassFile AccessFlagsTest [v2]

Chen Liang liach at openjdk.org
Wed Feb 4 21:18:09 UTC 2026


On Wed, 4 Feb 2026 21:13:45 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Fix version parse bug, improve coverage
>>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into fix/accessflags-pass-cffv
>>  - 8366270
>
> src/java.base/share/classes/jdk/internal/classfile/impl/ClassReaderImpl.java line 161:
> 
>> 159:     }
>> 160: 
>> 161:     public int classFileVersion() {
> 
> shouldn't this method be declared in ClassReader and overridden here?

`ClassReader` is a public API in java.lang.classfile, I don't want to touch java.* APIs for now

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2036#discussion_r2766007406


More information about the valhalla-dev mailing list