[lworld] RFR: 8367935: [lworld] Rename ACC_STRICT in the JVM according to strict fields JEP [v3]
Roger Riggs
rriggs at openjdk.org
Wed Feb 4 22:51:42 UTC 2026
On Wed, 4 Feb 2026 22:20:30 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> Strict initialization is now indicated with the access flag `ACC_STRICT_INIT` in the JVMS and the VM implementation should follow. `ACC_STRICT` is currently used as a method modifier for strict floating-point semantics so this refactor will help to make both modifiers distinct. VM and Java code has to be updated to use the correct modifier. Verified with tier x-y tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>
> Chen and Roger commentS
src/java.base/share/classes/java/lang/invoke/MemberName.java line 393:
> 391: return Modifier.isFinal(flags);
> 392: }
> 393: /** Utility method to query the modifier flags of this member. */
Odd leading space here. Also the comment should mention the strict flag it is testing.
Otherwise, the comments for all the utility methods are the same, generic, uninformative.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2025#discussion_r2766303945
More information about the valhalla-dev
mailing list