[lworld] RFR: 8367935: [lworld] Rename ACC_STRICT in the JVM according to strict fields JEP [v3]
Chen Liang
liach at openjdk.org
Wed Feb 4 22:57:26 UTC 2026
On Wed, 4 Feb 2026 22:49:19 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Chen and Roger commentS
>
> src/java.base/share/classes/java/lang/invoke/MemberName.java line 393:
>
>> 391: return Modifier.isFinal(flags);
>> 392: }
>> 393: /** Utility method to query the modifier flags of this member. */
>
> Odd leading space here. Also the comment should mention the strict flag it is testing.
> Otherwise, the comments for all the utility methods are the same, generic, uninformative.
All flag query methods have this simple comment in MemberName. I think we can fix those later.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2025#discussion_r2766317769
More information about the valhalla-dev
mailing list