[lworld] RFR: 8377451: [lworld] Add ValuePayload abstraction [v8]
Axel Boldt-Christmas
aboldtch at openjdk.org
Fri Feb 13 13:19:51 UTC 2026
On Fri, 13 Feb 2026 09:35:06 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove mutable
>
> src/hotspot/share/oops/inlineKlassPayload.inline.hpp line 45:
>
>> 43:
>> 44: template <typename OopOrHandle>
>> 45: inline ValuePayload::StorageImpl<OopOrHandle>::StorageImpl()
>
> There are some inconsistency w.r.t. marking the function definitions with `inline`. I'd propose that we put the `inline` declaration in the .hpp file and remove them from this file.
Alright. I added all the missing ones to begin with. There was one which was missing completely.
I really would have wanted to have a warning if there was function definition in a hpp file which does not have inline in either its definition or declaration.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2804171233
More information about the valhalla-dev
mailing list