[lworld] RFR: 8377451: [lworld] Add ValuePayload abstraction [v8]

[Axel Boldt-Christmas]

On Fri, 13 Feb 2026 13:16:28 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> src/hotspot/share/oops/inlineKlassPayload.inline.hpp line 45:
>> 
>>> 43: 
>>> 44: template <typename OopOrHandle>
>>> 45: inline ValuePayload::StorageImpl<OopOrHandle>::StorageImpl()
>> 
>> There are some inconsistency w.r.t. marking the function definitions with `inline`. I'd propose that we put the `inline` declaration in the .hpp file and remove them from this file.
>
> Alright. I added all the missing ones to begin with. There was one which was missing completely. 
> 
> I really would have wanted to have a warning if there was function definition in a hpp file which does not have inline in either its definition or declaration.

Do we really want just at the declaration site? 

I would think just definition or both is more common in hotspot? And just definition is probably the correct thing to do, as being inline is not a property of the interface declaration, but of how we choose to define the implementation, you should be able to move the definition to the cpp file without having to touch the non-inline hpp file.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2804233413