[lworld] RFR: 8377451: [lworld] Add ValuePayload abstraction [v8]

Stefan Karlsson stefank at openjdk.org
Fri Feb 13 13:52:50 UTC 2026


On Fri, 13 Feb 2026 13:29:49 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Alright. I added all the missing ones to begin with. There was one which was missing completely. 
>> 
>> I really would have wanted to have a warning if there was function definition in a hpp file which does not have inline in either its definition or declaration.
>
> Do we really want just at the declaration site? 
> 
> I would think just definition or both is more common in hotspot? And just definition is probably the correct thing to do, as being inline is not a property of the interface declaration, but of how we choose to define the implementation, you should be able to move the definition to the cpp file without having to touch the non-inline hpp file.

The benefit of adding it to the declaration is that you get a compilation error if you fail to include the .inline.hpp file. If you have the inline at the definition you get a linkage error instead, which is a bit more annoying.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2804325265


More information about the valhalla-dev mailing list