[lworld] RFR: 8378232: [lworld] Redundant clause in ClassFileParser::verify_legal_class_modifiers [v2]

[Casper Norrbin]

> Hi everyone,
> 
> In `ClassFileParser::verify_legal_class_modifiers`, the `valid_value_class` bool had a redundant `!is_identity`. Since `is_identity` is already handled by short-circuiting earlier in the expression, that condition is always true in the remaining branch. This change removes the redundancy without changing behavior.
> 
> Testing:
> - Tier 1

Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:

  removed class_note

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2146/files
  - new: https://git.openjdk.org/valhalla/pull/2146/files/3f421b0c..13c153f8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2146&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2146&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.org/valhalla/pull/2146.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2146/head:pull/2146

PR: https://git.openjdk.org/valhalla/pull/2146