[lworld] RFR: 8378232: [lworld] Redundant clause in ClassFileParser::verify_legal_class_modifiers

Coleen Phillimore coleenp at openjdk.org
Mon Feb 23 16:30:20 UTC 2026


On Fri, 20 Feb 2026 10:48:23 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

> Hi everyone,
> 
> In `ClassFileParser::verify_legal_class_modifiers`, the `valid_value_class` bool had a redundant `!is_identity`. Since `is_identity` is already handled by short-circuiting earlier in the expression, that condition is always true in the remaining branch. This change removes the redundancy without changing behavior.
> 
> Testing:
> - Tier 1

Thanks for doing this cleanup.  One more small change and I'll re-approve.

-------------

Marked as reviewed by coleenp (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/2146#pullrequestreview-3842124072


More information about the valhalla-dev mailing list