[lworld] RFR: 8378232: [lworld] Redundant clause in ClassFileParser::verify_legal_class_modifiers [v2]

[Casper Norrbin]

On Mon, 23 Feb 2026 16:26:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/classfile/classFileParser.cpp line 4513:
>> 
>>> 4511:       (!valid_value_class)) {
>>> 4512:     ResourceMark rm(THREAD);
>>> 4513:     const char* class_note = "";
>> 
>> This class_note variable controlled by valid_value_class is never used. Should we remove it? And the message would be wrong for the valid_value_class condition anyways because it allows ACC_IDENTITY.
>
> please remove it, even though it's not strictly this issue, it's very close by, and also a cleanup.

I've now removed that too

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2146#discussion_r2845502206