[lworld] RFR: 8377101: [lworld] Automatically generate value class sources based on source annotations [v2]

David Beaumont duke at openjdk.org
Fri Feb 27 14:33:01 UTC 2026


On Fri, 27 Feb 2026 14:20:16 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused file
>
> make/jdk/src/classes/build/tools/valueclasses/GenValueClasses.java line 100:
> 
>> 98:                             + " for annotation processor: " + GenValueClasses.class.getName());
>> 99:         }
>> 100:         this.outDir = Path.of(outDir.replace('/', File.separatorChar));
> 
> Separator replacement is not necessary, windows supports both.

Oh interesting. Good to know, though there's lots of code which still does it (which is what I drew inspiration from).

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2180#discussion_r2864606019


More information about the valhalla-dev mailing list