January 2012 - core-libs-dev

Float.parseFloat rounding patch
by Louis Wasserman 18 Jan '12

18 Jan '12

A while back I independently discovered Sun bug 6358355<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6358355> -- basically, under certain conditions, Float.parseFloat just uses a heuristic to round from Double.parseDouble (it tries to round in the opposite direction from parseDouble), which predictably enough for a hackish approach to floating-point rounding, doesn't work correctly in all cases. The relevant source is here<https://bugs.openjdk.java.net/attachment.cgi?id=243&action=diff#a/src/share…>; the comment: "look at the class instance variable roundDir, which should help us avoid double-rounding error. roundDir was set in hardValueOf if the estimate was close enough, but not exact. It tells us which direction of rounding is preferred." I have a patch and a test at https://bugs.openjdk.java.net/show_bug.cgi?id=100208, and I was advised to contact this mailing list to get it reviewed. What do I need to do? Louis Wasserman wasserman.louis(a)gmail.com http://profiles.google.com/wasserman.louis

1 0

Code review: 7126979 (props) JCK test java_lang/System/GetProperties.java failing [macosx]
by Michael McMahon 18 Jan '12

18 Jan '12

Could I get the following change for jdk7u-osx reviewed please? http://cr.openjdk.java.net/~michaelm/7126979/webrev.1/ The freeProps() call added by mac port can only be called once. Issue seen if System.setProperties(null) is called. GetJavaProperties() called a second time, which is supposed to return the statically populated information from first call. But some of it has been freed already. Fix is to remove the freeProps() code added in the original port changeset. The fix reverts the mac specific code to the original version. - Michael

3 5

hg: jdk8/tl/jdk: 7117570: Warnings in sun.mangement.* and its subpackages
by mandy.chung＠oracle.com 18 Jan '12

18 Jan '12

Changeset: 2f096eb72520 Author: mchung Date: 2012-01-17 15:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f096eb72520 7117570: Warnings in sun.mangement.* and its subpackages Reviewed-by: mchung, dsamersoff Contributed-by: kurchi.subhra.hazra(a)oracle.com ! src/share/classes/sun/management/Agent.java ! src/share/classes/sun/management/ConnectorAddressLink.java ! src/share/classes/sun/management/Flag.java ! src/share/classes/sun/management/GarbageCollectionNotifInfoCompositeData.java ! src/share/classes/sun/management/GarbageCollectorImpl.java ! src/share/classes/sun/management/GcInfoBuilder.java ! src/share/classes/sun/management/GcInfoCompositeData.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/classes/sun/management/HotspotCompilation.java ! src/share/classes/sun/management/HotspotThread.java ! src/share/classes/sun/management/LazyCompositeData.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/management/MappedMXBeanType.java ! src/share/classes/sun/management/MonitorInfoCompositeData.java ! src/share/classes/sun/management/NotificationEmitterSupport.java ! src/share/classes/sun/management/RuntimeImpl.java ! src/share/classes/sun/management/ThreadInfoCompositeData.java ! src/share/classes/sun/management/counter/perf/PerfInstrumentation.java ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java ! src/share/classes/sun/management/snmp/AdaptorBootstrap.java ! src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java ! src/share/classes/sun/management/snmp/jvminstr/JvmMemGCTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmMemManagerTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmMemMgrPoolRelTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmMemoryImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmMemoryMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmOSImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathEntryImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTBootClassPathTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathEntryImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTClassPathTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsEntryImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTInputArgsTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathEntryImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRTLibraryPathTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmRuntimeMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceEntryImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceTableMetaImpl.java ! src/share/classes/sun/management/snmp/jvminstr/JvmThreadingMetaImpl.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmClassesVerboseLevel.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmJITCompilerTimeMonitoring.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemManagerState.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolCollectThreshdSupport.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolState.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolThreshdSupport.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemPoolType.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCCall.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmMemoryGCVerboseLevel.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmRTBootClassPathSupport.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadContentionMonitoring.java ! src/share/classes/sun/management/snmp/jvmmib/EnumJvmThreadCpuTimeMonitoring.java ! src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIB.java ! src/share/classes/sun/management/snmp/jvmmib/JVM_MANAGEMENT_MIBOidTable.java ! src/share/classes/sun/management/snmp/jvmmib/JvmClassLoadingMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmCompilationMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemGCEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemGCTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemManagerTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemMgrPoolRelTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmMemPoolTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmOSMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTBootClassPathTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTClassPathTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTInputArgsTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRTLibraryPathTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmRuntimeMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceEntryMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmThreadInstanceTableMeta.java ! src/share/classes/sun/management/snmp/jvmmib/JvmThreadingMeta.java ! src/share/classes/sun/management/snmp/util/MibLogger.java ! src/share/classes/sun/management/snmp/util/SnmpListTableCache.java ! src/share/classes/sun/management/snmp/util/SnmpNamedListTableCache.java ! src/share/classes/sun/management/snmp/util/SnmpTableCache.java

1 0

hg: jdk8/tl/langtools: 7127924: langtools regression tests sometimes fail en-masse on windows
by jim.holmlund＠sun.com 18 Jan '12

18 Jan '12

Changeset: 1e2f4f4fb9f7 Author: jjh Date: 2012-01-17 17:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e2f4f4fb9f7 7127924: langtools regression tests sometimes fail en-masse on windows Reviewed-by: jjg ! test/tools/javac/diags/CheckExamples.java ! test/tools/javac/diags/MessageInfo.java ! test/tools/javac/diags/RunExamples.java

1 0

Code review request for 7058133 : Javah should use the freshly built classes instead of those from the BOOTDIR jdk
by Seán Coffey 17 Jan '12

17 Jan '12

Valerie, I'm porting this fix to the JDK 7u repo. It's been fixed in JDK 6 & JDK 8 repos already. full builds have been made with no issues seen. Bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058133 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7058133.jdk7u/ The fix differs slightly with the JDK 8 webrev (pkcs11 make directory is touched in JDK 7) We may need to revisit the JDK 8 one again. regards, Sean.

2 1

hg: jdk8/tl/jdk: 6671616: TEST_BUG: java/io/File/BlockIsDirectory.java fails when /dev/dsk empty (sol)
by chris.hegarty＠oracle.com 17 Jan '12

17 Jan '12

Changeset: 40d699d7f6a1 Author: chegar Date: 2012-01-17 14:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d699d7f6a1 6671616: TEST_BUG: java/io/File/BlockIsDirectory.java fails when /dev/dsk empty (sol) Reviewed-by: alanb ! test/ProblemList.txt - test/java/io/File/BlockIsDirectory.java

1 0

RFR 6671616: TEST_BUG java/io/File/BlockIsDirectory.java fails when /dev/dsk empty (sol)
by Chris Hegarty 17 Jan '12

17 Jan '12

On Solaris, this test looks in /dev/dsk for block special devices. Unfortunately, /dev/dsk is empty within a zone. Also unfortunately, on a non-zone Solaris machine, /dev/dsk is filled with symlinks to the actual device nodes. On Linux, this test looks at /dev/ide0 and /dev/scd0 which are presumed to be block special devices. This is not always the case. It's infeasible for the test to create its own block special devices for testing, since this requires root access. It seems quite unlikely for there to be a regression with this specific area, so the test should simply be deleted, and removed from the ProblemList. Changes being requested: 'hg remove test/java/io/File/BlockIsDirectory.java' --- a/test/ProblemList.txt Mon Jan 16 18:05:29 2012 +0000 +++ b/test/ProblemList.txt Tue Jan 17 13:27:53 2012 +0000 @@ -393,9 +393,6 @@ java/net/PortUnreachableException/OneExc # 6962637 java/io/File/MaxPathLength.java windows-all -# 6671616 -java/io/File/BlockIsDirectory.java solaris-all - # 7076644 java/io/File/Basic.java windows-all -Chris.

2 1

7130398: ProblemList.txt updates (1/2012)
by Alan Bateman 17 Jan '12

17 Jan '12

It's time to sync up test/ProblemList.txt again as it's currently not possible to do a clean test run. -Alan. diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -195,18 +195,21 @@ java/beans/XMLEncoder/6329581/Test632958 # jdk_lang +# 7123972 +test/java/lang/annotation/loaderLeak/Main.java generic-all + # 7079093 java/lang/instrument/ManifestTest.sh windows-all - -############################################################################ - -# jdk_management # 6944188 java/lang/management/ThreadMXBean/ThreadStateTest.java generic-all # 7067973 java/lang/management/MemoryMXBean/CollectionUsageThreshold.java generic-all + +############################################################################ + +# jdk_management # Failing, bug was filed: 6959636 javax/management/loading/LibraryLoader/LibraryLoaderTest.java generic-all @@ -288,6 +291,9 @@ javax/management/monitor/AttributeArbitr ############################################################################ # jdk_misc + +# 6988950 +demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java generic-all # Need to be marked othervm, or changed to be samevm safe com/sun/jndi/rmi/registry/RegistryContext/UnbindIdempotent.java generic-all

2 5

hg: jdk8/tl/jdk: 7129083: CookieManager does not store cookies if url is read before setting cookie manager
by chris.hegarty＠oracle.com 16 Jan '12

16 Jan '12

Changeset: e8a143213c65 Author: chegar Date: 2012-01-16 18:05 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8a143213c65 7129083: CookieManager does not store cookies if url is read before setting cookie manager Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/https/HttpsClient.java + test/sun/net/www/http/HttpClient/CookieHttpClientTest.java + test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java

1 0

hg: jdk8/tl/jdk: 7130398: ProblemList.txt updates (1/2012)
by alan.bateman＠oracle.com 16 Jan '12

16 Jan '12

Changeset: d1b0bda3a3c7 Author: alanb Date: 2012-01-16 16:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1b0bda3a3c7 7130398: ProblemList.txt updates (1/2012) Reviewed-by: chegar ! test/ProblemList.txt

1 0