January 2012 - core-libs-dev

Review needed for 7132879 to address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl
by Lance Andersen - Oracle 27 Jan '12

27 Jan '12

Hi, Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7133815/webrev.00/ this is a small change to address 2 findbug errors. The findbug issues being addressed: May expose internal representation by returning reference to mutable object and Load of known null value For CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

2 5

hg: jdk8/tl/jdk: 7133124: Remove redundant packages from JAR command line
by rickard.backman＠oracle.com 26 Jan '12

26 Jan '12

Changeset: 350971f50949 Author: rbackman Date: 2012-01-26 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/350971f50949 7133124: Remove redundant packages from JAR command line Reviewed-by: acorn, alanb, dholmes, rottenha ! make/common/Release.gmk

1 0

hg: jdk8/tl/jdk: 7017458: (cal) Multithreaded deserialization of Calendar leads to ClassCastException
by yuka.kamiya＠oracle.com 26 Jan '12

26 Jan '12

Changeset: ceab7e149581 Author: peytoia Date: 2012-01-26 17:06 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ceab7e149581 7017458: (cal) Multithreaded deserialization of Calendar leads to ClassCastException Reviewed-by: okutsu ! src/share/classes/java/util/Calendar.java + test/java/util/Calendar/Bug7017458.java

1 0

hg: jdk8/tl/langtools: 7133314: The regression test for 7129225 fails when run with jtreg -samevm or jtreg -agentvm
by jim.holmlund＠sun.com 25 Jan '12

25 Jan '12

Changeset: 332dfa0f91df Author: jjh Date: 2012-01-25 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/332dfa0f91df 7133314: The regression test for 7129225 fails when run with jtreg -samevm or jtreg -agentvm Reviewed-by: jjg ! test/tools/javac/7129225/AnnoProcessor.java ! test/tools/javac/7129225/NegTest.ref ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref

1 0

RFR 7132378: Race in FutureTask if used with explicit set ( not Runnable )
by Chris Hegarty 25 Jan '12

25 Jan '12

This issue was raised on the jdk7u-dev mailing list [1]. The change is to update the FutureTask implementation to what is in Doug's CVS. The old implementation using AbstractQueuedSynchronizer is replaced with a control "state" field that is updated by CAS to track completion, along with a Treiber stack to hold waiting threads. http://cr.openjdk.java.net/~chegar/7132378/webrev.00/webrev/ I have already reviewed this change. The diffs in the webrev are not all that useful, I reviewed it by going through the new file. Doug, I added a new test for this. It fails about 1 in every 3-4 runs on some of the boxes I have access to. Is this useful? Would you want to take it into your CVS? -Chris. [1] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-January/001439.html

3 4

hg: jdk8/tl/langtools: 7129225: javac fails to run annotation processors when star import of package of gensrc
by jim.holmlund＠sun.com 25 Jan '12

25 Jan '12

Changeset: d16b464e742c Author: jjh Date: 2012-01-24 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d16b464e742c 7129225: javac fails to run annotation processors when star import of package of gensrc Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/7129225/Anno.java + test/tools/javac/7129225/AnnoProcessor.java + test/tools/javac/7129225/NegTest.ref + test/tools/javac/7129225/TestImportStar.java + test/tools/javac/7129225/TestImportStar.ref

1 0

hg: jdk8/tl/langtools: 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast
by jim.holmlund＠sun.com 24 Jan '12

24 Jan '12

Changeset: ac36176b7de0 Author: jjh Date: 2012-01-24 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac36176b7de0 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/main/Main.java + test/tools/javah/T7126832/T7126832.java + test/tools/javah/T7126832/java.java

1 0

Code Review Request Bug #7129185:(coll) Please add Collections.emptyNavigableSet()
by Darryl Mocek 24 Jan '12

24 Jan '12

Re-sending this with the synopsis in the subject line (and the correct bug #). Hello core-libs. Please review this patch to fix Bug #7129185. This fix addresses comments made by Jason Mehrens to the commit of the fix for bug #4533691, including adding a Collections.emptyNavigableSet method. Tests are included. Webrev, can be found here: http://cr.openjdk.java.net/~dmocek/7129185/webrev.00 Thanks, Darryl

4 7

hg: jdk8/tl/jdk: 7132879: address Findbugs issue in WebRowSetXmlWriter
by lance.andersen＠oracle.com 24 Jan '12

24 Jan '12

Changeset: 303b67074666 Author: lancea Date: 2012-01-24 15:13 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666 7132879: address Findbugs issue in WebRowSetXmlWriter Reviewed-by: forax ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java

1 0

Re: Review needed for 7132879 to address the findbug errors in WebRowSetXmlWriter
by Remi Forax 24 Jan '12

24 Jan '12

Looks good. The only weird thing is the use of java.util.Map instead of Map. Because Map is used in when referencing Map.Entry just after. Rémi ----- Reply message ----- From: "Lance Andersen - Oracle" <lance.andersen(a)oracle.com> To: "core-libs-dev Libs" <core-libs-dev(a)openjdk.java.net> Subject: Review needed for 7132879 to address the findbug errors in WebRowSetXmlWriter Date: Tue, Jan 24, 2012 19:18 Hi, Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7132879/webrev.00/ this is a small change to address 2 findbug errors for this class. The findbug issues being addressed: Inefficient use of keySet iterator instead of entrySet iterator and non-serializable instance field in serializable class Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

2 3