January 2012 - core-libs-dev

hg: jdk8/tl/jdk: 7132248: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing
by xuelei.fan＠oracle.com 23 Jan '12

23 Jan '12

Changeset: d383b5d128e3 Author: xuelei Date: 2012-01-23 04:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d383b5d128e3 7132248: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing Reviewed-by: alanb ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java

1 0

java.io.File.LazyInitialization
by Alex Lam S.L. 21 Jan '12

21 Jan '12

Hi there, Whilst reading the JDK6 source code for java.io.File.createTempFile(), I noticed that: ... private static class LazyInitialization { ... static final String temporaryDirectory = temporaryDirectory(); static String temporaryDirectory() {...} ... } ... public static File createTempFile(String prefix, String suffix, File directory) throws IOException { ... if (directory == null) { String tmpDir = LazyInitialization.temporaryDirectory(); ... Shouldn't the last line use the static field instead of the static method? The static field "temporaryDirectory" is not used anywhere else in the class, which also make this seem suspicious. Alex.

2 1

JDK 8 code review request for initial unsigned integer arithmetic library support
by Joe Darcy 21 Jan '12

21 Jan '12

Hello, Polishing up some work I've had *almost* done for a long time, please review an initial take on providing library support for unsigned integer arithmetic: 4504839 Java libraries should provide support for unsigned integer arithmetic 4215269 Some Integer.toHexString(int) results cannot be decoded back to an int 6322074 Converting integers to string as if unsigned http://cr.openjdk.java.net/~darcy/4504839.1/ For the first cut, I've favored keeping the code straightforward over trickier but potentially faster algorithms. Tests need to be written for the unsigned divide and remainder methods, but otherwise the regression tests are fairly extensive. To avoid the overhead of having to deal with boxed objects, the unsigned functionality is implemented as static methods on Integer and Long, etc. as opposed to introducing new types like UnsignedInteger and UnsignedLong. (This work is not meant to preclude other integer arithmetic enhancements from going into JDK 8, such as add/subtract/multiply/divide methods that throw exceptions on overflow.) Thanks, -Joe

5 16

hg: jdk8/tl/jdk: 4504839: Java libraries should provide support for unsigned integer arithmetic; ...
by joe.darcy＠oracle.com 21 Jan '12

21 Jan '12

Changeset: 71200c517524 Author: darcy Date: 2012-01-20 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71200c517524 4504839: Java libraries should provide support for unsigned integer arithmetic 4215269: Some Integer.toHexString(int) results cannot be decoded back to an int 6322074: Converting integers to string as if unsigned Reviewed-by: mduigou, emcmanus, flar ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java + test/java/lang/Integer/Unsigned.java + test/java/lang/Long/Unsigned.java

1 0

Code Review Request for Bug #7129285
by Darryl Mocek 20 Jan '12

20 Jan '12

Please review this patch to fix Bug #7129285. This fix addresses comments made by Jason Mehrens to the commit of the fix for bug #4533691, including adding a Collections.emptyNavigableSet method. Tests are included. Webrev, can be found here: http://cr.openjdk.java.net/~dmocek/7129285/webrev.00 Thanks, Darryl

1 0

JEP 135: Base64 Encoding and Decoding
by mark.reinhold＠oracle.com 20 Jan '12

20 Jan '12

Posted: http://openjdk.java.net/jeps/135 - Mark

1 0

hg: jdk8/tl/jdk: 7092825: javax.crypto.Cipher.Transform.patternCache is synchronizedMap and became scalability bottleneck.
by valerie.peng＠oracle.com 19 Jan '12

19 Jan '12

Changeset: 313da5d059bf Author: valeriep Date: 2012-01-19 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/313da5d059bf 7092825: javax.crypto.Cipher.Transform.patternCache is synchronizedMap and became scalability bottleneck. Summary: Changed patternCache from synchronizedMap to ConcurrentHashMap. Reviewed-by: mullan ! src/share/classes/javax/crypto/Cipher.java

1 0

Re: JDK 8 code review request for initial unsigned integer
by Roger Riggs 19 Jan '12

19 Jan '12

A comment or two on the webrev for unsigned: http://cr.openjdk.java.net/~darcy/4504839.2 1. In the new parsing methods, could the String arguments be changed to the more general java.lang.CharSequence? For many parsing applications, it could be more convenient to pass a CharSequence than to create a new String. For consistency, should all of the parse methods be converted from String to CharSequence? 2. To be consistent, the new thrown exception messages should not end with a period (".") Roger

6 10

Result: New core-libs Group Member: David Holmes
by Alan Bateman 19 Jan '12

19 Jan '12

The vote for David Holmes [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. - Alan (nominator) [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-January/008839.ht…

1 0

Result: New core-libs Group Member: Brian Goetz
by Alan Bateman 19 Jan '12

19 Jan '12

The vote for Brian Goetz [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. - Alan (nominator) [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-January/008836.ht…

1 0