January 2012 - core-libs-dev

Review needed for 7132879 to address the findbug errors in WebRowSetXmlWriter
by Lance Andersen - Oracle 24 Jan '12

24 Jan '12

Hi, Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7132879/webrev.00/ this is a small change to address 2 findbug errors for this class. The findbug issues being addressed: Inefficient use of keySet iterator instead of entrySet iterator and non-serializable instance field in serializable class Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

1 0

hg: jdk8/tl/jdk: 7132270: tools/launcher/DefaultLocaleTestRun.java failing (win)
by kumar.x.srinivasan＠oracle.com 24 Jan '12

24 Jan '12

Changeset: f64ea40293db Author: ksrini Date: 2012-01-24 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f64ea40293db 7132270: tools/launcher/DefaultLocaleTestRun.java failing (win) Reviewed-by: alanb, chegar ! test/tools/launcher/DefaultLocaleTestRun.java ! test/tools/launcher/TestHelper.java

1 0

hg: jdk8/tl/langtools: 7129801: Merge the two method applicability routines
by maurizio.cimadamore＠oracle.com 24 Jan '12

24 Jan '12

Changeset: 51fb17abfc32 Author: mcimadamore Date: 2012-01-24 17:52 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/51fb17abfc32 7129801: Merge the two method applicability routines Summary: Resolve.java and Infer.java should reuse the same method applicability check routine Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java

1 0

7132270: tools/launcher/DefaultLocaleTestRun.java failing (win)
by Kumar Srinivasan 24 Jan '12

24 Jan '12

Hi, Fixes spurious test failure noticed on Windows 64, for some reason the env variable CLASSPATH either is not set in the child environment or it is wrong. This solution eliminates the need to depend on the env variable, instead the classpath (defined by jtreg) is set on the command line of the child's java process. http://cr.openjdk.java.net/~ksrini/7132270/webrev.0/ Alan, it looks like you have added this to the Problems.lst, but I don't see it yet. Thanks Kumar

3 3

hg: jdk8/tl/jdk: 7132386: makefile support for tracing/Java Flight Recorder framework phase I
by rickard.backman＠oracle.com 24 Jan '12

24 Jan '12

Changeset: 718bca4e685f Author: rbackman Date: 2012-01-17 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/718bca4e685f 7132386: makefile support for tracing/Java Flight Recorder framework phase I Reviewed-by: ohair, dholmes, rottenha Contributed-by: Markus Gronlund <markus.gronlund(a)oracle.com>, Erik Gahlin <erik.gahlin(a)oracle.com>, Nils Loodin <nils.loodin(a)oracle.com>, Rickard Backman <rickard.backman(a)oracle.com>, Staffan Larsen <staffan.larsen(a)oracle.com> ! make/com/oracle/Makefile + make/com/oracle/jfr/Makefile ! make/common/Defs.gmk ! make/common/Release.gmk

1 0

hg: jdk8/tl/jdk: 7132204: Default testset in JPRT should not run all tests
by alan.bateman＠oracle.com 24 Jan '12

24 Jan '12

Changeset: 237319a01a9a Author: alanb Date: 2012-01-24 09:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/237319a01a9a 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties ! test/ProblemList.txt

1 0

hg: jdk8/tl: 7132204: Default testset in JPRT should not run all tests
by alan.bateman＠oracle.com 24 Jan '12

24 Jan '12

Changeset: 0f653ee93477 Author: alanb Date: 2012-01-24 09:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0f653ee93477 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties

1 0

hg: jdk8/tl/jdk: 7132338: Use @code friendly idiom for '\' in javadoc
by joe.darcy＠oracle.com 23 Jan '12

23 Jan '12

Changeset: 914711cccc60 Author: darcy Date: 2012-01-23 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914711cccc60 7132338: Use @code friendly idiom for '\' in javadoc Reviewed-by: alanb ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/LineNumberInputStream.java ! src/share/classes/java/io/RandomAccessFile.java ! src/share/classes/java/io/StreamTokenizer.java ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/Properties.java

1 0

JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc
by Joe Darcy 23 Jan '12

23 Jan '12

Hello, Responding to some of code review feedback from Ulf about the unsigned API work, I've taken a pass at purging <code>'\u0030'</code> from the jdk repo's javadoc and replacing it with {@code '\u005Cu0030'} since {@code} is generally preferable. Webrev with these changes and other <code></code> => {@code} transformations at http://cr.openjdk.java.net/~darcy/7132338.0/ With these changes, the javadoc builds runs without additional warnings and a specdiff against a reference copy of the javadoc shows no unexpected changes. Thanks, -Joe

3 7

hg: jdk8/tl/jdk: 2 new changesets
by sean.mullan＠oracle.com 23 Jan '12

23 Jan '12

Changeset: 3df0bd3ed880 Author: mullan Date: 2012-01-23 12:17 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3df0bd3ed880 7131084: XMLDSig XPathFilter2Transform regression involving intersect filter Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath2Filter.java ! test/javax/xml/crypto/dsig/KeySelectors.java ! test/javax/xml/crypto/dsig/ValidationTests.java ! test/javax/xml/crypto/dsig/X509KeySelector.java + test/javax/xml/crypto/dsig/data/xmldsig-xfilter2.xml Changeset: 5e1ad6ad41b7 Author: mullan Date: 2012-01-23 13:23 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e1ad6ad41b7 Merge

1 0