June 2015 - core-libs-dev

[9] RFR of 8042377: BufferedWriter and FilteredOutputStream.close throw IAE if flush and close throw equal exceptions
by Brian Burkhalter 28 Jun '15

28 Jun '15

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8042377 Patch: http://cr.openjdk.java.net/~bpb/8042377/webrev.00/ The use of try-with-resources in FilteredOutputStream.close() is replaced with explicit handling of IOExceptions potentially thrown by flush() or close(). A test covering all cases is added. Thanks, Brian

9 24

RFR: 8129601: [launcher] test VersionCheck.java fails with new version string (more removal of dead code)
by Kumar Srinivasan 26 Jun '15

26 Jun '15

Hi, Please review fix to remove unused dead code, this was needed by mJRE, but with the removal of that, this also is no longer necessary and will make the build infra simpler as individual version numbers info. need not be passed around in the build system. Thanks Kumar Bug: https://bugs.openjdk.java.net/browse/JDK-8129601, Webrev: http://cr.openjdk.java.net/~ksrini/8129601/

3 3

JDK 9 RFR of JDK-8129624: Move jdk_rmi test group from tier 2 to tier 3
by joe darcy 25 Jun '15

25 Jun '15

Hello, As a follow-up to recent discussions on jdk9-dev, http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html please view the patch below to move the rmi test group from tier 2 to tier 3. Thanks, -Joe diff -r 65f38133842d test/TEST.groups --- a/test/TEST.groups Thu Jun 25 08:30:34 2015 -0700 +++ b/test/TEST.groups Thu Jun 25 09:49:27 2015 -0700 @@ -34,7 +34,6 @@ :jdk_io \ :jdk_nio \ :jdk_net \ - :jdk_rmi \ :jdk_time \ :jdk_security \ :jdk_text \ @@ -42,8 +41,8 @@ :jdk_other \ :jdk_svc -# Tier 3 is initially empty. -tier3 = +tier3 = \ + :jdk_rmi ############################################################################### #

3 2

RfR: 8129880 - Cleanup usage of Class.getResource in jaxp
by Daniel Fuchs 25 Jun '15

25 Jun '15

Hi, Please find below a cleanup patch for jaxp: https://bugs.openjdk.java.net/browse/JDK-8129880 8129880 - Cleanup usage of getResource in jaxp Class.getResource(classFile) was used for printing the class location for debuging purposes. CodeSource.getLocation() is a better fit for that. http://cr.openjdk.java.net/~dfuchs/webrev_8129880/webrev.00/index.html best regards, -- daniel

3 2

RFR: 8098547: (tz) Support tzdata2015e
by Aleksej Efimov 25 Jun '15

25 Jun '15

Hello, Please, review the latest tzdata (2015e) [1] integration to JDK9: http://cr.openjdk.java.net/~aefimov/tzdata/2015e/9/0 Testing shows no TZ related failures on all platforms. With Best Regards, Aleksej [1] https://bugs.openjdk.java.net/browse/JDK-8098547

5 8

Re: [8u60] RFA 8129120 Terminal operation properties should not be back-propagated to upstream operations
by Paul Sandoz 25 Jun '15

25 Jun '15

On Jun 23, 2015, at 10:53 AM, Seán Coffey <sean.coffey(a)oracle.com> wrote: > Hi Paul, > > Best to get a peer review on this before pushing to jdk8u-dev. > Ok, including core-libs. The JPRT job passed. I additionally ran the 8b JCK tests, which all passed. Paul. > Approved. If you get this into jdk8u-dev before Friday it should make the pre-RDP2 integration slot. After this week, an 8u60-dev stabilization forest will be created for ramp down purposes. > > Regards, > Sean. > > On 23/06/2015 09:32, Paul Sandoz wrote: >> Hi, >> >> I would like to backport: >> >> https://bugs.openjdk.java.net/browse/JDK-8129120 >> >> 9 changeset >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d9eadfd5659d >> >> Review: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/034203.html >> >> The 9 changeset does not apply cleanly to the following source: >> >> src/share/classes/java/util/stream/AbstractPipeline.java >> test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java >> >> The 8u patch is here: >> >> http://cr.openjdk.java.net/~psandoz/jdk8u/JDK-8129120-flag-back-propagation… >> >> For 8u AbstractPipeline.java the update was simply to remove the method parallelPrepare and replace the 8u method >> sourceSpliterator with the equivalent 9 method. >> >> For 8u DistinctOpTest.java the expansion of the imports and reformatting result in failure to apply all the patch cleanly. >> >> All stream tests pass locally. >> >> A JPRT job is underway. >> >> I would like to wait a day or two to let the 9 changeset get tested by the infrastructure (i don't anticipate any issues). But wanted to ask for approval now assuming there are no issues with 9 and the JPRT job pass. >> >> Paul. >

2 1

Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules
by Frank Yuan 25 Jun '15

25 Jun '15

Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw change, the context class loader can't load internal resource which is in a named module any more. To fix it, LSSerializerImpl shall invoke ResourceBundle.getBundle(resourceName) instead of ResourceBundle.getBundle(resourceName, locale, classloader) to create CharInfo instance, that will getBundle with the module of the caller(here it's java.xml module). This patch also forces to use the internal XMLEntities.properties because the default xml character entity reference should always be applied. The webrev is at: http://cr.openjdk.java.net/~fyuan/8080266/webrev.00/ Any comment will be appreciated. Thanks, Frank

3 6

RFR(s): 8080450: doc for Double/Int/LongSummaryStatistics.toString has errors
by Stuart Marks 24 Jun '15

24 Jun '15

Hi all, Please review this small javadoc change to the Double/Int/LongSummaryStatistics classes' toString() method specifications. Basically they all inherit the Object.toString() doc, which is mostly irrelevant, and in two cases the doc comment is placed erroneously and so is entirely ignored. See the bug report for details: https://bugs.openjdk.java.net/browse/JDK-8080450 Webrev: http://cr.openjdk.java.net/~smarks/reviews/8080450/webrev.0/ Javadoc output with changes in place: http://cr.openjdk.java.net/~smarks/reviews/8080450/javadoc.0/java/util/Doub… http://cr.openjdk.java.net/~smarks/reviews/8080450/javadoc.0/java/util/IntS… http://cr.openjdk.java.net/~smarks/reviews/8080450/javadoc.0/java/util/Long… For comparison, here are the JDK 8 versions of the docs: http://docs.oracle.com/javase/8/docs/api/java/util/DoubleSummaryStatistics.… http://docs.oracle.com/javase/8/docs/api/java/util/IntSummaryStatistics.htm… http://docs.oracle.com/javase/8/docs/api/java/util/LongSummaryStatistics.ht… (I expect this will also require a CCC request, since this is formally a change in the specification.) s'marks

3 3

JDK 9 RFR of JDK-8129597: Add tier 3 test definitions to the JDK 9 forest
by joe darcy 24 Jun '15

24 Jun '15

Hello, Per the recent email to jdk9-dev, "Test policy follow-up, third testing tier," http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html please review the patch below to address JDK-8129597 : Add tier 3 test definitions to the JDK 9 forest http://cr.openjdk.java.net/~darcy/8129597.0/ (Tests will be added to tier 3 in subsequent changesets.) Thanks, -Joe --- old/jdk/test/TEST.groups 2015-06-23 09:47:53.929026307 -0700 +++ new/jdk/test/TEST.groups 2015-06-23 09:47:53.761110302 -0700 @@ -42,6 +42,9 @@ :jdk_other \ :jdk_svc +# Tier 3 is initially empty +tier3 = + ############################################################################### # # Other test definitions; generally smaller granularity than tiers --- old/langtools/test/TEST.groups 2015-06-23 09:47:54.296842319 -0700 +++ new/langtools/test/TEST.groups 2015-06-23 09:47:54.192894315 -0700 @@ -22,11 +22,14 @@ # Tiered testing definitions -# All langtools tests are tier 1 +# All langtools tests are tier 1. tier1 = \ tools \ com \ lib -# No langtools tests are tier 2 +# No langtools tests are tier 2. tier2 = + +# No langtools tests are tier 3 either. +tier3 = --- old/jaxp/test/TEST.groups 2015-06-23 09:47:54.616682328 -0700 +++ new/jaxp/test/TEST.groups 2015-06-23 09:47:54.528726325 -0700 @@ -29,5 +29,8 @@ tier2 = \ :jaxp_all +# No tier 3 tests. +tier3 = + jaxp_all = \ javax/xml/jaxp --- old/nashorn/test/TEST.groups 2015-06-23 09:47:54.936522337 -0700 +++ new/nashorn/test/TEST.groups 2015-06-23 09:47:54.848566335 -0700 @@ -27,3 +27,6 @@ # All nashorn tests are tier 2. tier2 = src + +# No nashorn tests are tier 3. +tier3 =

2 1

RFR JDK-8129544: ArrayIndexOutOfBoundsException when decoding corrupt Base64 string
by Xueming Shen 24 Jun '15

24 Jun '15

Hi, Please help review the change for JDK-8129544. Issue: https://bugs.openjdk.java.net/browse/JDK-8129544 Webrev: http://cr.openjdk.java.net/~sherman/8129544 Thanks, -Sherman

2 1