June 2015 - core-libs-dev

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules
by Alexander Kulyakhtin 24 Jun '15

24 Jun '15

Sorry, I didn't realize these are TEST.properties files, not java files. The changes are ok, sorry for the confusion. Best regards, Alexander ----- Original Message ----- From: alexander.kulyakhtin(a)oracle.com To: konstantin.shefov(a)oracle.com, Alan.Bateman(a)oracle.com Cc: core-libs-dev(a)openjdk.java.net, security-dev(a)openjdk.java.net Sent: Wednesday, June 24, 2015 6:50:47 PM GMT +03:00 Iraq Subject: Re: [9] Review request: JDK-8129595: New DTLS tests need @modules Konstantin, Apparently the script does not yet provide for the same formatting as was done with the bulk updates. You may want to make the changes format consistent with how it was done for multiple modules in the bulk update patches such as here: http://sette0.ru.oracle.com/akulyakh/open_no_peers/webrev/test/java/awt/ima… I'm going to change the script so it provides for the same formatting. Best regards, Alexander ----- Original Message ----- From: Alan.Bateman(a)oracle.com To: konstantin.shefov(a)oracle.com, core-libs-dev(a)openjdk.java.net, security-dev(a)openjdk.java.net, alexander.kulyakhtin(a)oracle.com Sent: Wednesday, June 24, 2015 6:46:30 PM GMT +03:00 Iraq Subject: Re: [9] Review request: JDK-8129595: New DTLS tests need @modules On 24/06/2015 16:40, Konstantin Shefov wrote: > Hi Alan, > > Please review updated patch. I made it using the tool Alexander > Kulyakhtin has given me. > > http://cr.openjdk.java.net/~kshefov/8129595/webrev.01/ This looks okay to me. Thanks for sorting this out. -Alan

1 0

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules
by Alexander Kulyakhtin 24 Jun '15

24 Jun '15

Konstantin, Apparently the script does not yet provide for the same formatting as was done with the bulk updates. You may want to make the changes format consistent with how it was done for multiple modules in the bulk update patches such as here: http://sette0.ru.oracle.com/akulyakh/open_no_peers/webrev/test/java/awt/ima… I'm going to change the script so it provides for the same formatting. Best regards, Alexander ----- Original Message ----- From: Alan.Bateman(a)oracle.com To: konstantin.shefov(a)oracle.com, core-libs-dev(a)openjdk.java.net, security-dev(a)openjdk.java.net, alexander.kulyakhtin(a)oracle.com Sent: Wednesday, June 24, 2015 6:46:30 PM GMT +03:00 Iraq Subject: Re: [9] Review request: JDK-8129595: New DTLS tests need @modules On 24/06/2015 16:40, Konstantin Shefov wrote: > Hi Alan, > > Please review updated patch. I made it using the tool Alexander > Kulyakhtin has given me. > > http://cr.openjdk.java.net/~kshefov/8129595/webrev.01/ This looks okay to me. Thanks for sorting this out. -Alan

1 0

[9] Review request: JDK-8129595: New DTLS tests need @modules
by Konstantin Shefov 24 Jun '15

24 Jun '15

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8129595 Webrev is http://cr.openjdk.java.net/~kshefov/8129595/webrev.00/ Thanks -Konstantin

2 5

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules
by Alexander Kulyakhtin 24 Jun '15

24 Jun '15

Adding Shura ----- Original Message ----- From: alexander.kulyakhtin(a)oracle.com To: Alan.Bateman(a)oracle.com Cc: core-libs-dev(a)openjdk.java.net, konstantin.shefov(a)oracle.com, security-dev(a)openjdk.java.net Sent: Wednesday, June 24, 2015 3:59:14 PM GMT +03:00 Iraq Subject: Re: [9] Review request: JDK-8129595: New DTLS tests need @modules Konstantin, Shura has developed a tool to add @modules to jtreg tests specified as input. The wiki is here: https://wiki.se.oracle.com/display/JPG/@modules+in+JTReg+tests#id-@modulesi… Please, let me know if any additional help is needed, or if there are any issues. Best regards, Alexander ----- Original Message ----- From: Alan.Bateman(a)oracle.com To: konstantin.shefov(a)oracle.com, core-libs-dev(a)openjdk.java.net, security-dev(a)openjdk.java.net, alexander.kulyakhtin(a)oracle.com Sent: Wednesday, June 24, 2015 1:52:12 PM GMT +03:00 Iraq Subject: Re: [9] Review request: JDK-8129595: New DTLS tests need @modules On 24/06/2015 11:29, Konstantin Shefov wrote: > Alan, > > Do the tests form "test/javax/net/ssl/DTLS" compile against jake? They > have just the same dependencies as "test/javax/net/ssl/TLS" and the > TEST.properties file just like one suggested in this fix. > If yes, it is not worth changing TEST.properties any more. Alexander Kulyakhtin has been working on a tool that uses jdeps to get the dependences of each test. It's not in OpenJDK yet but I'm sure he can help you get the @modules right for these tests. -Alan

1 0

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules
by Alexander Kulyakhtin 24 Jun '15

24 Jun '15

Konstantin, Shura has developed a tool to add @modules to jtreg tests specified as input. The wiki is here: https://wiki.se.oracle.com/display/JPG/@modules+in+JTReg+tests#id-@modulesi… Please, let me know if any additional help is needed, or if there are any issues. Best regards, Alexander ----- Original Message ----- From: Alan.Bateman(a)oracle.com To: konstantin.shefov(a)oracle.com, core-libs-dev(a)openjdk.java.net, security-dev(a)openjdk.java.net, alexander.kulyakhtin(a)oracle.com Sent: Wednesday, June 24, 2015 1:52:12 PM GMT +03:00 Iraq Subject: Re: [9] Review request: JDK-8129595: New DTLS tests need @modules On 24/06/2015 11:29, Konstantin Shefov wrote: > Alan, > > Do the tests form "test/javax/net/ssl/DTLS" compile against jake? They > have just the same dependencies as "test/javax/net/ssl/TLS" and the > TEST.properties file just like one suggested in this fix. > If yes, it is not worth changing TEST.properties any more. Alexander Kulyakhtin has been working on a tool that uses jdeps to get the dependences of each test. It's not in OpenJDK yet but I'm sure he can help you get the @modules right for these tests. -Alan

1 0

RFR 6415680 handle windows EXCEPTION_IN_PAGE_ERROR just as SIGBUS is handled
by Kirk Shoop (MS OPEN TECH) 24 Jun '15

24 Jun '15

Hi, webrev http://cr.openjdk.java.net/~kshoop/6415680/ bug: https://bugs.openjdk.java.net/browse/JDK-6415680 The changes for unix to handle SIGBUS need matching work for Windows EXCEPTION_IN_PAGE_ERROR This change uses handler_for_unsafe_access for in-page errors while set_doing_safe_access is true and has Unsafe_CopyMemory call set_doing_unsafe_access(true) The bug refers to DRM or encrypted file systems. However, this also occurs with interrupted network connections. To reproduce, I used http://cr.openjdk.java.net/~kshoop/6415680/FileCopyUtil.java I would start the app with a path to a file on an SMB server and then when prompted to press enter, disconnect the server from the network and then hit enter to cause the app to attempt to page in the mapped pages. With this change the following output is expected: ++++++++++++ OpenJDK 64-Bit Server VM (build 1.9.0-internal-_2015_04_03_10_46-b00, mixed mode) 72535 micro seconds to InitializeJVM Main class is 'FileCopyUtil' App's argc is 1 argv[ 0] = '\kshoop-testpublicalloctrace.etl' 36985 micro seconds to load main class ----_JAVA_LAUNCHER_DEBUG---- F\kshoop-testpublicalloctrace.etl file map created. Press ENTER to proceed. Exception in thread "main" java.lang.InternalError: a fault occurred in an unsafe memory access operation ++++++++++++ Kirk Developer Microsoft Open Technologies, Inc.

3 2

JDK 9 RFR of JDK-8129759: Mark two tests from DistinctOpTest.java and SliceOpTest.java as serialization hostile
by Amy Lu 24 Jun '15

24 Jun '15

Testcase testStable was newly introduced in JDK-8129120 in DistinctOpTest, this test should be marked as serialization-hostile. (such tests will ignored by by lambda serialization testing framework). testSkipLimitOpsWithNonSplittingSpliterator from SliceOpTest also need same change. Please review and sponsor this change: bug: https://bugs.openjdk.java.net/browse/JDK-8129759 webrev: http://cr.openjdk.java.net/~amlu/8129759/webrev.00/ Thanks, Amy

2 2

RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp
by Daniel Fuchs 23 Jun '15

23 Jun '15

Hi, Please find below a patch for 8129572 - Cleanup usage of getResourceAsStream in jaxp https://bugs.openjdk.java.net/browse/JDK-8129572 http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/ This removes a bunch of unused getResourceAsStream methods and sanitizes the few that remain. I took the liberty to also add some additional debug traces to the LSSerializerTest.java to help debug when the test fails. best regards, -- daniel

4 4

Re: RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp
by Daniel Fuchs 23 Jun '15

23 Jun '15

On 23/06/15 17:14, Claes Redestad wrote: > "priveleged" typo in: > http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/jaxp/src/java.x… > > > The line isn't touched by the patch, but might be a nice drive-by fix... > Done. Thanks for reviewing! -- daniel

1 0

RFR 9: 8129535: java_props_md.c should compile on VS 2010
by Roger Riggs 23 Jun '15

23 Jun '15

Please review a minor correction so java_props_md.c will compile with Visual Studio 2010. (Declarations are allowed in the middle of blocks only in later versions). Webrev: http://cr.openjdk.java.net/~rriggs/webrev-props-vs1010-8129535/ Issue: https://bugs.openjdk.java.net/browse/JDK-8129535 Thanks, Roger

3 4