June 2015 - core-libs-dev

[9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option
by Konstantin Shefov 17 Jun '15

17 Jun '15

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8062904 Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.00/ Thanks -Konstantin

3 10

[9] Review request : JDK-8067005 : Several java/lang/invoke tests fail due to exhausted code cache
by Konstantin Shefov 17 Jun '15

17 Jun '15

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8067005 Webrev is http://cr.openjdk.java.net/~kshefov/8067005/webrev.00/ Thanks -Konstantin

2 3

Review Request: 8104574 Update tests to prepare for system class loader not be URLClassLoader
by Mandy Chung 17 Jun '15

17 Jun '15

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8104574/webrev.00/ Pattern like this should be fixed as a ClassLoader is not necessary a URLClassLoader. ((URLClassLoader) ThreadSafety.class.getClassLoader() We have fixed several tests previously. Two more are identified and fixed in this patch. Mandy

2 1

RFR 9: 8086208 : java/lang/ProcessHandle/OnExitTest.java: IllegalThreadStateException: process hasn't exited
by Roger Riggs 17 Jun '15

17 Jun '15

Please review a fix for a (Unix) race condition for the exit status of Process.onExit. And some source cleanup of OnExitTest. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-race-8086208/ Issue: https://bugs.openjdk.java.net/browse/JDK-8086208 Roger

3 6

Review Request for 8098850: Remove remaining native2ascii resource files and man pages
by Mandy Chung 16 Jun '15

16 Jun '15

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8098850/webrev.00/ This patch is to remove the native2ascii remaining file that are missed from the changeset of JDK-8074431. src/jdk.dev/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_ja.java src/jdk.dev/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_zh_CN.java src/linux/doc/man/ja/native2ascii.1 src/linux/doc/man/native2ascii.1 src/solaris/doc/sun/man/man1/ja/native2ascii.1 src/solaris/doc/sun/man/man1/native2ascii.1 Mandy

3 2

JDK 9 RFR of JDK-8098582: Remove redundant package.html file in javax.xml.ws/wsaddressing
by joe darcy 16 Jun '15

16 Jun '15

Hello, Not sure the best place to send this out for review / send it upstream, in any case, pressing forward please review this change to fix JDK-8098582: Remove redundant package.html file in javax.xml.ws.wsaddressing http://cr.openjdk.java.net/~darcy/8098582.0/ The package javax.xml.ws.wsaddressing has both a package-info.java file and a package.html file. While belts and suspenders are sometimes helpful, this is not one of those times. Having both files causing a javadoc warning; the fix is to copy the documentation from package.html into package-info.java and delete package.html. Thanks, -Joe

2 1

RFR 8085978 LinkedTransferQueue<T>.spliterator can report LTQ.Node object, not T
by Paul Sandoz 16 Jun '15

16 Jun '15

Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8085978-linked-transfer-queue-… The LinkedTransferQueue's spliterator can erroneously report internal nodes when traversing. The fix is cherry picked from the 166 repo (other mostly refactoring-based changes will occur later on with bulk updates). I would also like to backport to 8u60. Paul.

2 2

JDK 9 RFR of 8098790: Improve cross references and wording in java.lang.reflect.AnnotatedFoo type
by joe darcy 16 Jun '15

16 Jun '15

Hello, Please review the small doc clarification for 8098790: Improve cross references and wording in java.lang.reflect.AnnotatedFoo type http://cr.openjdk.java.net/~darcy/8098790.0/ Patch below. In brief, various methods in java.lang.reflect.AnnotatedFoo would be clearer if they had @see links to the analogous method in java.lang.reflect.Foo. In addition some "Note that..." phrases are improperly used since they are normative text rather than just informative text. Thanks, -Joe --- old/src/java.base/share/classes/java/lang/reflect/AnnotatedArrayType.java 2015-06-15 17:06:47.895027600 -0700 +++ new/src/java.base/share/classes/java/lang/reflect/AnnotatedArrayType.java 2015-06-15 17:06:47.763027597 -0700 @@ -39,6 +39,7 @@ * Returns the potentially annotated generic component type of this array type. * * @return the potentially annotated generic component type of this array type + * @see GenericArrayType#getGenericComponentType() */ AnnotatedType getAnnotatedGenericComponentType(); } --- old/src/java.base/share/classes/java/lang/reflect/AnnotatedParameterizedType.java 2015-06-15 17:06:48.307027613 -0700 +++ new/src/java.base/share/classes/java/lang/reflect/AnnotatedParameterizedType.java 2015-06-15 17:06:48.163027609 -0700 @@ -38,6 +38,7 @@ * Returns the potentially annotated actual type arguments of this parameterized type. * * @return the potentially annotated actual type arguments of this parameterized type + * @see ParameterizedType#getActualTypeArguments() */ AnnotatedType[] getAnnotatedActualTypeArguments(); } --- old/src/java.base/share/classes/java/lang/reflect/AnnotatedTypeVariable.java 2015-06-15 17:06:48.723027625 -0700 +++ new/src/java.base/share/classes/java/lang/reflect/AnnotatedTypeVariable.java 2015-06-15 17:06:48.583027621 -0700 @@ -36,10 +36,11 @@ /** * Returns the potentially annotated bounds of this type variable. - * Note that if no bound is explicitly declared, the bound is unannotated + * If no bound is explicitly declared, the bound is unannotated * {@code Object}. * * @return the potentially annotated bounds of this type variable + * @see TypeVariable#getBounds() */ AnnotatedType[] getAnnotatedBounds(); } --- old/src/java.base/share/classes/java/lang/reflect/AnnotatedWildcardType.java 2015-06-15 17:06:49.131027638 -0700 +++ new/src/java.base/share/classes/java/lang/reflect/AnnotatedWildcardType.java 2015-06-15 17:06:48.995027634 -0700 @@ -36,20 +36,22 @@ /** * Returns the potentially annotated lower bounds of this wildcard type. - * Note that if no lower bound is explicitly declared, the lower bound is the + * If no lower bound is explicitly declared, the lower bound is the * type of null. In this case, a zero length array is returned. * * @return the potentially annotated lower bounds of this wildcard type or * an empty array if no lower bound is explicitly declared. + * @see WildcardType#getLowerBounds() */ AnnotatedType[] getAnnotatedLowerBounds(); /** * Returns the potentially annotated upper bounds of this wildcard type. - * Note that if no upper bound is explicitly declared, the upper bound is + * If no upper bound is explicitly declared, the upper bound is * unannotated {@code Object} * * @return the potentially annotated upper bounds of this wildcard type + * @see WildcardType#getUpperBounds() */ AnnotatedType[] getAnnotatedUpperBounds(); } --- old/src/java.base/share/classes/java/lang/reflect/TypeVariable.java 2015-06-15 17:06:49.535027650 -0700 +++ new/src/java.base/share/classes/java/lang/reflect/TypeVariable.java 2015-06-15 17:06:49.399027646 -0700 @@ -51,7 +51,7 @@ public interface TypeVariable<D extends GenericDeclaration> extends Type, AnnotatedElement { /** * Returns an array of {@code Type} objects representing the - * upper bound(s) of this type variable. Note that if no upper bound is + * upper bound(s) of this type variable. If no upper bound is * explicitly declared, the upper bound is {@code Object}. * * <p>For each upper bound B: <ul> <li>if B is a parameterized @@ -67,7 +67,7 @@ * for any reason * @return an array of {@code Type}s representing the upper * bound(s) of this type variable - */ + */ Type[] getBounds(); /** --- old/src/java.base/share/classes/java/lang/reflect/WildcardType.java 2015-06-15 17:06:49.959027663 -0700 +++ new/src/java.base/share/classes/java/lang/reflect/WildcardType.java 2015-06-15 17:06:49.819027659 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2004, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2015, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -34,7 +34,7 @@ public interface WildcardType extends Type { /** * Returns an array of {@code Type} objects representing the upper - * bound(s) of this type variable. Note that if no upper bound is + * bound(s) of this type variable. If no upper bound is * explicitly declared, the upper bound is {@code Object}. * * <p>For each upper bound B : @@ -57,7 +57,7 @@ /** * Returns an array of {@code Type} objects representing the - * lower bound(s) of this type variable. Note that if no lower bound is + * lower bound(s) of this type variable. If no lower bound is * explicitly declared, the lower bound is the type of {@code null}. * In this case, a zero length array is returned. *

2 1

RfR - 8080933: LogManager.demandSystemLogger should accept a 'caller' argument.
by Daniel Fuchs 15 Jun '15

15 Jun '15

Hi, Please find below a fix for https://bugs.openjdk.java.net/browse/JDK-8080933 8080933: LogManager.demandSystemLogger should accept a 'caller' argument. http://cr.openjdk.java.net/~dfuchs/webrev_8080933/webrev.00 LogManager.demandLogger accepts a caller argument which is later used to resolve ResourceBundle. However LogManager.demandSystemLogger doesn't have that caller argument - which could later lead to some inconsistency when resource bundles are resolved. As for now this is more an inconsistency than an issue since by definition the caller that creates a system logger is a system class in the bootstrap class loader. However it could become an issue in a modular JDK - where different system classes may come from different modules and where information on the actual system caller class may be needed. best regards, -- daniel

2 1

TimeZone issue in 1.8u60
by Tomasz Kowalczewski 15 Jun '15

15 Jun '15

Hi, I am not sure where to write about this, I hope somebody will point me to right list if this one is not correct. I have been playing with newest Java 1.8u60 to try PreserveFramePointer functionality. Unfortunately none of our servers start on this version of java. It is because of REST call to Amazon services done during startup. None of these calls worked. Unless I am missing something it turns out to be issue with formatting time zone information as done by Joda Time. It uses calls to: DateTimeUtils.getDateFormatSymbols(Locale.ENGLISH).getZoneStrings(); to get list of timezones. This usually returned array of arrays of 5 elements. In 1.8u60 it returns array of arrays of 7 elements. I know that all this software is not related to OpenJDK and calling getZoneStrings is discouraged in the docs. But as I am unfamiliar with time zones mechanisms inside JDK (loading from bundles etc.) I was hoping that somebody will point me to change that may caused this for sake of better understanding the issue. -- Thanks, Tomasz Kowalczewski

2 3