July 2015 - core-libs-dev

RFR: 8132801: Fix typo in javax.sql.RowSet.setBlob
by Lance Andersen 31 Jul '15

31 Jul '15

Hi all, Need a review of this minor javadoc clean-up: hg diff RowSet.java diff -r 6db2a5a855ec src/java.sql/share/classes/javax/sql/RowSet.java --- a/src/java.sql/share/classes/javax/sql/RowSet.java Fri Jul 31 07:48:34 2015 -0700 +++ b/src/java.sql/share/classes/javax/sql/RowSet.java Fri Jul 31 13:28:12 2015 -0400 @@ -1477,7 +1477,7 @@ /** * Sets the designated parameter to a <code>InputStream</code> object. - * The "{@code InputStream} must contain the number + * The {@code InputStream} must contain the number * of characters specified by length, otherwise a <code>SQLException</code> will be * generated when the <code>CallableStatement</code> is executed. * This method differs from the <code>setBinaryStream (int, InputStream, int)</code> Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

2 1

RfR - 8132550: java/util/logging/LoggingDeadlock2.java times out
by Daniel Fuchs 31 Jul '15

31 Jul '15

Hi, Please find below a fix for: https://bugs.openjdk.java.net/browse/JDK-8132550 8132550: java/util/logging/LoggingDeadlock2.java times out I was able to reproduce the deadlock consistently by inserting some Thread.sleep() statements at the critical places. The webrev still shows that (as commented code) - but I will remove those comments before pushing: http://cr.openjdk.java.net/~dfuchs/webrev_8132550/webrev.00/ This issue here is that LogManager should also use the configurationLock when reading its primordial configuration (and not a simple synchronized(this)). That should remove all uses of synchronized((LogManager)this) from LogManager, and ensure that reset(), readConfiguration(), and ensureLogManagerInitialized() all use the same lock. When we moved to using a ReantrantLock object for configuration I had already considered doing this - but at the time I deemed it unnecessary, thinking you couldn't obtain a reference on LogManager through getLogManager() before it had initialized. But this was counting without System.exit() being called and starting the Cleaner thread before the first call to LogManager.getLogManager() had finished. This introduced a small time window in which the deadlock became possible - at exit time, if something happened to initialize the LogManager right at that time. best regards -- daniel

2 1

RFR(S): 8132704: [TESTBUG] jdk/internal/jimage/ExecutableTest.java incorrectly asserts all files to be executable
by Volker Simonis 31 Jul '15

31 Jul '15

Hi, can somebody please review this test fix: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132704/ https://bugs.openjdk.java.net/browse/JDK-8132704 The initial test checked that all the files in the bin/ directory are executable by everybody. Unfortunately this was too optimistic because in the closed build the bin/ directory contains configuration files which are not executable. The new version of the test uses a predefined static list of executables which are checked for the executable permissions if the corresponding files exist. Thank you and best regards, Volker

4 9

RFR Collector.finisher refers to IDENTITY_TRANSFORM rather than INDENTITY_FINISH
by Paul Sandoz 31 Jul '15

31 Jul '15

Hi, Please review this simple fix to the JavaDoc on j.u.stream.Collector.finisher. I am also opportunistically fixing some internal comments identified by Tagir. Paul. diff -r 4e3135fac8cc src/java.base/share/classes/java/util/stream/Collector.java --- a/src/java.base/share/classes/java/util/stream/Collector.java Fri Jul 24 15:33:13 2015 -0700 +++ b/src/java.base/share/classes/java/util/stream/Collector.java Thu Jul 30 17:05:13 2015 +0200 @@ -223,7 +223,7 @@ * Perform the final transformation from the intermediate accumulation type * {@code A} to the final result type {@code R}. * - * If the characteristic {@code IDENTITY_TRANSFORM} is + * If the characteristic {@code IDENTITY_FINISH} is * set, this function may be presumed to be an identity transform with an * unchecked cast from {@code A} to {@code R}. * diff -r 4e3135fac8cc src/java.base/share/classes/java/util/stream/SliceOps.java --- a/src/java.base/share/classes/java/util/stream/SliceOps.java Fri Jul 24 15:33:13 2015 -0700 +++ b/src/java.base/share/classes/java/util/stream/SliceOps.java Thu Jul 30 17:05:13 2015 +0200 @@ -138,7 +138,7 @@ skip, limit, size); } else { - // @@@ OOMEs will occur for LongStream.longs().filter(i -> true).limit(n) + // @@@ OOMEs will occur for LongStream.range(0, Long.MAX_VALUE)).filter(i -> true).limit(n) // regardless of the value of n // Need to adjust the target size of splitting for the // SliceTask from say (size / k) to say min(size / k, 1 << 14) diff -r 4e3135fac8cc src/java.base/share/classes/java/util/stream/Streams.java --- a/src/java.base/share/classes/java/util/stream/Streams.java Fri Jul 24 15:33:13 2015 -0700 +++ b/src/java.base/share/classes/java/util/stream/Streams.java Thu Jul 30 17:05:13 2015 +0200 @@ -156,10 +156,9 @@ * than a balanced tree at the expense of a higher-depth for the right * side of the range. * - * This is optimized for cases such as IntStream.ints() that is - * implemented as range of 0 to Integer.MAX_VALUE but is likely to be - * augmented with a limit operation that limits the number of elements - * to a count lower than this threshold. + * This is optimized for cases such as IntStream.range(0, Integer.MAX_VALUE) + * that is likely to be augmented with a limit operation that limits the + * number of elements to a count lower than this threshold. */ private static final int BALANCED_SPLIT_THRESHOLD = 1 << 24; @@ -280,10 +279,9 @@ * than a balanced tree at the expense of a higher-depth for the right * side of the range. * - * This is optimized for cases such as LongStream.longs() that is - * implemented as range of 0 to Long.MAX_VALUE but is likely to be - * augmented with a limit operation that limits the number of elements - * to a count lower than this threshold. + * This is optimized for cases such as LongStream.range(0, Long.MAX_VALUE) + * that is likely to be augmented with a limit operation that limits the + * number of elements to a count lower than this threshold. */ private static final long BALANCED_SPLIT_THRESHOLD = 1 << 24;

4 6

RFR: JDK-8114832 it.next on ArrayList throws wrong type of Exception after remove(-1)
by Steve Drach 31 Jul '15

31 Jul '15

Hello, Please review the fix for JDK-8114832. I did what was suggested in the comments in the bug report, moving the increment of modcount to the “right” place. https://bugs.openjdk.java.net/browse/JDK-8114832 <https://bugs.openjdk.java.net/browse/JDK-8114832> http://slc01hfj.us.oracle.com/webrevs/JDK-8114832/webrev/index.html <http://slc01hfj.us.oracle.com/webrevs/JDK-8114832/webrev/index.html> An internal review has been completed. Thanks, Steve

4 6

RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale
by 陆传胜(传胜) 31 Jul '15

31 Jul '15

Hello, The issue was found on one of my Linux boxes which uses locale zh_CN.GB18030 by default, a simple patch was made to fix it, may I have it reviewed ? webrev: http://cr.openjdk.java.net/~luchsh/webrev-8132459/ bug: https://bugs.openjdk.java.net/browse/JDK-8132459 JBS seems to be down right now, so just put related info in this mail. The problem relates to bug JDK-8038310, and below simple command will reproduce it, LANG=zh_CN.GB18030 jdk9/bin/java -version The error message is: Error occurred during initialization of VM java.lang.ExceptionInInitializerError at java.nio.charset.Charset.lookupExtendedCharset(Charset.java:449) at java.nio.charset.Charset.lookup2(Charset.java:479) at java.nio.charset.Charset.lookup(Charset.java:467) at java.nio.charset.Charset.isSupported(Charset.java:508) at java.io.UnixFileSystem.getBooleanAttributes0(Native Method) at java.io.UnixFileSystem.getBooleanAttributes(UnixFileSystem.java:242) at java.io.File.isDirectory(File.java:849) at sun.misc.Launcher$BootClassPathHolder$1.run(Launcher.java:329) at sun.misc.Launcher$BootClassPathHolder$1.run(Launcher.java:316) at java.security.AccessController.doPrivileged(Native Method) at sun.misc.Launcher$BootClassPathHolder.<clinit>(Launcher.java:315) at sun.misc.Launcher.<clinit>(Launcher.java:60) at java.lang.ClassLoader.initSystemClassLoader(ClassLoader.java:1443) at java.lang.ClassLoader.getSystemClassLoader(ClassLoader.java:1428) Caused by: java.lang.NullPointerException at java.lang.ClassLoader.getBootstrapResources(ClassLoader.java:1267) at java.lang.ClassLoader.getSystemResources(ClassLoader.java:1246) at java.util.ServiceLoader$LazyIterator.hasNextService(ServiceLoader.java:344) at java.util.ServiceLoader$LazyIterator.hasNext(ServiceLoader.java:391) at java.util.ServiceLoader$1.hasNext(ServiceLoader.java:472) at java.nio.charset.Charset$ExtendedProviderHolder$1.run(Charset.java:435) at java.nio.charset.Charset$ExtendedProviderHolder$1.run(Charset.java:429) at java.security.AccessController.doPrivileged(Native Method) at java.nio.charset.Charset$ExtendedProviderHolder.extendedProviders(Charset.java:429) at java.nio.charset.Charset$ExtendedProviderHolder.<clinit>(Charset.java:426) at java.nio.charset.Charset.lookupExtendedCharset(Charset.java:449) at java.nio.charset.Charset.lookup2(Charset.java:479) at java.nio.charset.Charset.lookup(Charset.java:467) at java.nio.charset.Charset.isSupported(Charset.java:508) at java.io.UnixFileSystem.getBooleanAttributes0(Native Method) at java.io.UnixFileSystem.getBooleanAttributes(UnixFileSystem.java:242) at java.io.File.isDirectory(File.java:849) at sun.misc.Launcher$BootClassPathHolder$1.run(Launcher.java:329) at sun.misc.Launcher$BootClassPathHolder$1.run(Launcher.java:316) at java.security.AccessController.doPrivileged(Native Method) at sun.misc.Launcher$BootClassPathHolder.<clinit>(Launcher.java:315) at sun.misc.Launcher.<clinit>(Launcher.java:60) at java.lang.ClassLoader.initSystemClassLoader(ClassLoader.java:1443) at java.lang.ClassLoader.getSystemClassLoader(ClassLoader.java:1428) Thanks Jonathan Lu

7 19

RFR JDK-8080252: java.util.Formatter documentation of %n converter is misleading
by Xueming Shen 31 Jul '15

31 Jul '15

Hi, Please help review the change for issue: https://bugs.openjdk.java.net/browse/JDK-8080252 webrev: http://cr.openjdk.java.net/~sherman/8080252/ It appears we updated the j.u.Formatter implementation to use the newly introduced method System.lineSeparator() in jdk7, but did not update the doc accordingly. For the old the behavior, I would assume the initial intent is to treat the system property line.separator as a read-only/informative property. Given the fact the it has been 2 major releases (7, 8), I would assume this change is now a kind of change to "update the javadoc to describe the existing implementation correctly". So a CCC is not needed. Thanks, Sherman

2 1

RFR(xs): 8132745: minor cleanup of java/util/Scanner/ScanTest.java
by Stuart Marks 30 Jul '15

30 Jul '15

Hi all, Please review this quick cleanup to this test I moved into the open yesterday. It changes the JVM's locale, and out of an abundance of caution it's safer to run things that change JVM global state in /othervm mode. Bug: https://bugs.openjdk.java.net/browse/JDK-8132745 Patch appended below. Thanks, s'marks # HG changeset patch # User smarks # Date 1438295744 25200 # Thu Jul 30 15:35:44 2015 -0700 # Node ID 4ce7979b7610574075bd4ade3b73004cde5e9ac3 # Parent d23203801b5369603d2dda21a6aff6225195001d 8132745: minor cleanup of java/util/Scanner/ScanTest.java Reviewed-by: XXX diff -r d23203801b53 -r 4ce7979b7610 test/java/util/Scanner/ScanTest.java --- a/test/java/util/Scanner/ScanTest.java Thu Jul 30 14:16:58 2015 -0400 +++ b/test/java/util/Scanner/ScanTest.java Thu Jul 30 15:35:44 2015 -0700 @@ -26,6 +26,7 @@ * @bug 4313885 4926319 4927634 5032610 5032622 5049968 5059533 6223711 6277261 6269946 6288823 * @summary Basic tests of java.util.Scanner methods * @key randomness + * @run main/othervm ScanTest */ import java.util.*;

3 2

RfR - 8130058: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/Process.java
by Daniel Fuchs 30 Jul '15

30 Jul '15

Hi, Please find below a patch that removes a bunch of unused files in jdk9/dev/jaxp: https://bugs.openjdk.java.net/browse/JDK-8130058 8130058: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/Process.java http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.00/ best regards, -- daniel

3 6

RFR 9: JDK-8132705 : Refactor SharedSecrets in sun.misc.JavaNetAccess
by Roger Riggs 30 Jul '15

30 Jul '15

Please review this refactoring of SharedSecret initialization to create and InetAddressAccess access that is independent of the initialization of JavaNetAccess in URLClassLoader. (jprt in progress) Webrev: http://cr.openjdk.java.net/~rriggs/webrev-inetaccess-8132705/ Issue: https://bugs.openjdk.java.net/browse/JDK-8132705 Roger

4 5