July 2015 - core-libs-dev

Re: RFR(XS): 8075658: Mark intermittently failuring core-svc tests
by Yekaterina Kantserova 17 Jul '15

17 Jul '15

Jaroslav, Thank you for the review! It has been a relatively manual process and I'm not aware of a mechanism how to sync test-key-bug. What I can do is to mark bugs I went through with for example 'key-intermittent' label to distinguish them form the new ones. Are there other suggestions? // Katja On 07/17/2015 03:04 PM, Jaroslav Bachorik wrote: > Looks good. > > Is there any way to check that all the issues from the JBS query > mentioned in JDK-8075658 are addressed? > > -JB- > > On 17.7.2015 14:47, Yekaterina Kantserova wrote: >> Hi, >> >> Could I please have a review of this fix. >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8075658 >> webrev: http://cr.openjdk.java.net/~ykantser/8075658/webrev.00 >> >> Thanks, >> Katja >

3 2

RFR(XS): 8075658: Mark intermittently failuring core-svc tests
by Yekaterina Kantserova 17 Jul '15

17 Jul '15

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8075658 webrev: http://cr.openjdk.java.net/~ykantser/8075658/webrev.00 Thanks, Katja

1 0

Idea to Java ArrayLists
by Philipp Bibik 17 Jul '15

17 Jul '15

Hi, I'm Philipp Bibik and a 16 jear old free time developer. I was born and live in Germany and have only an bad school english, so sorry for any grammar and spelling mistakes. I have an idea to improve the Java ArrayList API. Lists are one of the most imported and used components in the Java API. Although there are relay well designed, there was always something that annoyed me. If you want to create an ArrayList with "String" as diamond operator and add the Strings "1" to "5" to them, you need to do something like this: ArrayList<String> strings = new ArrayList<>(); strings.add("1"); strings.add("2"); strings.add("3"); strings.add("4"); strings.add("5"); I added a few lines of code the the ArrayList class: /** * @param e array whose elements are to be placed into this list */ @SafeVarargs public ArrayList(E... e) { elementData = e; size = elementData.length; } After adding the lines above I was able to accomplish the same result with 77 chars / 5 lines less code: ArrayList<String> strings = new ArrayList<>("1", "2", "3", "4", "5"); In my opinion adding a constructor like this to the "java.util.ArrayList" class and all other (at least some) classes, implementing the "java.util.List" interface would be a big improvement to Java SE9. Thanks for reading, - Philipp Bibik.

10 13

RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast
by Michael Haupt 16 Jul '15

16 Jul '15

Dear all, please review and sponsor this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8062543 Webrev: http://cr.openjdk.java.net/~mhaupt/8062543/webrev.00/ The change removes the no longer needed MethodHandleImpl.castReference method. Its uses are replaced with Class.cast. Tested with: * jtreg (java.lang.invoke, java.util.stream) * JPRT (hotspot and jdk_lang test sets) * UTE (vm.quick-pcl.testlist, vm.defmeth.testlist) Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

3 5

Typo in AbstractSpliterator Javadoc
by Stefan Zobel 16 Jul '15

16 Jul '15

Hi all, I just noticed some typos in the Spliterators.Abstract(Double/Int/Long)Spliterator Javadoc: a) The forEachRemaining link label is "forEach" instead of "forEachRemaining" in all AbstractSpliterators. b) The primitive AbstractSpliterators Javadoc has a surplus "}" just before the tryAdvance and forEach link labels. Stefan

3 4

JDK 9 RFR of JDK-8131140: Mark some tests from WhileOpStatefulTest.java and WhileOpTest.java as serialization hostile
by Amy Lu 16 Jul '15

16 Jul '15

Stream tests WhileOpStatefulTest and WhileOpTest were newly introduced in JDK-8071597, some test cases should be marked as serialization-hostile (such tests will be ignored by lambda serialization testing framework). Please review and sponsor this change: bug: https://bugs.openjdk.java.net/browse/JDK-8131140 webrev: http://cr.openjdk.java.net/~amlu/8131140/webrev.00/ Thanks, Amy

2 2

[9] RFR 8129833: Need basic tests for rmic
by FELIX YANG 15 Jul '15

15 Jul '15

Hi Daniel, please help to review the change for 8129833. Issue: https://bugs.openjdk.java.net/browse/JDK-8129833 Patch: http://cr.openjdk.java.net/~fyuan/felix/8129833/ The patch add a new class to try rmic with. It covers a problem of locating the class java.awt.Panel in jigsaw build, see https://bugs.openjdk.java.net/browse/JDK-8129779. thanks, -Felix

2 2

Speed optimization of Spliterators.spliteratorUnknownSize for parallel case
by Tagir F. Valeev 15 Jul '15

15 Jul '15

Hello! The problem of ineffective parallelization of spliteratorUnknownSize for low-N/high-Q tasks was already discussed in the thread "Exploiting concurrency with IteratorSpliterator of unknown size" [ http://mail.openjdk.java.net/pipermail/lambda-dev/2014-March/011968.html ] It was proposed to modify some heuristics and/or add some parameters to control them. I have a simpler idea which allows to run in parallel high-Q tasks for N <~ 3000 about twice faster without any API changes while having no visible impact for high-N or sequential cases. Here's the gist with proof-of-concept implementation (UnknownSizeSpliterator.java), JMH benchmark (IteratorTest.java) and benchmarking results (performed on Quad-Core i5-3340, Win7 64bit): https://gist.github.com/amaembo/781c64a3b4f48fdeb196 The problem which I noticed is the following. When trySplit is requested and JDK IteratorSpliterator fills the buffer, it may suddenly discover that the source iterator has no more elements. At this point the IteratorSpliterator splits in very uneven manner. Namely it dumps everything into the ArraySpliterator leaving no elements for itself. As it did not report the size previously, the pipeline engine assumes that both parts are roughly equal which result in very poor performance. I merged both IteratorSpliterator and ArraySpliterator into single class UnknownSizeSpliterator. When it sees that input spliterator has no more elements, it converts itself into array-mode and splits right here to two equal parts, thus the first call of trySplit for N < 1024 performs actual split. Note that I did not change the heuristics at all, thus for big-N tasks the results should be the same. My implementation is a little bit simplified (no additional characteristics, no precondition checks, no primitive implementations), but I guess current version is ok for preliminary testing to decide whether it's good or bad. This implementation might improve the performance of existing methods like BufferedReader.lines, Files.lines, Pattern.splitAsStream when using the parallel stream as well as user-defined iterator-based spliterators. Also it maybe useful for JDK-8072727 feature [ https://bugs.openjdk.java.net/browse/JDK-8072727 ]. What do you think? With best regards, Tagir Valeev.

2 4

RFR: 8032446: Support Unicode 7.0.0 in JDK 9
by Yuka Kamiya 15 Jul '15

15 Jul '15

Hello, Please review the fix for 8032446 to support Unicode 7 in JDK 9. https://bugs.openjdk.java.net/browse/JDK-8032446 http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ - Internal review for both open & closed parts has been completed. - Changes in sun.text.* packages are mostly porting from ICU4J. (Thank you very much, ICU4J project.) - Because Unicode 8 was released last month, this fix will be overwritten (partially) in near future. Thanks, -- Yuka

3 2

[9]RFR 8130394: DatagramChannel tests need to be hardened to ignore stray datagrams
by FELIX YANG 15 Jul '15

15 Jul '15

Hi all, please help to review the change for 8130394. Issue: https://bugs.openjdk.java.net/browse/JDK-8130394 Patch: http://cr.openjdk.java.net/~fyuan/felix/8130394/ The patch updates tests to ignore stray datagrams, or at least print more information to ease troubleshooting. thanks, -Felix

3 2