July 2015 - core-libs-dev

RFR: 6260652: (coll) Arrays.asList(x).toArray().getClass() should be Object[].class
by Martin Buchholz 09 Jul '15

09 Jul '15

10 years later ... still asking for approval to commit. https://bugs.openjdk.java.net/browse/JDK-6260652 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Arrays.asList.toArray/

4 10

RFR 9: 8098852 : java/lang/ProcessHandle/InfoTest.java failed: total cpu time
by Roger Riggs 09 Jul '15

09 Jul '15

Please review this ProcessHandle test change to cleanup intermittent failures. The cpuloop timing uses the cputime of the spawned process and the test runs fewer iterations and relaxes the threshold. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-info-8098852/ Issue: https://bugs.openjdk.java.net/browse/JDK-8098852 Thanks, Roger

3 6

RFR 9: 8130296 [TESTBUG] java/lang/ProcessHandle/OnExitTest - Unaccounted for children
by Roger Riggs 08 Jul '15

08 Jul '15

Please review this change to a ProcessHandle test to address intermittent failures. Unexpected subprocesses has been observed. The test succeeds if all of the processes under test are accounted for; others are ignored. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-exit-8130296/ Issue: https://bugs.openjdk.java.net/browse/JDK-8130296 Thanks, Roger

3 4

JDK 9 RFR of JDK-8130402: Mark intermittently failing test: tools/pack200/PackTestZip64.java
by Amy Lu 08 Jul '15

08 Jul '15

tools/pack200/PackTestZip64.java This test has been observed to fail intermittently. This patch is to mark it accordingly with keyword 'intermittent'. bug: https://bugs.openjdk.java.net/browse/JDK-8130402 webrev: http://cr.openjdk.java.net/~amlu/8130402/webrev.00/ Thanks, Amy --- old/test/tools/pack200/PackTestZip64.java 2015-07-08 15:51:12.000000000 +0800 +++ new/test/tools/pack200/PackTestZip64.java 2015-07-08 15:51:12.000000000 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2015, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -37,6 +37,7 @@ * @compile -XDignore.symbol.file Utils.java PackTestZip64.java * @run main PackTestZip64 * @author kizune + * @key intermittent */ public class PackTestZip64 {

2 1

JDK-8071597: close original Stream in default implementation?
by Tagir F. Valeev 08 Jul '15

08 Jul '15

Hello, I was looking at default implementation of new Stream takeWhile/dropWhile methods: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8071597-take-drop-while/webrev… I think in order to make this default behavior more consistent, the original Stream must be closed when the returned one is closed. Thus, takeWhile return statement should look like this: return StreamSupport.stream( new WhileOps.UnorderedWhileSpliterator.OfRef.Taking<> (spliterator(), true, predicate), isParallel()).onClose(this::close); The same for dropWhile method. What do you think? Regards, Tagir Valeev.

2 1

RFR 9: 8085981 java/lang/ProcessHandle/OnExitTest.java: AssertionError: Child onExit not called
by Roger Riggs 08 Jul '15

08 Jul '15

Please review this test fix for a race condition checking that the onExit CompletableFuture was completed and with the correct value. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-onexit-8085981/ Issue: https://bugs.openjdk.java.net/browse/JDK-8085981 Thanks, Roger

2 1

JDK 9 RFR of JDK-8130719: Fix reference problems in jax-ws javadoc
by joe darcy 08 Jul '15

08 Jul '15

Hello, Please review the patch below which fixes some javadoc reference issues in jax-ws: JDK-8130719: Fix reference problems in jax-ws javadoc Thanks, -Joe diff -r 1d87054e2d2f src/java.xml.ws/share/classes/javax/xml/ws/handler/soap/SOAPMessageContext.java --- a/src/java.xml.ws/share/classes/javax/xml/ws/handler/soap/SOAPMessageContext.java Thu Jul 02 16:09:51 2015 -0700 +++ b/src/java.xml.ws/share/classes/javax/xml/ws/handler/soap/SOAPMessageContext.java Tue Jul 07 17:28:29 2015 -0700 @@ -55,7 +55,7 @@ /** Sets the SOAPMessage in this message context * * @param message SOAP message - * @throws WebServiceException If any error during the setting + * @throws javax.xml.ws.WebServiceException If any error during the setting * of the <code>SOAPMessage</code> in this message context * @throws java.lang.UnsupportedOperationException If this * operation is not supported @@ -76,7 +76,7 @@ * @return An array of unmarshalled headers; returns an empty array if no * message is present in this message context or no headers match * the supplied qualified name. - * @throws WebServiceException If an error occurs when using the supplied + * @throws javax.xml.ws.WebServiceException If an error occurs when using the supplied * <code>JAXBContext</code> to unmarshall. The cause of * the <code>WebServiceException</code> is the original <code>JAXBException</code>. **/ diff -r 1d87054e2d2f src/java.xml.ws/share/classes/javax/xml/ws/soap/SOAPBinding.java --- a/src/java.xml.ws/share/classes/javax/xml/ws/soap/SOAPBinding.java Thu Jul 02 16:09:51 2015 -0700 +++ b/src/java.xml.ws/share/classes/javax/xml/ws/soap/SOAPBinding.java Tue Jul 07 17:28:29 2015 -0700 @@ -70,7 +70,7 @@ /** Sets the roles played by the SOAP binding instance. * * @param roles The set of roles played by the binding instance. - * @throws WebServiceException On an error in the configuration of + * @throws javax.xml.ws.WebServiceException On an error in the configuration of * the list of roles. **/ public void setRoles(Set<String> roles); @@ -88,7 +88,7 @@ * * @param flag A {@code boolean} specifying whether the use of MTOM should * be enabled or disabled. - * @throws WebServiceException If the specified setting is not supported + * @throws javax.xml.ws.WebServiceException If the specified setting is not supported * by this binding instance. * **/

3 2

JDK 9 RFR of JDK-8130716: Fix reference problems in jaxp javadoc
by joe darcy 07 Jul '15

07 Jul '15

Hello, Please review the small patch below to address JDK-8130716: Fix reference problems in jaxp javadoc Thanks, -Joe diff -r 39ac2a55f28d src/java.xml/share/classes/javax/xml/stream/XMLEventReader.java --- a/src/java.xml/share/classes/javax/xml/stream/XMLEventReader.java Tue Jul 07 18:19:57 2015 +0200 +++ b/src/java.xml/share/classes/javax/xml/stream/XMLEventReader.java Tue Jul 07 15:13:48 2015 -0700 @@ -49,7 +49,7 @@ * Get the next XMLEvent * @see XMLEvent * @throws XMLStreamException if there is an error with the underlying XML. - * @throws NoSuchElementException iteration has no more elements. + * @throws java.util.NoSuchElementException iteration has no more elements. */ public XMLEvent nextEvent() throws XMLStreamException; diff -r 39ac2a55f28d src/java.xml/share/classes/javax/xml/stream/events/XMLEvent.java --- a/src/java.xml/share/classes/javax/xml/stream/events/XMLEvent.java Tue Jul 07 18:19:57 2015 +0200 +++ b/src/java.xml/share/classes/javax/xml/stream/events/XMLEvent.java Tue Jul 07 15:13:48 2015 -0700 @@ -170,7 +170,7 @@ * infoset expressed. * * @param writer The writer that will output the data - * @throws XMLStreamException if there is a fatal error writing the event + * @throws javax.xml.stream.XMLStreamException if there is a fatal error writing the event */ public void writeAsEncodedUnicode(Writer writer) throws javax.xml.stream.XMLStreamException;

2 1

RFR 9: 8085980 java/lang/ProcessHandle/TreeTest.java: AssertionError: Wrong number of spawned children
by Roger Riggs 07 Jul '15

07 Jul '15

Please review changes to the ProcessHandle TreeTest to address intermittent failures. Since spurious processes have been observed, the test only tracks the subprocesses it launches and ignores unknown subprocesses.The end-of-test cleanup is more rigorous. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-tree-8085980/ Issue: https://bugs.openjdk.java.net/browse/JDK-8085980 Thanks, Roger

2 1

RfR - 8130649: java/util/logging/LoggingDeadlock2.java times out
by Daniel Fuchs 07 Jul '15

07 Jul '15

Please find below a changeset to address: 8130649: java/util/logging/LoggingDeadlock2.java times out https://bugs.openjdk.java.net/browse/JDK-8130649 The proposed changeset doesn't fix the issue but instruments the test a bit more so that we can get a clue of what is happening. http://cr.openjdk.java.net/~dfuchs/webrev_8130649/webrev.00/ When a test fails in timeout, jtreg obtains a Thread Dump before killing it. However - in our case - that thread dump is quite uninteresting - because the real test is performed in a subprocess - and that's where bad things could be happening. The proposed instrumentation will try to obtain a thread dump of the subprocess after a sensible time (60secs) but before the jtreg timeout kicks in (default jtreg timeout should be about 120sec x time factor - if I remember well). best regards, -- daniel

2 1