February 2021 - core-libs-dev

RFR: 8262379: Add regression test for JDK-8257746
by Severin Gehwolf 01 Mar '21

01 Mar '21

Fails prior the patch of JDK-8257746, passes after. As expected. Thoughts? ------------- Commit messages: - 8262379: Add regression test for JDK-8257746 Changes: https://git.openjdk.java.net/jdk/pull/2725/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2725&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262379 Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2725.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2725/head:pull/2725 PR: https://git.openjdk.java.net/jdk/pull/2725

2 4

Re: RFR: 8262096: Vector API fails to work due to VectorShape initialization exception [v6]
by Jie Fu 27 Feb '21

27 Feb '21

> Hi all, > > Vector API fails to work when: > - case 1: MaxVectorSize is set to <=8, or > - case 2: C2 is disabled > > The reason is that {max/preferred} VectorShape initialization fails in both cases. > And the root cause is that VectorSupport_GetMaxLaneCount [1] returns unreasonable values (0 for case 1 and -1 for case 2). > > Vector API should not depend on C2 to run. > It should work even there is no JIT compiler since it's a Java-level api. > So let's fix it. > > Testing: > - jdk/incubator/vector with -XX:MaxVectorSize=default/8 on Linux/x64 > > Thanks. > Best regards, > Jie > > [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/vectorSu… Jie Fu has updated the pull request incrementally with one additional commit since the last revision: Add requires vm.compiler2.enabled ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2722/files - new: https://git.openjdk.java.net/jdk/pull/2722/files/b67b232d..79402411 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=05 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=04-05 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2722.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2722/head:pull/2722 PR: https://git.openjdk.java.net/jdk/pull/2722

1 0

Re: RFR: 8262096: Vector API fails to work due to VectorShape initialization exception [v4]
by Jie Fu 27 Feb '21

27 Feb '21

> Hi all, > > Vector API fails to work when: > - case 1: MaxVectorSize is set to <=8, or > - case 2: C2 is disabled > > The reason is that {max/preferred} VectorShape initialization fails in both cases. > And the root cause is that VectorSupport_GetMaxLaneCount [1] returns unreasonable values (0 for case 1 and -1 for case 2). > > Vector API should not depend on C2 to run. > It should work even there is no JIT compiler since it's a Java-level api. > So let's fix it. > > Testing: > - jdk/incubator/vector with -XX:MaxVectorSize=default/8 on Linux/x64 > > Thanks. > Best regards, > Jie > > [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/vectorSu… Jie Fu has updated the pull request incrementally with one additional commit since the last revision: Remove -XX:TieredStopAtLevel=3 ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2722/files - new: https://git.openjdk.java.net/jdk/pull/2722/files/aa475b0a..bbe6150c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2722.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2722/head:pull/2722 PR: https://git.openjdk.java.net/jdk/pull/2722

3 5

RFR: JDK-8262199: TOCTOU in jli args.c
by Matthias Baesken 26 Feb '21

26 Feb '21

Sonar reports a finding in args.c, where a file check is done . Stat performs a check on file, and later fopen is called on the file : https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=c&open=AXck8… The coding could be slightly rewritten so that the potential TOCTOU is removed (however I do not think that it is such a big issue). ------------- Commit messages: - JDK-8262199 Changes: https://git.openjdk.java.net/jdk/pull/2692/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2692&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262199 Stats: 32 lines in 1 file changed: 12 ins; 16 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/2692.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2692/head:pull/2692 PR: https://git.openjdk.java.net/jdk/pull/2692

3 19

Re: RFR: 8262096: Vector API fails to work due to VectorShape initialization exception
by Paul Sandoz 26 Feb '21

26 Feb '21

On Thu, 25 Feb 2021 09:31:01 GMT, Jie Fu <jiefu(a)openjdk.org> wrote: > Hi all, > > Vector API fails to work when: > - case 1: MaxVectorSize is set to <=8, or > - case 2: C2 is disabled > > The reason is that {max/preferred} VectorShape initialization fails in both cases. > And the root cause is that VectorSupport_GetMaxLaneCount [1] returns unreasonable values (0 for case 1 and -1 for case 2). > > Vector API should not depend on C2 to run. > It should work even there is no JIT compiler since it's a Java-level api. > So let's fix it. > > Testing: > - jdk/incubator/vector with -XX:MaxVectorSize=default/8 on Linux/x64 > > Thanks. > Best regards, > Jie > > [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/vectorSu… src/hotspot/share/prims/vectorSupport.cpp line 368: > 366: if (java_lang_Class::is_primitive(mirror)) { > 367: BasicType bt = java_lang_Class::primitive_type(mirror); > 368: int min_lane_count = 64 / type2aelembytes(bt); I am uncertain of the units here. Is the numerator in bits and the denominator in bytes? ------------- PR: https://git.openjdk.java.net/jdk/pull/2722

2 5

Re: RFR: 8262096: Vector API fails to work due to VectorShape initialization exception [v3]
by Jie Fu 26 Feb '21

26 Feb '21

> Hi all, > > Vector API fails to work when: > - case 1: MaxVectorSize is set to <=8, or > - case 2: C2 is disabled > > The reason is that {max/preferred} VectorShape initialization fails in both cases. > And the root cause is that VectorSupport_GetMaxLaneCount [1] returns unreasonable values (0 for case 1 and -1 for case 2). > > Vector API should not depend on C2 to run. > It should work even there is no JIT compiler since it's a Java-level api. > So let's fix it. > > Testing: > - jdk/incubator/vector with -XX:MaxVectorSize=default/8 on Linux/x64 > > Thanks. > Best regards, > Jie > > [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/vectorSu… Jie Fu has updated the pull request incrementally with one additional commit since the last revision: Update the jtreg test ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2722/files - new: https://git.openjdk.java.net/jdk/pull/2722/files/724b36d4..aa475b0a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=01-02 Stats: 59 lines in 2 files changed: 10 ins; 48 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2722.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2722/head:pull/2722 PR: https://git.openjdk.java.net/jdk/pull/2722

1 0

ZipInputStream#readAllBytes should clarify it doesn't read the whole stream?
by Jaikiran Pai 26 Feb '21

26 Feb '21

The javadoc of InputStream#readAllBytes() states[1] that it reads all the remaining bytes of the stream. The java.util.zip.ZipInputStream doesn't override this method and thus "inherits" this javadoc. The implementation of InputStream#readAllBytes() ultimately ends up calling ZipInputStream#read()[2], so the implementation correctly reads only till the end of the current ZipEntry and not the entire ZipInputStream. However, because the javadoc gets inherited, reading any code like the following doesn't make it clear that it's only reading till the end of the current entry: zis = ... // ZipInputStream while ((e = zis.getNextEntry()) != null) { String name = e.getName(); zis.readAllBytes(); // gives an impression that all bytes of the stream are read ... } Should the ZipInputStream override the readAllBytes(), just so as to add a very specific javadoc to this method which explains that it reads only till the end of current entry and other related semantics? Perhaps the same should be done for ZipInputStream#readNBytes(...)? [1] https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/io/InputS… [2] https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/util/zip/… -Jaikiran

3 4

RFR: JDK-8262433: doclint: reference error in module jdk.incubator.foreign
by Jonathan Gibbons 26 Feb '21

26 Feb '21

Please review a simple fix to ensure that a link reference is resolved and displayed correctly. ------------- Commit messages: - JDK-8262433: doclint: reference error in module jdk.incubator.foreign Changes: https://git.openjdk.java.net/jdk/pull/2739/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2739&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262433 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2739.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2739/head:pull/2739 PR: https://git.openjdk.java.net/jdk/pull/2739

3 3

Re: RFR: 8262096: Vector API fails to work due to VectorShape initialization exception [v2]
by Jie Fu 25 Feb '21

25 Feb '21

> Hi all, > > Vector API fails to work when: > - case 1: MaxVectorSize is set to <=8, or > - case 2: C2 is disabled > > The reason is that {max/preferred} VectorShape initialization fails in both cases. > And the root cause is that VectorSupport_GetMaxLaneCount [1] returns unreasonable values (0 for case 1 and -1 for case 2). > > Vector API should not depend on C2 to run. > It should work even there is no JIT compiler since it's a Java-level api. > So let's fix it. > > Testing: > - jdk/incubator/vector with -XX:MaxVectorSize=default/8 on Linux/x64 > > Thanks. > Best regards, > Jie > > [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/vectorSu… Jie Fu has updated the pull request incrementally with one additional commit since the last revision: The numerator should be 8 (byte) ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2722/files - new: https://git.openjdk.java.net/jdk/pull/2722/files/09b49f25..724b36d4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2722&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2722.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2722/head:pull/2722 PR: https://git.openjdk.java.net/jdk/pull/2722

1 0

RFR: JDK-8262428: doclint warnings in java.xml module
by Jonathan Gibbons 25 Feb '21

25 Feb '21

Please review a small doc fix to remove some superfluous `<p>` tags and an erroneous `</tr>` tag, all reported by doclint.. ------------- Commit messages: - JDK-8262428: doclint warnings in java.xml module Changes: https://git.openjdk.java.net/jdk/pull/2733/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2733&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262428 Stats: 7 lines in 1 file changed: 0 ins; 5 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2733.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2733/head:pull/2733 PR: https://git.openjdk.java.net/jdk/pull/2733

5 5