February 2021 - core-libs-dev

RFR: 8253409: Double-rounding possibility in float fma
by Joe Darcy 23 Feb '21

23 Feb '21

In floating-point, usually doing an operation to double precision and then rounding to float gives the right result in float precision. One exception to this is fused multiply add (fma) where "a * b + c" is computed with a single rounding. This requires the equivalent of extra intermediate precision inside the operation. If a float fma is implemented using a double fma rounded to float, for some well-chosen arguments where the final result is near a half-way result in *float*, an incorrect answer will be computed due to double rounding. In more detail, the double result will round up and then the cast to float will round up again whereas a single rounding of the exact answer to float would only round-up once. The new float fma implementation does the exact arithmetic using BigDecimal where possible, with guard to handle the non-finite and signed zero IEEE 754 details. ------------- Commit messages: - 8253409: Double-rounding possibility in float fma Changes: https://git.openjdk.java.net/jdk/pull/2684/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2684&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253409 Stats: 31 lines in 2 files changed: 3 ins; 11 del; 17 mod Patch: https://git.openjdk.java.net/jdk/pull/2684.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2684/head:pull/2684 PR: https://git.openjdk.java.net/jdk/pull/2684

2 4

RE: Fast and cheap (Double|Float)::toString Java algorithm
by Andrey Turbanov 23 Feb '21

23 Feb '21

>The last implementation is available in pre-Skara webrev form, as referenced in [2] Hope to see it as a github review soon! Andrey Turbanov

1 0

RFR: 8261975: Missing "classpath exception" in VectorSupport.java
by Paul Sandoz 23 Feb '21

23 Feb '21

Add missing classpath exception paragraph ------------- Commit messages: - 8261975: Missing "classpath exception" in VectorSupport.java Changes: https://git.openjdk.java.net/jdk/pull/2678/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2678&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261975 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2678.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2678/head:pull/2678 PR: https://git.openjdk.java.net/jdk/pull/2678

2 2

Re: RFR: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java [v2]
by Naoto Sato 22 Feb '21

22 Feb '21

> The subject test case is failing under the JMS-enabled environment. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Limit the exclustion to linux-x64 ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2657/files - new: https://git.openjdk.java.net/jdk/pull/2657/files/7c9cf40e..6a6bc241 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2657&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2657&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2657.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2657/head:pull/2657 PR: https://git.openjdk.java.net/jdk/pull/2657

1 0

RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)
by Doug Lea 22 Feb '21

22 Feb '21

This addresses interactions between parallelism-0 and new shutdown support in https://bugs.openjdk.java.net/browse/JDK-8259800 ------------- Commit messages: - JDK-8259800 Changes: https://git.openjdk.java.net/jdk/pull/2661/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2661&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259800 Stats: 347 lines in 2 files changed: 175 ins; 106 del; 66 mod Patch: https://git.openjdk.java.net/jdk/pull/2661.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2661/head:pull/2661 PR: https://git.openjdk.java.net/jdk/pull/2661

3 5

RFR: 8248318: Examine the use of boxing in ObjectStreamClass
by Julia Boes 22 Feb '21

22 Feb '21

This change removes some instances of superfluous boxing in java.io.ObjectStreamClass. Testing: tier 1-3 all clear. ------------- Commit messages: - remove superfluous boxing Changes: https://git.openjdk.java.net/jdk/pull/2641/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2641&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248318 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/2641.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2641/head:pull/2641 PR: https://git.openjdk.java.net/jdk/pull/2641

6 6

RFR: 8261621: Delegate Unicode history from JLS to j.l.Character
by Naoto Sato 22 Feb '21

22 Feb '21

Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly. ------------- Commit messages: - 8261621: Delegate Unicode history from JLS to j.l.Character Changes: https://git.openjdk.java.net/jdk/pull/2538/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2538&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261621 Stats: 37 lines in 1 file changed: 35 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2538.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2538/head:pull/2538 PR: https://git.openjdk.java.net/jdk/pull/2538

8 17

RFR: 8261290: Improve error message for NumberFormatException on null input
by Joe Darcy 21 Feb '21

21 Feb '21

In Integer and Long, several of the parsing methods are specified to throw NumberFormatException on a null input rather than an NPE. That behavior is not proposed to be modified. However, I think it is reasonable for the NumberFormatException to have a more informative error message than just "null" -- specifically "Cannot parse null string" is proposed here. All four prior occurrences of throw new NumberFormatException("null") have be updated; there were no other instances of this idiom in the java.lang package. All java/lang/{Integer, Long} regression tests pass with this change. ------------- Commit messages: - Initial commit. Changes: https://git.openjdk.java.net/jdk/pull/2663/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2663&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261290 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/2663.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2663/head:pull/2663 PR: https://git.openjdk.java.net/jdk/pull/2663

3 3

RFR: 8262041: javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java fails after JDK-8260858
by Joe Wang 20 Feb '21

20 Feb '21

A quick fix to the test, removing Windows carriage return in the result. ------------- Commit messages: - 8262041: javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java fails after JDK-8260858 Changes: https://git.openjdk.java.net/jdk/pull/2656/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2656&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262041 Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2656.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2656/head:pull/2656 PR: https://git.openjdk.java.net/jdk/pull/2656

3 3

RFR: 8261938: ASN1Formatter.annotate should not return in the finally block
by Jie Fu 19 Feb '21

19 Feb '21

Hi all, ASN1Formatter.annotate should be able to throw an IOException according to this comment [1]. But it fails to do so due to the return [2] in the finally block, which would swallow the IOException. Generally, it seems not good to put a return statement in a finally block because it would overwrite other return-statements or Exceptions [3]. Thanks. Best regards, Jie [1] https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/hexdump/AS… [2] https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/hexdump/AS… [3] https://stackoverflow.com/questions/17481251/finally-block-does-not-complet… ------------- Commit messages: - 8261938: ASN1Formatter.annotate should not return in the finally block Changes: https://git.openjdk.java.net/jdk/pull/2620/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2620&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261938 Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2620.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2620/head:pull/2620 PR: https://git.openjdk.java.net/jdk/pull/2620

2 9