February 2021 - core-libs-dev

JDK-8262003: Class.arrayType should not throw IllegalArgumentException
by Johannes Kuhn 25 Feb '21

25 Feb '21

I want to learn about writing a CSR, and need a sponsor teaching me the ropes. ---- Bug: https://bugs.openjdk.java.net/browse/JDK-8262003 Currently, Class.arrayType() will throw an IllegalArgumentException if the maximum number of dimensions will be exceeded. Throwing an IllegalArgumentException from a method that doesn't take an argument is, at least, strange. Therefore I would like to update the specification to allow this method to throw an IllegalStateException, similar to what ClassDesc.arrayType() does. ---- The current plan is: * Create a CSR detailing the spec changes: https://bugs.openjdk.java.net/browse/JDK-8262211 * Surround the code with a try-catch block. Checking for the error case is hard, and somewhat rare, so I think this is appropriate. * Copy the @throws javadoc line from ClassDesc.arrayType to Class.arrayType But there are a few questions I would love to get the answer on: * Both Class.arrayType() and ClassDesc.arrayType() are specified by TypeDescriptor.OfField. Should the specification of TypeDescriptor.OfField.arrayType() changed as well? * Is the draft of my CSR fine? Should I add some details, or omit things? Rephrase things? In advance, thanks for any support and feedback on this. - Johannes

2 3

RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides
by Brian Burkhalter 25 Feb '21

25 Feb '21

8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides ------------- Commit messages: - 8258444: Fix trailing whitesoace - 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides Changes: https://git.openjdk.java.net/jdk/pull/2680/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2680&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258444 Stats: 156 lines in 9 files changed: 41 ins; 57 del; 58 mod Patch: https://git.openjdk.java.net/jdk/pull/2680.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2680/head:pull/2680 PR: https://git.openjdk.java.net/jdk/pull/2680

4 13

RFR: 8260403: javap should be more robust in the face of invalid class files
by Adam Sotona 25 Feb '21

25 Feb '21

Please review javap fix to handle java.lang.IllegalStateException for classes with invalid Signature attribute. New test (T8260403) parsing class with invalid Signature attribute (as described in the bug) is included. Fix wraps java.lang.IllegalStateException, reports "Error: Invalid value for Signature attribute: <signature debug info>" and continues. Thanks, Adam ------------- Commit messages: - 8260403: javap should be more robust in the face of invalid class files Changes: https://git.openjdk.java.net/jdk/pull/2724/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2724&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260403 Stats: 165 lines in 3 files changed: 164 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2724.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2724/head:pull/2724 PR: https://git.openjdk.java.net/jdk/pull/2724

2 2

Re: 8260403: javap should be more robust in the face of invalid class files
by Adam Sotona 25 Feb '21

25 Feb '21

Hi Vicente, thanks for the review. May I ask you also to /sponsor this PR? Thanks again, Adam On 25/02/2021, 16:39, "core-libs-dev on behalf of Vicente Romero" <core-libs-dev-retn(a)openjdk.java.net on behalf of vromero(a)openjdk.java.net> wrote: On Thu, 25 Feb 2021 13:01:30 GMT, Adam Sotona <asotona(a)openjdk.org> wrote: > Please review javap fix to handle java.lang.IllegalStateException for classes with invalid Signature attribute. > New test (T8260403) parsing class with invalid Signature attribute (as described in the bug) is included. > Fix wraps java.lang.IllegalStateException, reports "Error: Invalid value for Signature attribute: <signature debug info>" and continues. > > Thanks, > Adam lgtm! ------------- Marked as reviewed by vromero (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2724

1 0

RFR: 8252883: AccessDeniedException caused by delayed file deletion on Windows
by Evan Whelan 25 Feb '21

25 Feb '21

Hi, Please review this fix for JDK-8252883. This handles the case when an AccessDeniedException is being thrown on Windows, due to a delay in deleting the lock file it is trying to write to. This fix passes all testing. Kind regards, Evan ------------- Commit messages: - 8252883: AccessDeniedException caused by delayed file deletion on Windows Changes: https://git.openjdk.java.net/jdk/pull/2572/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2572&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252883 Stats: 131 lines in 2 files changed: 124 ins; 5 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2572.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2572/head:pull/2572 PR: https://git.openjdk.java.net/jdk/pull/2572

4 29

RFR: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
by Chris Plummer 25 Feb '21

25 Feb '21

This a new test that runs jstack on a process that is busy doing things. It runs jstack 4 times as the process is starting up. ------------- Commit messages: - Fix @bug - Add JStackStressTest Changes: https://git.openjdk.java.net/jdk/pull/2720/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2720&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262271 Stats: 115 lines in 1 file changed: 115 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2720.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2720/head:pull/2720 PR: https://git.openjdk.java.net/jdk/pull/2720

2 2

RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
by Severin Gehwolf 24 Feb '21

24 Feb '21

This is an enhancement which solves two issues: 1. Multiple reads of relevant cgroup interface files. Now interface files are only read once per file (just like Hotspot). 2. Proxies creation of the impl specific subsystem via `determineType()` as before, but now reads all relevant interface files: `/proc/cgroups`, `/proc/self/mountinfo` and `/proc/self/cgroup`. Once read it passes the parsed information to the impl specific subsystem classes for instantiation. This allows for more flexibility of testing as interface files can be mocked and, thus, more cases can be tested that way without having access to these specific systems. For example, proper regression tests for JDK-8217766 and JDK-8253435 have been added now with this in place. * [x] Tested on Linux x86_64 on cgroups v1 and cgroups v2. Container tests pass. ------------- Commit messages: - 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection Changes: https://git.openjdk.java.net/jdk/pull/1393/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1393&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254001 Stats: 537 lines in 5 files changed: 268 ins; 193 del; 76 mod Patch: https://git.openjdk.java.net/jdk/pull/1393.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1393/head:pull/1393 PR: https://git.openjdk.java.net/jdk/pull/1393

6 26

Withdrawn: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java
by Naoto Sato 24 Feb '21

24 Feb '21

On Sat, 20 Feb 2021 00:44:29 GMT, Naoto Sato <naoto(a)openjdk.org> wrote: > The subject test case is failing under the JMS-enabled environment. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk/pull/2657

1 0

Re: RFR: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java
by Daniel D.Daugherty 24 Feb '21

24 Feb '21

On Sat, 20 Feb 2021 00:44:29 GMT, Naoto Sato <naoto(a)openjdk.org> wrote: > The subject test case is failing under the JMS-enabled environment. Changes requested by dcubed (Reviewer). test/jdk/ProblemList.txt line 799: > 797: # jdk_util > 798: > 799: java/util/Locale/LocaleProvidersRun.java 8261919 generic-all This only needs to be ProblemListed on linux-x64. ------------- PR: https://git.openjdk.java.net/jdk/pull/2657

2 2

RFR: 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null"
by Naoto Sato 24 Feb '21

24 Feb '21

Please review the fix to this test case failure that occurs with the usage tracker enabled JRE. ------------- Commit messages: - 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null" Changes: https://git.openjdk.java.net/jdk/pull/2683/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2683&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261919 Stats: 31 lines in 2 files changed: 17 ins; 7 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/2683.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2683/head:pull/2683 PR: https://git.openjdk.java.net/jdk/pull/2683

3 6