July 2021 - core-libs-dev

[jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved
by Jan Lahoda 08 Jul '21

08 Jul '21

Currently, an enum switch with patterns is desugared in a very non-standard, and potentially slow, way. It would be better to use the standard `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to accept enum constants as labels in order to allow this. A complication is that if an enum constant is missing, that is not an incompatible change for the switch, and the switch should simply work as if the case for the missing constant didn't exist. So, the proposed solution is to have a new bootstrap `enumConstant` that converts the enum constant name to the enum constant, returning `null`, if the constant does not exist. It delegates to `ConstantBootstraps.enumConstant` to do the actual conversion. And `typeSwitch` accepts `null`s as padding. How does this look? ------------- Commit messages: - Adding and fixing test. - Merging master. - 8268766: Desugaring of pattern matching enum switch should be improved Changes: https://git.openjdk.java.net/jdk17/pull/81/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=81&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268766 Stats: 313 lines in 6 files changed: 165 ins; 76 del; 72 mod Patch: https://git.openjdk.java.net/jdk17/pull/81.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/81/head:pull/81 PR: https://git.openjdk.java.net/jdk17/pull/81

5 29

RFR: Merge jdk17
by Jesper Wilhelmsson 08 Jul '21

08 Jul '21

Forwardport JDK 17 -> JDK 18 ------------- Commit messages: - Merge - 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output - 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different - 8269879: [PPC64] C2: Math.rint intrinsic uses wrong rounding mode - 8266036: class file for sun.misc.Contended not found - 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available" - 8268859: jshell throws exception while parsing illegal "case true" - 8269802: javac fails to compile nested pattern matching switches - 8269830: SA's vm object vtable matching code sometimes matches on incorrect type - 8268778: CDS check_excluded_classes needs DumpTimeTable_lock The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4713&range=00.0 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4713&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/4713/files Stats: 1083 lines in 36 files changed: 629 ins; 278 del; 176 mod Patch: https://git.openjdk.java.net/jdk/pull/4713.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4713/head:pull/4713 PR: https://git.openjdk.java.net/jdk/pull/4713

1 2

[jdk17] RFR: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
by Roger Riggs 07 Jul '21

07 Jul '21

The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently with unexpected output from the VM. It appears that destroying the process causes a vm thread to fail to be started. Extend the delay between starting the child and destroying it. Add diagnostics to be specific about which case failed. Incidentally, suppress compiler warnings about SecurityManager use. ------------- Commit messages: - Extend delay before destorying child to allow more vm startup to complete. Changes: https://git.openjdk.java.net/jdk17/pull/228/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=228&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269929 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17/pull/228.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/228/head:pull/228 PR: https://git.openjdk.java.net/jdk17/pull/228

4 4

[jdk17] RFR: 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different
by Alexey Semenyuk 07 Jul '21

07 Jul '21

Disable stripping to prevent rpmbuild from modifying executables ------------- Commit messages: - Disable executables stripping Changes: https://git.openjdk.java.net/jdk17/pull/207/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=207&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269185 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17/pull/207.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/207/head:pull/207 PR: https://git.openjdk.java.net/jdk17/pull/207

4 4

[jdk17] RFR: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
by Daniel Fuchs 07 Jul '21

07 Jul '21

Please find here a trivial fix for: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available" Running several of the websocket tests concurrently on some of the CI machines is causing resource exhaustion, because resources are only freed after the TIMED_WAIT delay has expired once the tests have finished. The proposed solution is to run these tests in exclusive dir mode. ------------- Commit messages: - 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available" Changes: https://git.openjdk.java.net/jdk17/pull/210/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=210&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269772 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/210.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/210/head:pull/210 PR: https://git.openjdk.java.net/jdk17/pull/210

3 3

RFR: 8266407: remove jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES
by Vicente Romero 06 Jul '21

06 Jul '21

Enum constant: jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES was not removed when Sealed Classes were made final because the build was failing without it. Now that the feature is final we should be able to safely removed it. This is the intention of this patch. TIA, Vicente ------------- Commit messages: - 8266407: remove jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES Changes: https://git.openjdk.java.net/jdk/pull/4578/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4578&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266407 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4578.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4578/head:pull/4578 PR: https://git.openjdk.java.net/jdk/pull/4578

2 2

RFR: Merge jdk17
by Jesper Wilhelmsson 06 Jul '21

06 Jul '21

Forwardport JDK 17 -> JDK 18 ------------- Commit messages: - Merge - 8269825: [TESTBUG] Missing testing for x86 KNL platforms - 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86 - 8268966: AArch64: 'bad AD file' in some vector conversion tests - 8225667: Clarify the behavior of System::gc w.r.t. reference processing - 8269568: JVM crashes when running VectorMask query tests - 8269661: JNI_GetStringCritical does not lock char array - 8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372 - 8268883: C2: assert(false) failed: unscheduable graph - 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4698&range=00.0 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4698&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/4698/files Stats: 3666 lines in 51 files changed: 2827 ins; 351 del; 488 mod Patch: https://git.openjdk.java.net/jdk/pull/4698.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4698/head:pull/4698 PR: https://git.openjdk.java.net/jdk/pull/4698

1 2

Withdrawn: 8266013: Unexpected replacement character handling on stateful CharsetEncoder
by duke 06 Jul '21

06 Jul '21

On Tue, 27 Apr 2021 16:49:08 GMT, Ichiroh Takiguchi <itakiguchi(a)openjdk.org> wrote: > When an invalid character is converted by getBytes() method, the character is converted to replacement byte data. > Shift code (SO/SI) may not be added into right place by EBCDIC Mix charset. > EBCDIC Mix charset encoder is stateful encoder. > Shift code should be added by switching character set. > On x-IBM1364, "\u3000\uD800" should be converted to "\x0E\x40\x40\x0F\x6F", but "\x0E\x40\x40\x6F\x0F" > SI is not in right place. > > Also ISO2022 related charsets use escape sequence to switch character set. > But same kind of issue is there. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk/pull/3719

1 0

[jdk17] RFR: JDK-8225667: Clarify the behavior of System::gc w.r.t. reference processing
by Mandy Chung 06 Jul '21

06 Jul '21

This spec clarification is a follow-up to [JDK-8224760](https://bugs.openjdk.java.net/browse/JDK-8224760?focusedCommen… w.r.t. reference processing. Since there is no guarantee for any memory reclamation by the invocation of `System::gc`, the spec should also clarify that there is no guarantee in determining the change of reachability of any objects or any particular number of `Reference` objects be enqueued and cleared. CSR: https://bugs.openjdk.java.net/browse/JDK-8269690 ------------- Commit messages: - JDK-8225667: Clarify the behavior of System::gc w.r.t. reference processing Changes: https://git.openjdk.java.net/jdk17/pull/183/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=183&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8225667 Stats: 9 lines in 2 files changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17/pull/183.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/183/head:pull/183 PR: https://git.openjdk.java.net/jdk17/pull/183

5 12

RFR: 8266310: deadlock while loading the JNI code
by Aleksei Voitylov 06 Jul '21

06 Jul '21

Please review this PR which fixes the deadlock in ClassLoader between the two lock objects - a lock object associated with the class being loaded, and the ClassLoader.loadedLibraryNames hash map, locked during the native library load operation. Problem being fixed: The initial reproducer demonstrated a deadlock between the JarFile/ZipFile and the hash map. That deadlock exists even when the ZipFile/JarFile lock is removed because there's another lock object in the class loader, associated with the name of the class being loaded. Such objects are stored in ClassLoader.parallelLockMap. The deadlock occurs when JNI_OnLoad() loads exactly the same class, whose signature is being verified in another thread. Proposed fix: The proposed patch suggests to get rid of locking loadedLibraryNames hash map and synchronize on each entry name, as it's done with class names in see ClassLoader.getClassLoadingLock(name) method. The patch introduces nativeLibraryLockMap which holds the lock objects for each library name, and the getNativeLibraryLock() private method is used to lazily initialize the corresponding lock object. nativeLibraryContext was changed to ThreadLocal, so that in any concurrent thread it would have a NativeLibrary object on top of the stack, that's being currently loaded/unloaded in that thread. nativeLibraryLockMap accumulates the names of all native libraries loaded - in line with class loading code, it is not explicitly cleared. Testing: jtreg and jck testing with no regressions. A new regression test was developed. ------------- Commit messages: - JDK-8266310: deadlock while loading the JNI code - JDK-8266310: deadlock while loading the JNI code Changes: https://git.openjdk.java.net/jdk/pull/3976/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3976&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266310 Stats: 475 lines in 6 files changed: 456 ins; 0 del; 19 mod Patch: https://git.openjdk.java.net/jdk/pull/3976.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3976/head:pull/3976 PR: https://git.openjdk.java.net/jdk/pull/3976

11 60