July 2021 - core-libs-dev

RFR: 8269124: Update java.time to use switch expressions (part II)
by Patrick Concannon 05 Jul '21

05 Jul '21

Hi, Could someone please review the second half of my update for the `java.time` package to make use of switch expressions? This PR was split into two parts due to the large number of files affected. Kind regards,  Patrick ------------- Commit messages: - 8269124: Update java.time to use switch expressions (part II) Changes: https://git.openjdk.java.net/jdk/pull/4552/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4552&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269124 Stats: 359 lines in 16 files changed: 0 ins; 48 del; 311 mod Patch: https://git.openjdk.java.net/jdk/pull/4552.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4552/head:pull/4552 PR: https://git.openjdk.java.net/jdk/pull/4552

7 26

[jdk17] RFR: 8269281: java/foreign/TestUpcall.java times out
by Maurizio Cimadamore 02 Jul '21

02 Jul '21

The previous fix to this test which used removed the `VerifyDependency` flag worked well, but we're still observing rare timeouts. Looking at the test reports, it seems likely that slightly increasing the timeout would do the trick. ------------- Commit messages: - Increase timeout for TestUpcall Changes: https://git.openjdk.java.net/jdk17/pull/198/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=198&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269281 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/198.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/198/head:pull/198 PR: https://git.openjdk.java.net/jdk17/pull/198

2 3

RFR: Merge jdk17
by Jesper Wilhelmsson 02 Jul '21

02 Jul '21

Forwardport JDK 17 -> JDK 18 ------------- Commit messages: - Merge - 8269768: JFR Terminology Refresh - 8269775: compiler/codegen/ClearArrayTest.java failed with "assert(false) failed: bad AD file" - 8269543: The warning for System::setSecurityManager should only appear once for each caller - 8262017: C2: assert(n != __null) failed: Bad immediate dominator info. - 8269771: assert(tmp == _callprojs.fallthrough_catchproj) failed: allocation control projection - 8265132: C2 compilation fails with assert "missing precedence edge" The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4673&range=00.0 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4673&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/4673/files Stats: 341 lines in 12 files changed: 266 ins; 34 del; 41 mod Patch: https://git.openjdk.java.net/jdk/pull/4673.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4673/head:pull/4673 PR: https://git.openjdk.java.net/jdk/pull/4673

1 1

RFR: 8268664: The documentation of the Scanner.hasNextLine is incorrect
by Ian Graves 02 Jul '21

02 Jul '21

8268664: The documentation of the Scanner.hasNextLine is incorrect ------------- Commit messages: - Clarifying docs on Scanner.hasNextLine() regarding line separators Changes: https://git.openjdk.java.net/jdk/pull/4547/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4547&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268664 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4547.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4547/head:pull/4547 PR: https://git.openjdk.java.net/jdk/pull/4547

4 4

Methods removeFirstIf in Collection and skipFirst in Stream
by Alberto Otero Rodríguez 02 Jul '21

02 Jul '21

Hi, I think it would be interesting adding the following methods: 1) In Collection: default boolean removeFirstIf(Predicate<https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/func…><? super E<https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/Coll…>> filter) 2) In Stream: Stream<https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/stre…><T<https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/stre…>> skipFirst(Predicate<https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/func…><? super T<https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/stre…>> predicate) The purpose of both methods would be the same. Deleting the first element in the collection that fulfills the predicate. This could be useful in collections/streams with no duplicate elements where performance would be better than using removeIf from Collection of filter from Stream. Regards, Alberto.

2 3

RFR: 8188046: java.lang.Math.mutliplyHigh does not run in constant time
by Brian Burkhalter 02 Jul '21

02 Jul '21

Please consider this proposal to remove the fast path in `java.lang.Math.multiplyHigh()` the small performance improvement of which is eclipsed by the branch penalty. ------------- Commit messages: - 8188046: java.lang.Math.mutliplyHigh does not run in constant time Changes: https://git.openjdk.java.net/jdk/pull/4660/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4660&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8188046 Stats: 25 lines in 1 file changed: 0 ins; 11 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/4660.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4660/head:pull/4660 PR: https://git.openjdk.java.net/jdk/pull/4660

3 4

RFR: 8188044: We need Math.unsignedMultiplyHigh
by Brian Burkhalter 02 Jul '21

02 Jul '21

Please consider this proposal to add a method `unsignedMultiplyHigh(long,long)` to each of `java.lang.Math` and `java.lang.StrictMath`. ------------- Commit messages: - 8188044: We need Math.unsignedMultiplyHigh Changes: https://git.openjdk.java.net/jdk/pull/4644/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4644&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8188044 Stats: 72 lines in 3 files changed: 62 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/4644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4644/head:pull/4644 PR: https://git.openjdk.java.net/jdk/pull/4644

9 21

[jdk17] RFR: 8269543: The warning for System::setSecurityManager should only appear once for each caller
by Weijun Wang 02 Jul '21

02 Jul '21

Add a cache to record which source has called `System::setSecurityManager` and only print out warning lines once for each. ------------- Commit messages: - renaming variables, two callers in test - one warning for each caller Changes: https://git.openjdk.java.net/jdk17/pull/166/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=166&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269543 Stats: 47 lines in 2 files changed: 34 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jdk17/pull/166.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/166/head:pull/166 PR: https://git.openjdk.java.net/jdk17/pull/166

8 15

RFR: Merge jdk17
by Jesper Wilhelmsson 02 Jul '21

02 Jul '21

Forwardport JDK 17 -> JDK 18 ------------- Commit messages: - Merge - 8269745: [JVMCI] restore original qualified exports to Graal - 8268566: java/foreign/TestResourceScope.java timed out - 8260684: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java timed out - 8269580: assert(is_valid()) failed: invalid register (-1) - 8269704: Typo in j.t.Normalizer.normalize() - 8269354: javac crashes when processing parenthesized pattern in instanceof - 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998 - 8269088: C2 fails with assert(!n->is_Store() && !n->is_LoadStore()) failed: no node with a side effect - 8269230: C2: main loop in micro benchmark never executed - ... and 3 more: https://git.openjdk.java.net/jdk/compare/de61328d...5515a992 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4661&range=00.0 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4661&range=00.1 Changes: https://git.openjdk.java.net/jdk/pull/4661/files Stats: 996 lines in 26 files changed: 843 ins; 64 del; 89 mod Patch: https://git.openjdk.java.net/jdk/pull/4661.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4661/head:pull/4661 PR: https://git.openjdk.java.net/jdk/pull/4661

1 2

[jdk17] RFR: 8268566: java/foreign/TestResourceScope.java timed out
by Maurizio Cimadamore 01 Jul '21

01 Jul '21

This patch contains another minor tweak to TestResourceScope as we have seen this test timing out at least once (on arm64). I realized that some of the logic recently introduced in the test could lead to the test waiting forever: for instance, if all threads are executed right away before the main thread gets a chance to do anything, we'd be in a state where the lock count is zero, and no other thread will update it. I've removed the while loop - as that's not essential to make sure that the test works (what we want is to trigger a close operation that is concurrent with respect some acquire/release). I've also lowered the number of threads - which was using 10K - that was good for stress testing, but it's not a good number in more realistic conditions. ------------- Commit messages: - * Remove wait from test Changes: https://git.openjdk.java.net/jdk17/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=45&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268566 Stats: 5 lines in 1 file changed: 0 ins; 4 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/45/head:pull/45 PR: https://git.openjdk.java.net/jdk17/pull/45

2 2