July 2023 - hotspot-jfr-dev

[jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC
by David Holmes 31 Jul '23

31 Jul '23

Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources: - src/java.base/share/man/java.1 [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): StartFlightRecording: consider moving mention of multiple comma-separated parameters to the front There are also some formatting differences related to: [JDK-8309670](https://bugs.openjdk.org/browse/JDK-8309670): java -help output for --module-path / -p is incomplete Likely a different version of pandoc was used. - src/java.base/share/man/keytool.1 [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character - src/jdk.compiler/share/man/javac.1 [JDK-8308456](https://bugs.openjdk.org/browse/JDK-8308456): Update javac tool page for -proc:full also some formatting differences. - src/jdk.jartool/share/man/jarsigner.1 [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410) - src/jdk.jcmd/share/man/jcmd.1 [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion - src/jdk.jdeps/share/man/jdeps.1 [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option - src/jdk.jfr/share/man/jfr.1 Formatting changes. - src/jdk.jshell/share/man/jshell.1 [JDK-8308988](https://bugs.openjdk.org/browse/JDK-8308988): Update JShell manpage to include TOOLING description ------------- Commit messages: - 8300937: Update nroff pages in JDK 21 before RC Changes: https://git.openjdk.org/jdk21/pull/151/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=151&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300937 Stats: 163 lines in 28 files changed: 37 ins; 60 del; 66 mod Patch: https://git.openjdk.org/jdk21/pull/151.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/151/head:pull/151 PR: https://git.openjdk.org/jdk21/pull/151

5 6

Re: RFR: JDK-8313251: Add NativeLibraryLoad event [v2]
by David Holmes 30 Jul '23

30 Jul '23

On Fri, 28 Jul 2023 09:38:13 GMT, Matthias Baesken <mbaesken(a)openjdk.org> wrote: >> Add a NativeLibraryLoad event that provides us more detail about shared lib/dll loads. This gives a time stamp and success + error details of the load operation. It enhances the already existing information we get from the existing NativeLibrary event (that periodically samples the native modules of the jvm process). > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > add macro guards because the build errors in zero build test/jdk/jdk/jfr/event/runtime/TestNativeLibraryLoadEvent.java line 2: > 1: /* > 2: * Copyright (c) 2013, 2023, Oracle and/or its affiliates. All rights reserved. New test should have single copyright year, even if copied from existing test. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15065#discussion_r1278631089

1 0

Re: RFR: 8313141: Missing check for os_thread type in os_windows.cpp
by David Holmes 29 Jul '23

29 Jul '23

On Sat, 29 Jul 2023 05:13:24 GMT, Julian Waters <jwaters(a)openjdk.org> wrote: > os::os_thread is not handled in os_windows.cpp, and therefore ignores the thread stack size option. I am unsure if this is the right way to handle os::os_thread, please let me know if it is not Bringing in the JFR folk as this is their thread Take 2: Bringing in the JFR folk as this is their thread ------------- PR Comment: https://git.openjdk.org/jdk/pull/15079#issuecomment-1656566605 PR Comment: https://git.openjdk.org/jdk/pull/15079#issuecomment-1656566790

1 0

RFR: JDK-8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout
by Matthias Baesken 28 Jul '23

28 Jul '23

Looks like the current timeout values of jdk/jdk/jfr/jvm/TestChunkIntegrity.java - test are not sufficient for some of our test machines. ------------- Commit messages: - JDK-8312574 Changes: https://git.openjdk.org/jdk/pull/15067/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15067&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312574 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/15067.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15067/head:pull/15067 PR: https://git.openjdk.org/jdk/pull/15067

2 3

[jdk21] RFR: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
by Markus Grönlund 27 Jul '23

27 Jul '23

8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086 ------------- Commit messages: - Backport 59f66a3b839c5b77c2770fa0bdd76f399d2d86d6 Changes: https://git.openjdk.org/jdk21/pull/147/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=147&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312293 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21/pull/147.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/147/head:pull/147 PR: https://git.openjdk.org/jdk21/pull/147

2 2

RFR: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
by Erik Gahlin 26 Jul '23

26 Jul '23

Could I have a review of a test fix? The test creates a ChainNode object and adds 100 byte arrays to it. Then a long linked list of ChainNodes are created so the byte arrays are at the end. The test then tries to verify that there are at least one old object sample of type byte[] and that the reference chain back to the GC root is not too long. Problem is, there is no old object samples of type byte[], only those of type jdk.jfr.event.oldobject.TestHeapDeep$ChainNode. Fix is to loop until we found a sample and then verify the chain. Testing: 100 * test/jdk/jdk/jfr/event/oldobject/TestHeapDeap.java Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/15026/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15026&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312526 Stats: 15 lines in 1 file changed: 3 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/15026.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15026/head:pull/15026 PR: https://git.openjdk.org/jdk/pull/15026

2 2

RFR: 8312533: JFR: No message for JFR.view when data is missing
by Erik Gahlin 25 Jul '23

25 Jul '23

Could I have a review of a PR that adds a message when there is no data to view. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14998/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14998&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312533 Stats: 80 lines in 2 files changed: 77 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/14998.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14998/head:pull/14998 PR: https://git.openjdk.org/jdk/pull/14998

2 2

RFR: 8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134"
by Erik Gahlin 24 Jul '23

24 Jul '23

Could I have a review of fix that prevents the ChunkParser from locking up when an end time has been set. The problem was likely introduced with https://bugs.openjdk.org/browse/JDK-8307738 where the condition for exiting the the while loop in ChunkParser::processRecursionSafe(...) was changed. What happens is that the awaitUpdatedHeader(...) method will return true when the end time exceeds the timestamp of the last segment. This leads to chunkFinished to be set to true and the loop in ChunkParser::processRecursionSafe(...) continues to next file, but there is no file so it spins forever in RepositoryFiles::updatePaths(...) The fix is to allow the loop to exit when absoluteChunkEnd != chunkHeader.getEnd(), which will transfer control back to ChunkParser::processRecursionSafe(...) with chunkFinished set to false, where the method can return when the last segment has been fully parsed. Just changing the return value from "true" to "false" would be incorrect. The stream should end when all the events leading up to the end time has been parsed, not just written. Testing: 100 * test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14987/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14987&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309238 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/14987.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14987/head:pull/14987 PR: https://git.openjdk.org/jdk/pull/14987

2 2

RFR: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
by Markus Grönlund 21 Jul '23

21 Jul '23

Greetings, please help review this fix. The problem description and fix are described in detail in the JIRA issue. Testing: jdk_jfr, microbenchmarks Thanks Markus ------------- Commit messages: - 8312293 Changes: https://git.openjdk.org/jdk/pull/14962/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14962&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312293 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/14962.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14962/head:pull/14962 PR: https://git.openjdk.org/jdk/pull/14962

2 2

RFR: 8312474: JFR: Improve logging to diagnose event stream timeout
by Erik Gahlin 21 Jul '23

21 Jul '23

Could I have review of a PR that adds logging to diagnose a test timeout. It also fixes a bug where the test didn't wait for the Old Collection event to arrive. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14960/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14960&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312474 Stats: 17 lines in 3 files changed: 15 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/14960.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14960/head:pull/14960 PR: https://git.openjdk.org/jdk/pull/14960

2 2