July 2023 - hotspot-jfr-dev

Re: RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v8]
by Markus Grönlund 13 Jul '23

13 Jul '23

> Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: build x86_32 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14761/files - new: https://git.openjdk.org/jdk/pull/14761/files/08210ac9..97854c2e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=06-07 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/14761.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14761/head:pull/14761 PR: https://git.openjdk.org/jdk/pull/14761

3 3

[jdk21] RFR: 8294401: Update jfr man page to include recently added features
by Erik Gahlin 13 Jul '23

13 Jul '23

8294401: Update jfr man page to include recently added features ------------- Commit messages: - Backport f60c1f9bc4355f3abf428f9a0f7a65eace5598d0 Changes: https://git.openjdk.org/jdk21/pull/122/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=122&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294401 Stats: 193 lines in 1 file changed: 169 ins; 8 del; 16 mod Patch: https://git.openjdk.org/jdk21/pull/122.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/122/head:pull/122 PR: https://git.openjdk.org/jdk21/pull/122

2 2

RFR: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
by Markus Grönlund 13 Jul '23

13 Jul '23

Greetings, Please help review this correction to an invalid lock acquisition when JFR is configured for not writing to disk. Problem analysis is in the JIRA issue. Testing: jdk_jfr, microbenchmarks Thanks Markus ------------- Commit messages: - 8244289 Changes: https://git.openjdk.org/jdk/pull/14828/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14828&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8244289 Stats: 14 lines in 3 files changed: 2 ins; 3 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/14828.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14828/head:pull/14828 PR: https://git.openjdk.org/jdk/pull/14828

2 2

[jdk21] RFR: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
by Markus Grönlund 13 Jul '23

13 Jul '23

8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration ------------- Commit messages: - Backport 6895debf66debd2d9df066b228e24eba0fc7a2a6 Changes: https://git.openjdk.org/jdk21/pull/121/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=121&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311536 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21/pull/121.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/121/head:pull/121 PR: https://git.openjdk.org/jdk21/pull/121

2 2

RFR: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
by Markus Grönlund 13 Jul '23

13 Jul '23

Greetings, the test is not designed to support large pages and should disallow it if someone requests it from the outside. Testing: the test passing -XX:+UseLargePages using --jvm-prepend-args Thanks Markus ------------- Commit messages: - 8311536 Changes: https://git.openjdk.org/jdk/pull/14853/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14853&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311536 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/14853.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14853/head:pull/14853 PR: https://git.openjdk.org/jdk/pull/14853

3 3

RFR: 8294401: Update jfr man page to include recently added features
by Erik Gahlin 13 Jul '23

13 Jul '23

Could I have a review of changes to the jfr manage. Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14850/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14850&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294401 Stats: 193 lines in 1 file changed: 169 ins; 8 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/14850.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14850/head:pull/14850 PR: https://git.openjdk.org/jdk/pull/14850

2 2

Re: RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v7]
by Markus Grönlund 11 Jul '23

11 Jul '23

> Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: include for ByteSize ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14761/files - new: https://git.openjdk.org/jdk/pull/14761/files/be1d0da1..08210ac9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=05-06 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/14761.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14761/head:pull/14761 PR: https://git.openjdk.org/jdk/pull/14761

1 0

Re: RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v6]
by Markus Grönlund 11 Jul '23

11 Jul '23

> Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: debug aid removals ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14761/files - new: https://git.openjdk.org/jdk/pull/14761/files/635d05e8..be1d0da1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=04-05 Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/14761.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14761/head:pull/14761 PR: https://git.openjdk.org/jdk/pull/14761

1 0

[jdk21] RFR: 8311245: JFR: Remove t.printStackTrace() in PeriodicEvents
by Erik Gahlin 11 Jul '23

11 Jul '23

8311245: JFR: Remove t.printStackTrace() in PeriodicEvents ------------- Commit messages: - Backport a1cfc9695405fe517fae1b9f760ae42b85f66be9 Changes: https://git.openjdk.org/jdk21/pull/110/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311245 Stats: 10 lines in 1 file changed: 0 ins; 8 del; 2 mod Patch: https://git.openjdk.org/jdk21/pull/110.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/110/head:pull/110 PR: https://git.openjdk.org/jdk21/pull/110

2 2

Re: RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v5]
by Markus Grönlund 11 Jul '23

11 Jul '23

> Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: only transient promotion buffers for disk configurations ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14761/files - new: https://git.openjdk.org/jdk/pull/14761/files/76b27a4d..635d05e8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/14761.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14761/head:pull/14761 PR: https://git.openjdk.org/jdk/pull/14761

1 0