July 2023 - hotspot-jfr-dev

[jdk21] RFR: 8311040: JFR: RecordedThread::getOSThreadId() should return -1 if thread is virtual
by Markus Grönlund 18 Jul '23

18 Jul '23

8311040: JFR: RecordedThread::getOSThreadId() should return -1 if thread is virtual ------------- Commit messages: - Backport 9905f7582270634eb19f7d9cb67210a174da9a85 Changes: https://git.openjdk.org/jdk21/pull/135/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=135&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311040 Stats: 65 lines in 6 files changed: 23 ins; 9 del; 33 mod Patch: https://git.openjdk.org/jdk21/pull/135.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/135/head:pull/135 PR: https://git.openjdk.org/jdk21/pull/135

2 2

RFR: 8311040: JFR: RecordedThread::getOSThreadId() should return -1 if thread is virtual
by Markus Grönlund 18 Jul '23

18 Jul '23

Greetings, The following fix takes care of returning the correct thread values specified by the API. If the thread is virtual, we return null and -1 for the OSThread name and id, respectively. Thanks Markus ------------- Commit messages: - 8311040 Changes: https://git.openjdk.org/jdk/pull/14920/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14920&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311040 Stats: 65 lines in 6 files changed: 23 ins; 9 del; 33 mod Patch: https://git.openjdk.org/jdk/pull/14920.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14920/head:pull/14920 PR: https://git.openjdk.org/jdk/pull/14920

2 2

[jdk21] RFR: 8307526: [JFR] Better handling of tampered JFR repository
by Joakim Nordström 18 Jul '23

18 Jul '23

Almost clean backport. Only real diff due to changes to JVM class: * `jvm.shouldRotateDisk()` instead of mainline's static `JVM.shouldRotateDisk()` ------------- Commit messages: - Backport 66d2736521611fbe7652356894d046c17d7cf743 Changes: https://git.openjdk.org/jdk21/pull/131/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=131&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307526 Stats: 144 lines in 8 files changed: 102 ins; 8 del; 34 mod Patch: https://git.openjdk.org/jdk21/pull/131.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/131/head:pull/131 PR: https://git.openjdk.org/jdk21/pull/131

2 3

[jdk21] Integrated: 8303134: JFR: Missing stack trace during chunk rotation stress
by Markus Grönlund 14 Jul '23

14 Jul '23

On Fri, 14 Jul 2023 11:38:32 GMT, Markus Grönlund <mgronlun(a)openjdk.org> wrote: > Backport. This pull request has now been integrated. Changeset: c199b8c7 Author: Markus Grönlund <mgronlun(a)openjdk.org> URL: https://git.openjdk.org/jdk21/commit/c199b8c761c14542953a01c1efd6ccec951792… Stats: 839 lines in 36 files changed: 700 ins; 76 del; 63 mod 8303134: JFR: Missing stack trace during chunk rotation stress Reviewed-by: egahlin Backport-of: 7539cc092d0a6b5604351d19e555101fcff75f58 ------------- PR: https://git.openjdk.org/jdk21/pull/129

1 0

Re: [jdk21] RFR: 8303134: JFR: Missing stack trace during chunk rotation stress
by Erik Gahlin 14 Jul '23

14 Jul '23

On Fri, 14 Jul 2023 11:38:32 GMT, Markus Grönlund <mgronlun(a)openjdk.org> wrote: > Backport. Marked as reviewed by egahlin (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21/pull/129#pullrequestreview-1530228022

1 0

[jdk21] RFR: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
by Markus Grönlund 14 Jul '23

14 Jul '23

8244289: fatal error: Possible safepoint reached by thread that does not allow it ------------- Commit messages: - Backport 61932f49a58b73530e89e511874fbe2fbc343e99 Changes: https://git.openjdk.org/jdk21/pull/124/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=124&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8244289 Stats: 14 lines in 3 files changed: 2 ins; 3 del; 9 mod Patch: https://git.openjdk.org/jdk21/pull/124.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/124/head:pull/124 PR: https://git.openjdk.org/jdk21/pull/124

2 2

Integrated: 8303134: JFR: Missing stack trace during chunk rotation stress
by Markus Grönlund 14 Jul '23

14 Jul '23

On Mon, 3 Jul 2023 18:33:30 GMT, Markus Grönlund <mgronlun(a)openjdk.org> wrote: > Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus This pull request has now been integrated. Changeset: 7539cc09 Author: Markus Grönlund <mgronlun(a)openjdk.org> URL: https://git.openjdk.org/jdk/commit/7539cc092d0a6b5604351d19e555101fcff75f58 Stats: 835 lines in 36 files changed: 698 ins; 76 del; 61 mod 8303134: JFR: Missing stack trace during chunk rotation stress Reviewed-by: egahlin, thartmann ------------- PR: https://git.openjdk.org/jdk/pull/14761

1 0

Re: RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v9]
by Markus Grönlund 14 Jul '23

14 Jul '23

> Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: remove space Co-authored-by: Tobias Hartmann <tobias.hartmann(a)oracle.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14761/files - new: https://git.openjdk.org/jdk/pull/14761/files/97854c2e..fe248010 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=07-08 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/14761.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14761/head:pull/14761 PR: https://git.openjdk.org/jdk/pull/14761

1 1

Re: RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v10]
by Markus Grönlund 14 Jul '23

14 Jul '23

> Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: Apply suggestions from code review if instead of ifdef ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14761/files - new: https://git.openjdk.org/jdk/pull/14761/files/fe248010..2fc39b77 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=09 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=08-09 Stats: 5 lines in 5 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/14761.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14761/head:pull/14761 PR: https://git.openjdk.org/jdk/pull/14761

1 0

Re: RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v4]
by Markus Grönlund 13 Jul '23

13 Jul '23

> Greetings, > > please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue. > > Testing: jdk_jfr, stress testing. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: commentary ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14761/files - new: https://git.openjdk.org/jdk/pull/14761/files/07428b28..76b27a4d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14761&range=02-03 Stats: 16 lines in 2 files changed: 11 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/14761.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14761/head:pull/14761 PR: https://git.openjdk.org/jdk/pull/14761

2 2