- ppc-aix-port-dev - openjdk.org

RFR: 8230873 [AIX] GUI app does work with UTF-8 locale on minimum software requirements
by Ichiroh Takiguchi 30 Oct '19

30 Oct '19

Hello. Could you review the fix ? Bug: https://bugs.openjdk.java.net/browse/JDK-8230873 Change: https://cr.openjdk.java.net/~itakiguchi/8230873/webrev.00/ GUI application does not work with AIX's JA_JP UTF-8 locale on minimum software requirements and settings because of following exception: Exception in thread "AWT-EventQueue-0" java.lang.ClassCastException: class sun.font.CompositeFont cannot be cast to class sun.font.PhysicalFont (sun.font.CompositeFont and sun.font.PhysicalFont are in module java.desktop of loader 'bootstrap') About the reasons for this exception: 1. Default physical font is not defined (like Lucida sans) 2. XLFD charset name entries for JA_JP locale have Underscore character (Underscore character replaces with Space character on fontconfig.proeprties (fontconfig.bfs) file loading phase.) About "1", I'd like to handle it by JDK-8221741 [1]. About "2", OpenJDK for AIX is using fontconfig.properties (fontconfig.bfc) file to find out TrueType fonts. On AIX JCK UTF-8 locales, Java cannot find out TrueType font because above XLFD charset name issue. This fix only changes fontconfig.properties for AIX platform * make/data/fontconfig/aix.fontconfig.properties [1] https://bugs.openjdk.java.net/browse/JDK-8230873 Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

2 5

xlc16 for jdk11 AIX build
by Baesken, Matthias 30 Oct '19

30 Oct '19

Hello, we recently moved the jdk/jdk AIX-build to xlc16 (new-style xlclang) . See for instance change : 8224214: [AIX] Remove support for legacy xlc compiler that removed the support for older xlc compilers. We at SAP currently think about moving the jdk11 AIX - build to xlc16 . There are two options when building with xlc16 : 1. using the xlc16 legacy (non-clang) compiler . This works already , and is probably more compatible for people using e.g. xlc12 / xlc13 ; 1. using xlc16/xlclang This would need the downporting of more changes to 11 and is probably less (not?) compatible for people still using older xlc versions . What is your opinion ? What are the xlc versions people use currently for building jdk11 on AIX ? Best regards, Matthias

2 2

RFR: 8231649: PPC64: Intrinsics for Math.ceil, floor, rint on Power
by Michihiro Horie 23 Oct '19

23 Oct '19

Dear all, Would you please review the following change? Bug: https://bugs.openjdk.java.net/browse/JDK-8231649 Webrev: http://cr.openjdk.java.net/~mhorie/8231649/webrev.00 This change adds intrinsics for Math's ceil, floor, and rint for PPC64, on top of 8226721: Missing intrinsics for Math.ceil, floor, rint. Best regards, Michihiro

3 26

pthread_setname_np (replacement) on AIX ?
by Baesken, Matthias 10 Oct '19

10 Oct '19

Hello, currently pthread_setname_np is used on e.g. Linux and BSD https://hg.openjdk.java.net/jdk/jdk/file/ccb7bf459cbd/src/hotspot/os/linux/… https://hg.openjdk.java.net/jdk/jdk/file/ccb7bf459cbd/src/hotspot/os/bsd/os… for setting unique names for a threads. See the Linux manpage : https://linux.die.net/man/3/pthread_setname_np I noticed that the function seems to be available now on IBM i https://www.ibm.com/support/knowledgecenter/en/ssw_ibm_i_72/apis/pthread_se… but I did not find it on AIX - are there plans to include it on AIX ? Or is it already available in some SP ? If not is there a replacmenet function for it we could use ? Thanks, Matthias

2 2

RFR : 8231753: use more Posix functionality in aix os::print_os_info
by Baesken, Matthias 08 Oct '19

08 Oct '19

Hello, please review the following small (mostly AIX related) change . It replaces the AIX coding in function void os::print_os_info(outputStream* st) { ... } for uname and load average info output by os::Posix functionality. Additionally it slightly changes os::Posix::print_load_average function to handle the return value of os::loadavg ( indicating failure ) . Bug / webrev : https://bugs.openjdk.java.net/browse/JDK-8231753 http://cr.openjdk.java.net/~mbaesken/webrevs/8231753.0/ Thanks, Matthias

3 3

RFR: 8231751: on aix handle Power 9 in os::get_summary_cpu_info
by Baesken, Matthias 07 Oct '19

07 Oct '19

Hello, please review this small change . It adds Power 9 handling to os::get_summary_cpu_info on AIX . Additionally some older macro definitions (like PV_6 ) are removed because they are present in sys/systemcfg.h on recent AIX versions ( 6.1 + ) . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8231751 http://cr.openjdk.java.net/~mbaesken/webrevs/8231751.0/ Thanks, Matthias

3 2

RFR: 8228482: fix xlc16/xlclang comparison of distinct pointer types and string literal conversion warnings
by Baesken, Matthias 17 Sep '19

17 Sep '19

Hello please review this patch . It fixes a couple of xlc16/xlclang warnings , especially comparison of distinct pointer types and string literal conversion warnings . When building with xlc16/xlclang, we still have a couple of warnings that have to be fixed : warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] for example : /nightly/jdk/src/hotspot/os/aix/libodm_aix.cpp:81:18: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] odmWrapper odm("product", "/usr/lib/objrepos"); // could also use "lpp" ^ /nightly/jdk/src/hotspot/os/aix/libodm_aix.cpp:81:29: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] odmWrapper odm("product", "/usr/lib/objrepos"); // could also use "lpp" ^ warning: comparison of distinct pointer types, for example : /nightly/jdk/src/java.desktop/aix/native/libawt/porting_aix.c:50:14: warning: comparison of distinct pointer types ('void *' and 'char *') [-Wcompare-distinct-pointer-types] addr < (((char*)p->ldinfo_textorg) + p->ldinfo_textsize)) { ~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8228482 http://cr.openjdk.java.net/~mbaesken/webrevs/8228482.1/ Thanks, Matthias

3 3

Memory fences in the JNI invocation on Power
by Michihiro Horie 10 Sep '19

10 Sep '19

Hi all, This is not a RFR. I have a client case in which a Java application invokes JNI methods heavily on Power. Fixing Java code is not allowed, so I’m wondering if there is any way to enlighten the JNI invocation by replacing memory fences such as the following diff on Power. I may miss the design around the diff, but I’m not sure if WR order needs to be protected. http://cr.openjdk.java.net/~mhorie/webrev_jni/ (I should fix code under the given abstractions, but wanted to share a fix on Power in the first place.) Best regards, Michihiro

2 2

RFR: 8224214: [AIX] Remove support for legacy xlc compiler
by Baesken, Matthias 30 Aug '19

30 Aug '19

Hello, please review the following change . For OpenJDK 13 we've moved to XLC 16 as required compiler. However we have still a lot of workarounds and checks in the codebase for the older xlc compilers. This changes removes such changes . Additionally it adjusts the compiler version check in hotspot/share/utilities/globalDefinitions_xlc.hpp and 2 typos in os_aix are fixed . When 8224214 was created a while ago , it was discussed on the mailing list : "we still set some '-qlanglvl' options for C++ which aren't supported by the new compiler [xlc16/xlclang++] either" . Those options generated lots of warnings , so they were removed already so no need to remove them in this change . ( In jdk11 which is built with xlc12 they can still be found : flags-cflags.m4:540: -qalias=noansi -qstrict -qtls=default -qlanglvl=c99vla \ flags-cflags.m4:541: -qlanglvl=noredefmac -qnortti -qnoeh -qignerrno" ) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8224214 http://cr.openjdk.java.net/~mbaesken/webrevs/8224214.0/ Thanks, Matthias

5 9

RFR: 8228426: xlc: switch to clang-style warning disabling
by Baesken, Matthias 22 Jul '19

22 Jul '19

Please review the following change that switches to clang-style warning disabling on AIX, and adjusts the warning disabling to current needs . Recently the jdk/jdk build on AIX switched to xlc16/xlclang. This means we can now use the standard clang-style warning disabling (the old legacy qsuppress warning disablings from legacy xlc might not fully work any more). I think we are pretty close in reducing the compiler warnings to 0 on AIX, which would make it possible to build with warnings as errors at some point in the future . In a first step I would disable these warnings in HS for xlc16/xlclang : tautological-compare : (seen in os_aix.cpp) /jdk/src/hotspot/os/aix/os_aix.cpp:2400:15: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] if (bytes >= Use64KPagesThreshold) { ~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~ /jdk/src/hotspot/os/aix/os_aix.cpp:2607:15: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] if (bytes >= Use64KPagesThreshold) { In the product build the "Use64KPagesThreshold" is a constant so clang complains . However in the (fast)debug builds one can set Use64KPagesThreshold with an -XX setting. So I think it is best to disable the warning. shift-negative-value : (seen in c1_LIRGenerator_ppc.cpp) /jdk/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp:429:97: warning: shifting a negative signed value is undefined [-Wshift-negative-value] (x->op() == Bytecodes::_lsub && right.value()->type()->as_LongConstant()->value() == ((-1)<<15)) ) { ~~~~^ /jdk/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp:483:96: warning: shifting a negative signed value is undefined [-Wshift-negative-value] (x->op() == Bytecodes::_isub && right.value()->type()->as_IntConstant()->value() == ((-1)<<15)) ) { We could probably replace the -1 shift by a constant but I think it is nicely readable . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8228426 http://cr.openjdk.java.net/~mbaesken/webrevs/8228426.0/ Thanks, Matthias

3 4