- ppc-aix-port-dev - openjdk.org

RFR: 8221741 [AIX] Unexpected X11 bitmap fonts are loaded because of fontconfig.properties
by Ichiroh Takiguchi 24 Jun '19

24 Jun '19

Hello. (I am sorry to post it again. Previously, I posted the wrong mailing list.) Could you review the fix ? Bug: https://bugs.openjdk.java.net/browse/JDK-8221741 Change: https://cr.openjdk.java.net/~itakiguchi/8221741/webrev.00/ I'd like to obtain a sponsor for this issue. On AIX platform, fontconfig.properties file is used to pick up proper fonts. TrueType font settings are written by XLFD format on fontconfig.properties file. On current implementation, Java tries to load X11 bitmap fonts even if these are not used. This font load work is almost name as "xlsfonts -ll". It spends many CPU time and memories. Just font name format should be supported. To SAP representative, I have a question about copyright year on make/data/fontconfig/aix.fontconfig.properties. Please let me know how I should write down copyright year. Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

3 12

Re: RFR: 8224090: [PPC64] Fix SLP patterns for filling an array with double float literals
by Kazunori Ogata 03 Jun '19

03 Jun '19

Hi Volker and Martin, Is the updated webrev good? Regards, Ogata Kazunori Ogata/Japan/IBM wrote on 2019/05/29 14:16:12: > From: Kazunori Ogata/Japan/IBM > To: "hotspot-compiler-dev(a)openjdk.java.net" <hotspot-compiler- > dev(a)openjdk.java.net>, "ppc-aix-port-dev(a)openjdk.java.net" <ppc-aix-port- > dev(a)openjdk.java.net>, Volker Simonis <volker.simonis(a)gmail.com>, "Doerr, > Martin" <martin.doerr(a)sap.com> > Date: 2019/05/29 14:16 > Subject: Re: RFR: 8224090: [PPC64] Fix SLP patterns for filling an array > with double float literals > > Hi Volker and Martin, > > Thank you for your comment. I updated the webrev. > > http://cr.openjdk.java.net/~horii/8224090/webrev.01/ > > Regards, > Ogata > > "Doerr, Martin" <martin.doerr(a)sap.com> wrote on 2019/05/28 23:04:15: > > > From: "Doerr, Martin" <martin.doerr(a)sap.com> > > To: Volker Simonis <volker.simonis(a)gmail.com>, Kazunori Ogata <OGATAK(a)jp.ibm.com> > > Cc: "hotspot-compiler-dev(a)openjdk.java.net" <hotspot-compiler- > > dev(a)openjdk.java.net>, "ppc-aix-port-dev(a)openjdk.java.net" <ppc-aix-port- > > dev(a)openjdk.java.net> > > Date: 2019/05/28 23:08 > > Subject: RE: RFR: 8224090: [PPC64] Fix SLP patterns for filling > > an array with double float literals > > > > Right, this needs to get changed. > > > > Best regards, > > Martin > > > > > -----Original Message----- > > > From: Volker Simonis <volker.simonis(a)gmail.com> > > > Sent: Dienstag, 28. Mai 2019 15:04 > > > To: Kazunori Ogata <OGATAK(a)jp.ibm.com> > > > Cc: Doerr, Martin <martin.doerr(a)sap.com>; hotspot-compiler- > > > dev(a)openjdk.java.net; ppc-aix-port-dev(a)openjdk.java.net > > > Subject: Re: RFR: 8224090: [PPC64] Fix SLP patterns for filling an array with > > > double float literals > > > > > > Hi Ogata, > > > > > > you change looks good, but you should use "jlong_cast()" in the > > > "immD_0()" operand. > > > > > > Thank you and best regards, > > > Volker > > > > > > > > > On Tue, May 28, 2019 at 12:26 PM Kazunori Ogata <OGATAK(a)jp.ibm.com> > > > wrote: > > > > > > > > Hi Martin, > > > > > > > > Thank you for your review. > > > > > > > > Regards, > > > > Ogata > > > > > > > > "Doerr, Martin" <martin.doerr(a)sap.com> wrote on 2019/05/28 18:21:29: > > > > > > > > > From: "Doerr, Martin" <martin.doerr(a)sap.com> > > > > > To: Kazunori Ogata <OGATAK(a)jp.ibm.com>, "hotspot-compiler- > > > > > dev(a)openjdk.java.net" <hotspot-compiler-dev(a)openjdk.java.net>, > > > "ppc-aix- > > > > > port-dev(a)openjdk.java.net" <ppc-aix-port-dev(a)openjdk.java.net> > > > > > Date: 2019/05/28 18:21 > > > > > Subject: [EXTERNAL] RE: RFR: 8224090: [PPC64] Fix SLP patterns for > > > > filling > > > > > an array with double float literals > > > > > > > > > > Hi Ogata, > > > > > > > > > > looks good. Thanks for fixing. > > > > > > > > > > Best regards, > > > > > Martin > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: hotspot-compiler-dev <hotspot-compiler-dev- > > > > > > bounces(a)openjdk.java.net> On Behalf Of Kazunori Ogata > > > > > > Sent: Freitag, 17. Mai 2019 07:34 > > > > > > To: hotspot-compiler-dev(a)openjdk.java.net; ppc-aix-port- > > > > > > dev(a)openjdk.java.net > > > > > > Subject: RFR: 8224090: [PPC64] Fix SLP patterns for filling an array > > > > with double > > > > > > float literals > > > > > > > > > > > > Hi, > > > > > > > > > > > > May I get review for a webrev to fix SLP patterns that use PPC64 VSX > > > > > > instructions? > > > > > > > > > > > > We found that SLP patterns added by JDK-8208171 [1] use incorrect > > > data > > > > > > type, so the patterns have never been used. Further, the pattern for > > > > > > filling -1.0 is confused with the operation for filling -1L. > > > > > > > > > > > > This webrev fixes the pattern to fill an array with 0 to use 0.0d > > > > instead > > > > > > of 0d, and removes the pattern to will with -1 because the bit pattern > > > > of > > > > > > -1.0d is not easy to generate using a single VSX instruction. It's > > > > should > > > > > > be better to load the literal from TOC and use general repl2D_reg_Ex > > > > > > pattern. > > > > > > > > > > > > I also fixed some comments in "format %{ ... %}" to show correct > > > > matching > > > > > > types. > > > > > > > > > > > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8224090 > > > > > > > > > > > > Webrev: http://cr.openjdk.java.net/~horii/8224090/webrev.00/ > > > > > > > > > > > > Ref: > > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8208171 > > > > > > > > > > > > > > > > > > Regards, > > > > > > Ogata > > > > > > > > > > > > > > > > > > > >

2 2

RFR: 8224090: [PPC64] Fix SLP patterns for filling an array with double float literals
by Kazunori Ogata 29 May '19

29 May '19

Hi, May I get review for a webrev to fix SLP patterns that use PPC64 VSX instructions? We found that SLP patterns added by JDK-8208171 [1] use incorrect data type, so the patterns have never been used. Further, the pattern for filling -1.0 is confused with the operation for filling -1L. This webrev fixes the pattern to fill an array with 0 to use 0.0d instead of 0d, and removes the pattern to will with -1 because the bit pattern of -1.0d is not easy to generate using a single VSX instruction. It's should be better to load the literal from TOC and use general repl2D_reg_Ex pattern. I also fixed some comments in "format %{ ... %}" to show correct matching types. Bug: https://bugs.openjdk.java.net/browse/JDK-8224090 Webrev: http://cr.openjdk.java.net/~horii/8224090/webrev.00/ Ref: [1] https://bugs.openjdk.java.net/browse/JDK-8208171 Regards, Ogata

3 6

RFR [XS] : 8223685: used bundled zlib on AIX by default
by Baesken, Matthias 10 May '19

10 May '19

Hello, please review this small AIX - specific change . Currently we use by default the bundled zlib (= zlib coming with OpenJDK) on Windows, on other platforms the system zlib. However it is possible to switch to the bundled zlib in the configure process . We had some build issues on AIX build systems with ancient system-zlibs , so I propose to use as default the bundled zlib on AIX too . (would also mean that we use a current 1.2.11 in the build on AIX which is not bad, on some AIX machines I've seen older zlibs) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8223685 http://cr.openjdk.java.net/~mbaesken/webrevs/8223685.0/webrev/ Thanks, Matthias

3 2

RE: FW: RFR: 8223307: enable the Stack Execution Disable flag for JDK binaries on AIX - was : AIX : -bnorwexec linker flag
by Doerr, Martin 09 May '19

09 May '19

Hi Matthias, the change looks good to me. According to an old redbook [1], this flag makes stacks and r/w sections of the lib non-executable. This makes sense. Best regards, Martin [1] AIX 5L Differences Guide Version 5.3 Edition -----Original Message----- From: Erik Joelsson <erik.joelsson(a)oracle.com<mailto:erik.joelsson@oracle.com>> Sent: Freitag, 3. Mai 2019 15:32 To: Baesken, Matthias <matthias.baesken(a)sap.com<mailto:matthias.baesken@sap.com>>; ppc-aix-port-dev(a)openjdk.java.net<mailto:ppc-aix-port-dev@openjdk.java.net>; 'build-dev(a)openjdk.java.net' <build-dev(a)openjdk.java.net<mailto:build-dev@openjdk.java.net>> Subject: Re: RFR: 8223307: enable the Stack Execution Disable flag for JDK binaries on AIX - was : AIX : -bnorwexec linker flag Change looks good from a build perspective. I can't comment on the validity of the flag itself for a platform I don't know. /Erik On 2019-05-03 05:48, Baesken, Matthias wrote: > Hello, I created a webrev for the previously discussed issue (AIX : -bnorwexec linker flag). > > AIX supports a binary hardening option called SED, see : > > https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.secur… > > System wide configuration can be done with the sedmgr tool : > > https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm.aix.cmds5… > > > The system-wide configuration supports various modes, very often "select" mode is configured where > binaries can opt-in to use SED : > > "select: > Only a select set of files are enabled and monitored for SED protection. The select set of files are chosen by reviewing the SED related flags in the executable program binary headers. > The executable program header enables SED related flags to request to be included in the select mode." > > > We can set a linker option on AIX to configure "select" mode for the JDK binaries; our tests show that this does not "kill" the JIT (jitted code). > > changed binary shows then the opt-in flag ("request" ) : > > bash-4.4$ sedmgr -d /rs6000_64/nightly/output-jdk-test/images/jdk/bin/java > /rs6000_64/nightly/output-jdk-test/images/jdk/bin/java : request > > while the unchanged binary does not have the flag set ("system") : > > bash-4.4$ sedmgr -d /rs6000_64/nightly/output-jdk11-test/images/jdk/bin/java > /rs6000_64/nightly/output-jdk11-test/images/jdk/bin/java : system > > > > Bug/webrev : > > https://bugs.openjdk.java.net/browse/JDK-8223307 > > http://cr.openjdk.java.net/~mbaesken/webrevs/8223307.0/ > > > Thanks, Matthias > > > >> -----Original Message----- >> From: Erik Joelsson <erik.joelsson(a)oracle.com<mailto:erik.joelsson@oracle.com>> >> Sent: Freitag, 12. April 2019 15:30 >> To: Baesken, Matthias <matthias.baesken(a)sap.com<mailto:matthias.baesken@sap.com>>; ppc-aix-port- >> dev(a)openjdk.java.net<mailto:dev@openjdk.java.net>; 'build-dev(a)openjdk.java.net' <build- >> dev(a)openjdk.java.net<mailto:dev@openjdk.java.net>> >> Subject: Re: AIX : -bnorwexec linker flag >> >> From a build point of view, the patch looks good. I cannot comment on >> the validity of adding the flag though. >> >> /Erik >> >> On 2019-04-12 02:15, Baesken, Matthias wrote: >>> Hello, I have a question regarding the AIX -bnorwexec linker flag . >>> I think it is related to an AIX security feature SED , see also : >>> >>> >> https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm. >> aix.security/stack_exec_disable_flags.htm >>> When building with the additional -bnorwexec linker flag we signal the >> OS that we "request" the SED feature . >>> Please compare a patched and an unpatched java ( patched is flagged >> "request" while unpatched uses the "system" setting ). >>> bash-4.3$ sedmgr -d /patched_jdk/images/jdk/bin/java >>> /patched_jdk/images/images/jdk/bin/java : request >>> >>> >>> bash-4.3$ sedmgr -d /normal_jdk/images/jdk/bin/java >>> /normal_jdk/images/jdk/bin/java : system >>> >>> >>> System config on the example machine is "normal" (default) select : >>> bash-4.3$ sedmgr >>> Stack Execution Disable (SED) mode: select >>> SED configured in kernel: select >>> >>> >>> In our internal tests I noticed so far no issues when setting the - >> bnorwexec linker flag in OpenJDK on AIX . >>> Do you have any experience with it, do you see issues when setting the >> flag ? >>> >>> The documentation of the flag is a bit short . >>> >>> >>> >> https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm. >> aix.cmds3/ld.htm >>> >>> norwexec >>> >>> Specifies that if the system's sed_config setting is not off, the process' >> private data areas will have non-execute permission. >>> >>> >>> >>> Patch would be : >>> >>> diff -r 0d7fb7f07134 make/autoconf/flags-ldflags.m4 >>> --- a/make/autoconf/flags-ldflags.m4 Mon Apr 08 06:56:37 2019 +0100 >>> +++ b/make/autoconf/flags-ldflags.m4 Mon Apr 08 10:50:07 2019 +0200 >>> @@ -1,5 +1,5 @@ >>> # >>> -# Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved. >>> +# Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved. >>> # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>> # >>> # This code is free software; you can redistribute it and/or modify it >>> @@ -88,7 +88,7 @@ >>> BASIC_LDFLAGS_JVM_ONLY="-library=%none -mt -z noversion" >>> elif test "x$TOOLCHAIN_TYPE" = xxlc; then >>> - BASIC_LDFLAGS="-b64 -brtl -bnolibpath -bexpall -bernotok - >> btextpsize:64K \ >>> + BASIC_LDFLAGS="-b64 -brtl -bnorwexec -bnolibpath -bexpall -bernotok >> -btextpsize:64K \ >>> -bdatapsize:64K -bstackpsize:64K" >>> # libjvm.so has gotten too large for normal TOC size; compile with >> qpic=large and link with bigtoc >>> BASIC_LDFLAGS_JVM_ONLY="-Wl,-lC_r -bbigtoc" >>> >>> >>> Best regards, Matthias >>>

2 1

RFR: 8223307: enable the Stack Execution Disable flag for JDK binaries on AIX - was : AIX : -bnorwexec linker flag
by Baesken, Matthias 03 May '19

03 May '19

Hello, I created a webrev for the previously discussed issue (AIX : -bnorwexec linker flag). AIX supports a binary hardening option called SED, see : https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.secur… System wide configuration can be done with the sedmgr tool : https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm.aix.cmds5… The system-wide configuration supports various modes, very often "select" mode is configured where binaries can opt-in to use SED : "select: Only a select set of files are enabled and monitored for SED protection. The select set of files are chosen by reviewing the SED related flags in the executable program binary headers. The executable program header enables SED related flags to request to be included in the select mode." We can set a linker option on AIX to configure "select" mode for the JDK binaries; our tests show that this does not "kill" the JIT (jitted code). changed binary shows then the opt-in flag ("request" ) : bash-4.4$ sedmgr -d /rs6000_64/nightly/output-jdk-test/images/jdk/bin/java /rs6000_64/nightly/output-jdk-test/images/jdk/bin/java : request while the unchanged binary does not have the flag set ("system") : bash-4.4$ sedmgr -d /rs6000_64/nightly/output-jdk11-test/images/jdk/bin/java /rs6000_64/nightly/output-jdk11-test/images/jdk/bin/java : system Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8223307 http://cr.openjdk.java.net/~mbaesken/webrevs/8223307.0/ Thanks, Matthias > -----Original Message----- > From: Erik Joelsson <erik.joelsson(a)oracle.com> > Sent: Freitag, 12. April 2019 15:30 > To: Baesken, Matthias <matthias.baesken(a)sap.com>; ppc-aix-port- > dev(a)openjdk.java.net; 'build-dev(a)openjdk.java.net' <build- > dev(a)openjdk.java.net> > Subject: Re: AIX : -bnorwexec linker flag > > From a build point of view, the patch looks good. I cannot comment on > the validity of adding the flag though. > > /Erik > > On 2019-04-12 02:15, Baesken, Matthias wrote: > > Hello, I have a question regarding the AIX -bnorwexec linker flag . > > I think it is related to an AIX security feature SED , see also : > > > > > https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm. > aix.security/stack_exec_disable_flags.htm > > > > When building with the additional -bnorwexec linker flag we signal the > OS that we "request" the SED feature . > > Please compare a patched and an unpatched java ( patched is flagged > "request" while unpatched uses the "system" setting ). > > > > bash-4.3$ sedmgr -d /patched_jdk/images/jdk/bin/java > > /patched_jdk/images/images/jdk/bin/java : request > > > > > > bash-4.3$ sedmgr -d /normal_jdk/images/jdk/bin/java > > /normal_jdk/images/jdk/bin/java : system > > > > > > System config on the example machine is "normal" (default) select : > > bash-4.3$ sedmgr > > Stack Execution Disable (SED) mode: select > > SED configured in kernel: select > > > > > > In our internal tests I noticed so far no issues when setting the - > bnorwexec linker flag in OpenJDK on AIX . > > Do you have any experience with it, do you see issues when setting the > flag ? > > > > > > The documentation of the flag is a bit short . > > > > > > > https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm. > aix.cmds3/ld.htm > > > > > > norwexec > > > > Specifies that if the system's sed_config setting is not off, the process' > private data areas will have non-execute permission. > > > > > > > > > > Patch would be : > > > > diff -r 0d7fb7f07134 make/autoconf/flags-ldflags.m4 > > --- a/make/autoconf/flags-ldflags.m4 Mon Apr 08 06:56:37 2019 +0100 > > +++ b/make/autoconf/flags-ldflags.m4 Mon Apr 08 10:50:07 2019 +0200 > > @@ -1,5 +1,5 @@ > > # > > -# Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved. > > +# Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved. > > # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > # > > # This code is free software; you can redistribute it and/or modify it > > @@ -88,7 +88,7 @@ > > BASIC_LDFLAGS_JVM_ONLY="-library=%none -mt -z noversion" > > elif test "x$TOOLCHAIN_TYPE" = xxlc; then > > - BASIC_LDFLAGS="-b64 -brtl -bnolibpath -bexpall -bernotok - > btextpsize:64K \ > > + BASIC_LDFLAGS="-b64 -brtl -bnorwexec -bnolibpath -bexpall -bernotok > -btextpsize:64K \ > > -bdatapsize:64K -bstackpsize:64K" > > # libjvm.so has gotten too large for normal TOC size; compile with > qpic=large and link with bigtoc > > BASIC_LDFLAGS_JVM_ONLY="-Wl,-lC_r -bbigtoc" > > > > > > Best regards, Matthias > >

2 1

[8u] RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation
by Severin Gehwolf 30 Apr '19

30 Apr '19

Hi, Could I please get a review for this 8u backport related to fdlibm optimization on Linux? The JDK 12 patch doesn't apply as-is as the JDK 8 build system is drastically different from JDK 11+. Bug: https://bugs.openjdk.java.net/browse/JDK-8210416 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/jdk8/02/ The main differences to the original fix are: a) optimization level and b) additional hook for older GCC. This backport keeps the optimization level at -O3 (HIGH) over -O2 (LOW) for JDK 8u as this would otherwise regress Linux ppc64{,le} which currently use -O3. As the current code has the implicit assumption of ppc64 being compiled on older GCCs too (JDK-8172053), this backport maintains compatibility in this regard. If -ffp-contract=off is not available, a machine specific set of flags is being used if the compiler supports them (-mno-fused-madd -fno-strict- aliasing). For older GCCs (< 4.6) specific machine flags are being used. That is, for ppc64{,le} and x86{,_64}. ppc64{,le} machine specific flags have already been determined (See JDK-8172053). x86_64 and x86 have the same machine specific flags available, so I've used them there too[1]. Testing: build/test on gcc 8.x Linux x86_64. build/test on gcc 4.4.7 x86_64/ppc64. Manual inspection of build logs for fdlibm files (e.g. w_asin.c). Thoughts? Thanks, Severin [1] https://gcc.gnu.org/onlinedocs/gcc-4.4.7/gcc/i386-and-x86_002d64-Options.ht…

2 2

RFR : 8222280 : Provide virtualization related info in the hs_error file on AIX
by Baesken, Matthias 16 Apr '19

16 Apr '19

Hello, please review the following change . It brings AIX related virtualization information into the hs_err file . While preparing the patch I wondered a bit about the libperfstat usage in OpenJDK (Hotspot compared to JDK ). In JDK we link already to libperfstat at build time , see : jdk/make/lib/Lib-java.management.gmk BUILD_LIBMANAGEMENT jdk/make/lib/Lib-jdk.management.gmk BUILD_LIBMANAGEMENT_EXT While in hotspot dlopen/dladdr is used , see jdk/src/hotspot/os/aix/libperfstat_aix.cpp 58 bool libperfstat::init() { 59 60 // Dynamically load the libperfstat porting library. 61 g_libhandle = dlopen("/usr/lib/libperfstat.a(shr_64.o)", RTLD_MEMBER | RTLD_NOW); 62 if (!g_libhandle) { 63 trcVerbose("Cannot load libperfstat.a (dlerror: %s)", dlerror()); 64 return false; 65 } we dlopen and then resolve symbols at runtime. This was probably a good thing back then when AIX 5.3 was still supported as build platform , but I am not sure if it is still needed these days on AIX 7.1/7.2 . But in case the dlopen/dladdr approach in HS is still needed/wanted , I would switch to the libperfstat:: functions . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8222280 http://cr.openjdk.java.net/~mbaesken/webrevs/8222280_aix_virt.0/ Thanks , Matthias

3 4

AIX : -bnorwexec linker flag
by Baesken, Matthias 15 Apr '19

15 Apr '19

Hello, I have a question regarding the AIX -bnorwexec linker flag . I think it is related to an AIX security feature SED , see also : https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.secur… When building with the additional -bnorwexec linker flag we signal the OS that we "request" the SED feature . Please compare a patched and an unpatched java ( patched is flagged "request" while unpatched uses the "system" setting ). bash-4.3$ sedmgr -d /patched_jdk/images/jdk/bin/java /patched_jdk/images/images/jdk/bin/java : request bash-4.3$ sedmgr -d /normal_jdk/images/jdk/bin/java /normal_jdk/images/jdk/bin/java : system System config on the example machine is "normal" (default) select : bash-4.3$ sedmgr Stack Execution Disable (SED) mode: select SED configured in kernel: select In our internal tests I noticed so far no issues when setting the -bnorwexec linker flag in OpenJDK on AIX . Do you have any experience with it, do you see issues when setting the flag ? The documentation of the flag is a bit short . https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/com.ibm.aix.cmds3… norwexec Specifies that if the system's sed_config setting is not off, the process' private data areas will have non-execute permission. Patch would be : diff -r 0d7fb7f07134 make/autoconf/flags-ldflags.m4 --- a/make/autoconf/flags-ldflags.m4 Mon Apr 08 06:56:37 2019 +0100 +++ b/make/autoconf/flags-ldflags.m4 Mon Apr 08 10:50:07 2019 +0200 @@ -1,5 +1,5 @@ # -# Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -88,7 +88,7 @@ BASIC_LDFLAGS_JVM_ONLY="-library=%none -mt -z noversion" elif test "x$TOOLCHAIN_TYPE" = xxlc; then - BASIC_LDFLAGS="-b64 -brtl -bnolibpath -bexpall -bernotok -btextpsize:64K \ + BASIC_LDFLAGS="-b64 -brtl -bnorwexec -bnolibpath -bexpall -bernotok -btextpsize:64K \ -bdatapsize:64K -bstackpsize:64K" # libjvm.so has gotten too large for normal TOC size; compile with qpic=large and link with bigtoc BASIC_LDFLAGS_JVM_ONLY="-Wl,-lC_r -bbigtoc" Best regards, Matthias

3 5

RFR: 8221915: cleanup ticks related coding in os_perf_aix.cpp [aix]
by Baesken, Matthias 09 Apr '19

09 Apr '19

Hello, please review this small AIX related cleanup change . When recently looking into the os_perf coding , I noticed that we try to read (on AIX) cpu ticks related data from /proc/stat . However this will most likely fail, on the AIX machines I checked there is a /proc but no /proc/stat . (probably the AIX coding has been taken over from linux) The change cleans up the coding in os_perf_aix.cpp . ( there might be other ways to get the CPU ticks related info on AIX e.g. by using libperfstat or by using what <sys/procfs.h> has to offer, see https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.files… , but this should be checked and maybe added with another change in case someone is interested ) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8221915 http://cr.openjdk.java.net/~mbaesken/webrevs/8221915.0/ Thanks, Matthias

2 5