- ppc-aix-port-dev - openjdk.org

RFR : 8227869: fix wrong format specifiers in os_aix.cpp
by Baesken, Matthias 18 Jul '19

18 Jul '19

Hello, there are a couple of non matching format specifiers in os_aix.cpp . I adjust them with my change . Please review ! Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8227869 http://cr.openjdk.java.net/~mbaesken/webrevs/8227869.0/ Thanks, Matthias

4 13

xlc : using clang-style warning disabling
by Baesken, Matthias 18 Jul '19

18 Jul '19

Hello, we recently switched to xlc16 / xlclang in the AIX build . ( jdk11 stays on the so-called "legacy" xlc 12 ) I would suggest to switch to the clang-style warning disabling - style now in jdk/jdk ( = jdk14) to avoid some warnings in the build . I think we are pretty close to reduce the compiler warnings to 0 on AIX , which would make it possible to build with warnings as errors at some point in the future . Any thoughts / comments / opinions? For now I would start with those warnings disabled for hotspot : tautological-compare : /jdk/src/hotspot/os/aix/os_aix.cpp:2400:15: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] if (bytes >= Use64KPagesThreshold) { ~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~ /jdk/src/hotspot/os/aix/os_aix.cpp:2607:15: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] if (bytes >= Use64KPagesThreshold) { In the product build the "Use64KPagesThreshold" is a constant so clang complains . However in the (fast)debug builds one can set Use64KPagesThreshold with an -XX setting. So I think it is best to disable the warning. shift-negative-value : /jdk/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp:429:97: warning: shifting a negative signed value is undefined [-Wshift-negative-value] (x->op() == Bytecodes::_lsub && right.value()->type()->as_LongConstant()->value() == ((-1)<<15)) ) { ~~~~^ /jdk/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp:483:96: warning: shifting a negative signed value is undefined [-Wshift-negative-value] (x->op() == Bytecodes::_isub && right.value()->type()->as_IntConstant()->value() == ((-1)<<15)) ) { We could probably replace the -1 shift by a constant but I think it is nicely readable . A patch is below . Best regards, Matthias diff -r 1b0c0af50d4e make/autoconf/flags-cflags.m4 --- a/make/autoconf/flags-cflags.m4 Wed Jul 17 15:40:27 2019 +0200 +++ b/make/autoconf/flags-cflags.m4 Thu Jul 18 13:21:24 2019 +0200 @@ -229,7 +229,7 @@ ;; xlc) - DISABLE_WARNING_PREFIX="-qsuppress=" + DISABLE_WARNING_PREFIX="-Wno-" CFLAGS_WARNINGS_ARE_ERRORS="-qhalt=w" # Possibly a better subset than "all" is "lan:trx:ret:zea:cmp:ret" diff -r 1b0c0af50d4e make/hotspot/lib/CompileJvm.gmk --- a/make/hotspot/lib/CompileJvm.gmk Wed Jul 17 15:40:27 2019 +0200 +++ b/make/hotspot/lib/CompileJvm.gmk Thu Jul 18 13:21:24 2019 +0200 @@ -95,8 +95,7 @@ unknownpragma doubunder w_enumnotused w_toomanyenumnotused \ wvarhidenmem wunreachable wnoretvalue notemsource -DISABLED_WARNINGS_xlc := 1540-0216 1540-0198 1540-1090 1540-1639 1540-1088 \ - 1500-010 +DISABLED_WARNINGS_xlc := tautological-compare shift-negative-value DISABLED_WARNINGS_microsoft := diff -r 1b0c0af50d4e make/lib/Awt2dLibraries.gmk --- a/make/lib/Awt2dLibraries.gmk Wed Jul 17 15:40:27 2019 +0200 +++ b/make/lib/Awt2dLibraries.gmk Thu Jul 18 13:21:24 2019 +0200 @@ -471,7 +471,6 @@ $(LIBAWT_HEADLESS_CFLAGS), \ EXTRA_HEADER_DIRS := $(LIBAWT_HEADLESS_EXTRA_HEADER_DIRS), \ DISABLED_WARNINGS_gcc := unused-function, \ - DISABLED_WARNINGS_xlc := 1506-356, \ DISABLED_WARNINGS_solstudio := E_EMPTY_TRANSLATION_UNIT, \ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ @@ -481,10 +480,6 @@ LIBS_solaris := $(LIBM) $(LIBDL) $(LIBCXX), \ )) - # AIX warning explanation: - # 1506-356 : (W) Compilation unit is empty. - # This happens during the headless build - $(BUILD_LIBAWT_HEADLESS): $(BUILD_LIBAWT) TARGETS += $(BUILD_LIBAWT_HEADLESS)

1 0

RFR : 8227737: avoid implicit-function-declaration on AIX
by Baesken, Matthias 17 Jul '19

17 Jul '19

Hello, please review the following AIX related change . It fixes a number of missing inclusions leading to implicit-function-declaration warnings when compiling with the recent xlc16 /xlclang . At various places in the native C coding in jdk, we miss header inclusions on AIX. This leads to warnings like : /nightly/jdk/src/java.base/unix/native/libjava/childproc.c:99:5: warning: implicitly declaring library function 'snprintf' with type 'int (char *, unsigned long, const char *, ...)' [-Wimplicit-function-declaration] snprintf(aix_fd_dir, 32, "/proc/%d/fd", getpid()); ^ /nightly/jdk/src/java.base/unix/native/libjava/childproc.c:99:5: note: include the header <stdio.h> or explicitly provide a declaration for 'snprintf' or /nightly/jdk/src/java.base/aix/native/libjli/java_md_aix.c:38:5: warning: implicitly declaring library function 'memset' with type 'void *(void *, int, unsigned long)' [-Wimplicit-function-declaration] memset((void *)info, 0, sizeof(Dl_info)); /nightly/jdk/src/java.base/aix/native/libjli/java_md_aix.c:38:5: note: include the header <string.h> or explicitly provide a declaration for 'memset' Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8227737 http://cr.openjdk.java.net/~mbaesken/webrevs/8227737.0/ Thanks, Matthias

2 2

loadquery failed error message displayed
by Steve Groeger 16 Jul '19

16 Jul '19

Hi all, We have a scenario where in a Java program after loading some shared libraries (using System.loadLibrary) and then calling javax.imageio.ImageIO.read(new File(..)) the java program displays the following error message: loadquery failed (12 Not enough space) This happens when running on AIX with Java 11 using this sample code: import java.io.File; import java.util.Map; import javax.imageio.ImageIO; public class Reproduce { public static void main(String[] args) { try { System.loadLibrary("mylib"); String filePath = "..."; BufferedImage img = ImageIO.read(new File(filePath)); } catch (Throwable e) { System.out.println("Exception : " + e); e.printStackTrace(); } } } It seems that this is displayed from src/java.desktop/aix/native/libawt/porting_aix.c static unsigned char dladdr_buffer[0x4000]; static void fill_dll_info(void) { int rc = loadquery(L_GETINFO,dladdr_buffer, sizeof(dladdr_buffer)); if (rc == -1) { fprintf(stderr, "loadquery failed (%d %s)", errno, strerror(errno)); fflush(stderr); } } and is due to the dladdr_info buffer being too small to contain all the data returned from the loadquery function. The same buffer size is also used in src/java.base/aix/native/libjli/java_md_aix.c Could / Should the size of these buffers be increased to handle the large data and prevent the error message from being displayed. If so, I am happy to raise an issue and to generate a webrev for this. What would people suggest as a suitable size for the buffer, ie double the size (x8000) or something else? Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges(a)uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

3 7

RFR: 8227631: Adjust AIX version check
by Baesken, Matthias 12 Jul '19

12 Jul '19

Hello, please review this small AIX related change . For some time, we do not support AIX 5.3 any more. See (where AIX 7.1 or 7.2 is the supported build platform since OpenJDK11) : https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms The currently used xlc 16.1 (XL C/C++ Compilers) even needs minimum AIX 7.1 to run , see http://www-01.ibm.com/support/docview.wss?uid=swg21326972 (and compiling for older releases on 7.1 / 7.2 would not work easily , at least not "out of the box" to my knowledge .) So we should adjust the minimum OS version check done in os_aix.cpp in os::Aix::initialize_os_info() . Additionally the change removes a couple of warnings [-Wwritable-strings category] . /nightly/jdk/src/hotspot/os/aix/os_aix.cpp:4081:22: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] char *name_str = "unknown OS"; ^ /nightly/jdk/src/hotspot/os/aix/os_aix.cpp:4089:18: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] name_str = "OS/400 (pase)"; ^ /nightly/jdk/src/hotspot/os/aix/os_aix.cpp:4100:18: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] name_str = "AIX"; Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8227631 http://cr.openjdk.java.net/~mbaesken/webrevs/8227631.0/ Thanks, Matthias

2 1

8227389: Remove unsupported xlc16 compile options on aix - was : RE: AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not supported
by Baesken, Matthias 08 Jul '19

08 Jul '19

Hello, here is a small webrev removing the 2 mentioned options . When compiling jdk/jdk on AIX (using current xlc16 / xlclang) we run into these warnings : warning: 1540-5200 The option "langlvl=c99vla" is not supported. : This option controls variable length arrays / Enables or disables support for C99-type variable length arrays. warning: 1540-5200 The option "langlvl=noredefmac" is not supported. : Controls whether a macro can be redefined without a prior #undef or undefine() statement. see https://www.ibm.com/support/knowledgecenter/SSGH3R_16.1.0/com.ibm.compilers… The mentioned options are only available with the legacy xlc (non xlclang). I propose to remove these options, because xlc16 / xlclang is now the default compiler. Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8227389 http://cr.openjdk.java.net/~mbaesken/webrevs/8227389.0/ Thanks and best regards, Matthias I think this is fine for 14. Cheers, Thomas On Mon, Jul 8, 2019 at 9:23 AM Baesken, Matthias <matthias.baesken(a)sap.com<mailto:matthias.baesken@sap.com>> wrote: Hello, when building jdk/jdk on AIX (using the current default xlc16) I get a ton of warnings : warning: 1540-5200 The option "langlvl=c99vla" is not supported. warning: 1540-5200 The option "langlvl=noredefmac" is not supported. The 2 options seem to be gone with the current xlc16 / xlclang++ . I would like to remove them - any objections ? (removing them might be bad for older xlc versions but I think we probably cannot compile with older versions any more ) . Best regards, Matthias

3 2

AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not supported
by Baesken, Matthias 08 Jul '19

08 Jul '19

Hello, when building jdk/jdk on AIX (using the current default xlc16) I get a ton of warnings : warning: 1540-5200 The option "langlvl=c99vla" is not supported. warning: 1540-5200 The option "langlvl=noredefmac" is not supported. The 2 options seem to be gone with the current xlc16 / xlclang++ . I would like to remove them - any objections ? (removing them might be bad for older xlc versions but I think we probably cannot compile with older versions any more ) . Best regards, Matthias

2 1

RFR(T): 8227252: [aix] Disable jdk/java/lang/reflect/exeCallerAccessTest
by Thomas Stüfe 05 Jul '19

05 Jul '19

Greetings, please review this trivial fix which switches off jdk/java/lang/reflect/exeCallerAccessTest on AIX. JBS: https://bugs.openjdk.java.net/browse/JDK-8227252 cr: http://cr.openjdk.java.net/~stuefe/webrevs/8227252-disable-execallertest-on… Thanks, Thomas

3 3

RFR: [XS] 8227171: provide function names in native stack trace on aix with xlc16
by Baesken, Matthias 04 Jul '19

04 Jul '19

Hello please review this small fix for AIX (needed with the new xlc16) . Currently we miss function names in the hs_err file : 0x0000000115098660 - 0x090000000f629a4c libjvm.so::<nameless function>+0x6c (C++ saves_lr stores_bc gpr_saved:4 ) 0x00000001150986f0 - 0x09000000113594bc libjvm.so::<nameless function>+0x95c (C++ saves_lr stores_bc gpr_saved:18 ) The output contains "nameless function" instead of the (member) function names . Looks like this unwanted behavior was introduced when switching to the xlc16 compiler. With xlc16, it looks like we have to configure the traceback table generation to get the output we need. The -qtbtable=full setting can be used for this _ https://www.ibm.com/support/knowledgecenter/SSGH4D_16.1.0/com.ibm.xlf161.ai… Bug / webrev : https://bugs.openjdk.java.net/browse/JDK-8227171 http://cr.openjdk.java.net/~mbaesken/webrevs/8227171.0/ Thanks, Matthias

2 4

8226863: [aix] jdk/java/lang/reflect/exeCallerAccessTest cannot launch on primordial thread
by Thomas Stüfe 03 Jul '19

03 Jul '19

Hi all, Issue: https://bugs.openjdk.java.net/browse/JDK-8226863 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8226863--jdk-java-lang-reflect-e… we have this annoying issue on AIX that the libjvm cannot be invoked on a primordial thread. Therefore we need to change launchers which create the VM to spawn own threads (we only do this where it is worth the effort - this, admittedly, is a corner case, we could alternatively just disable the test on AIX). This is annoying and vaguely embarrassing :-/ Maybe IBM will step in some time and help us solve the underlying issues which have to do with the inability to create guard pages on the primordial thread stack (among other things IIRC). Thanks for reviewing, Thomas

3 6