[aarch64-port-dev ] Fwd: 8u-aarch64 : Backport 8163363: AArch64: Stack size in tools/launcher/Settings.java needs to be adjusted

[Andrew Dinn]

On 06/08/2019 17:35, Aleksey Shipilev wrote:
> On 8/6/19 10:49 AM, Andrew Dinn wrote:
>> The backport requires a minor tweak to the original patch as per the
>> following webrev:
>>
>>   http://cr.openjdk.java.net/~adinn/8163363-jdk8u/webrev.00/
> 
> *) I don't understand, why "ppc64le" case was added?
> 
>   78         if (getArch().equals("ppc64") || getArch().equals("ppc64le")) {

That is because I back-ported the original patch and it was included in
that patch and went in automatically. Is ppc64le not a thing in jdk8u?
If so I can remove it.

> *) Original change has this comment, are we ignoring it?
> 
>  // Check the stack size logs printed by -XshowSettings to verify -Xss meaningfully.

That comment was not in the jdk8u code but was in a part of the original
change set that conflicted with the jdk8u code. So, i omitted to copy it
in when I manually reconciled the code. I will restore it if you want.

> Otherwise looks okay.
Right, shall I push with those two corrections?

Does jdk8u-shenandoah demand a jdk8u-fix-request/yes dance? Or can I
just push?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander