code review round 0 for minor FDS makefile fix (8033714)

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Feb 6 04:25:49 UTC 2014


Ron,

Thanks for the review.

Dan


On 2/5/14 7:04 PM, Ron Durbin wrote:
> Dan
>
> The changes look good
>
> Ron
>> -----Original Message-----
>> From: Daniel D. Daugherty
>> Sent: Wednesday, February 05, 2014 4:21 PM
>> To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net; build-dev;
>> Doug Simon; Tom Rodriguez
>> Subject: code review round 0 for minor FDS makefile fix (8033714)
>>
>> This code review request is going to three different aliases.
>> Don't use Thunderbird's "reply to list" option since it will pick just _one_ of the _three_
>> lists.
>>
>>
>> Greetings,
>>
>> Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS) makefile fix our way. Here
>> are the bug and webrev URLs:
>>
>> http://cr.openjdk.java.net/~dcubed/8033714-webrev/0-jdk9-hs-runtime/
>>
>>       8033714 hotspot 'install_jvm' bld target broken with
>> ZIP_DEBUGINFO_FILES=0
>>       https://bugs.openjdk.java.net/browse/JDK-8033714
>>
>> As you might guess from the bug synopsis, this fix is needed when building without ZIP'ing
>> the debuginfo files (ZIP_DEBUGINFO_FILES=0).
>> Based on the Graal project fix, I've updated a few other places where building with FDS
>> disabled is affected.
>>
>> As always, comments and suggestions are welcome.
>>
>> Dan




More information about the build-dev mailing list