RFR: 8034979 : (xs) Configuration help messages don't consider --no-create

Erik Joelsson erik.joelsson at oracle.com
Mon Feb 17 09:19:44 UTC 2014


Looks good to me.

/Erik

On 2014-02-14 23:26, Mike Duigou wrote:
> Hello all;
>
> This is a small cleanup patch with provides better summary help output for reconfigure and dry-run configurations.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8034979/0/webrev/
>
> I do note that even though no configuration is created/updated in "--no-create" mode the output directory is created and a few files, though not a configuration, are written there.
>
> Testing consisted of :
>
> rm -rf build/
> sh configure -n  # got expected "A configuration has been successfully checked but not created" notice
> sh configure     # got expected "A new configuration has been successfully created in ...." notice
> sh configure -n  # got expected "The existing configuration has been successfully checked in ...." notice
> sh configure     # got expected "The existing configuration has been successfully updated in ...." notice and warning.
>
> Cheers,
>
> Mike




More information about the build-dev mailing list