[EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs

[George Adams]

H David,


The key difference is that we wouldn’t nee to keep updating the full version number/checksum. We could ofcourse use the oracle-actions/setup-java<https://github.com/oracle-actions/setup-java> and do something like this:

  - name: 'Set up latest Oracle JDK 18'
    uses: oracle-actions/setup-java at v1
    with:
      website: oracle.com
      release: 18

I’m more than happy to leave the codebase as it is but I don’t like the way that we have to keep updating the version number/checksum.

Thanks

George

From: David Holmes <david.holmes at oracle.com>
Date: Tuesday, 12 July 2022 at 02:24
To: George Adams <George.Adams at microsoft.com>, build-dev at openjdk.org <build-dev at openjdk.org>
Subject: [EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs
[You don't often get email from david.holmes at oracle.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Hi George,

On 12/07/2022 6:30 am, George Adams wrote:
> Hi all,
>
> I was speaking with Christoph Clanger today about the GitHub actions
> rewrite <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.org%2Fbrowse%2FJDK-8287906&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hEzzv1iXX4TmSoWA%2BqoNKleGGPxr4Z9izrsxApfJfVs%3D&reserved=0> which has already
> made contributing so much simpler.
>
> I wanted to see if there was an interest in switching to using the
> actions/setup-java <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Factions%2Fsetup-java&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Zsb%2BEAJz0K1GkNwSC%2Fmep4cbkQeH68PxPb6ULUQqSqA%3D&reserved=0> GitHub action
> as a way of handling the Boot JDK installation rather than the current
> hardcoded URLs defined here
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fblob%2Fmaster%2Fmake%2Fconf%2Fgithub-actions.conf%23L31-L41&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bVhVDzv%2FJxXCeVgpDGVi8sdxOTQZvT6R4730ay%2BU%2Bk4%3D&reserved=0
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fblob%2Fmaster%2Fmake%2Fconf%2Fgithub-actions.conf%23L31-L41&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bVhVDzv%2FJxXCeVgpDGVi8sdxOTQZvT6R4730ay%2BU%2Bk4%3D&reserved=0>
>
> If people think this is a good idea then I’ll submit a patch for review
> this week.

I don't really see any benefit to doing this, especially when the
existing hardcoded downloads do not even appear to be available via
setup-java. And even if they were we would just replace a fixed known
URL with a fixed known (java-version, distribution) pair of arguments to
setup-java. And setup-java seems to do far more than what we need for
our GHA testing.

Just my 2c.

Cheers,
David

>
> Thanks
>
> George
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20220712/b9070fb9/attachment.htm>