RFR: 8325342: Remove unneeded exceptions in compare.sh [v2]

[Erik Joelsson]

On Wed, 21 Feb 2024 17:27:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Over time, we have been better at addressing inconsistencies in the build, but the exceptions put in place in compare.sh have not been updated to reflect this.
>> 
>> This attempts to make sure we only keep those exceptions that are currently actually needed to verify a reproducible build (the primary usecase for the compare script these days).
>> 
>> I also discovered bugs in the script, where mismatches in a zip file did not make us report a failed comparison. I added extra code to make sure we always set the REGRESSION flag whenever we detect a problem.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
> 
>  - Restore jar_contents exception
>  - Do not compare .pdb files
>  - Assume GraphViz non-determinism has been fixed in 9.0
>  - Remove jar_contents exception
>  - Test debug symbol files separately, for clarity
>  - Merge branch 'master' into remove-compare-exceptions
>  - Also fix windows debug files
>  - Do not make debuginfo files executable
>  - Add support for linux debug files
>  - Separate out debug files
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/7781005f...2db17083

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17735#pullrequestreview-1894022381