RFR: 8325342: Remove unneeded exceptions in compare.sh

Magnus Ihse Bursie ihse at openjdk.org
Wed Feb 21 17:27:21 UTC 2024


On Tue, 6 Feb 2024 16:53:37 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Over time, we have been better at addressing inconsistencies in the build, but the exceptions put in place in compare.sh have not been updated to reflect this.
> 
> This attempts to make sure we only keep those exceptions that are currently actually needed to verify a reproducible build (the primary usecase for the compare script these days).
> 
> I also discovered bugs in the script, where mismatches in a zip file did not make us report a failed comparison. I added extra code to make sure we always set the REGRESSION flag whenever we detect a problem.

I will actually rework how files are selected completely.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17735#issuecomment-1938940767


More information about the build-dev mailing list