RFR: 8315584 : java/awt/print/Dialog/DialogType.java fails with option not supported: yesno [v2]

[Phil Race]

On Wed, 6 Sep 2023 19:16:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed the unused import statement and comma
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 54:
> 
>> 52:             control which differs in appearance from the second dialog.
>> 53:             Note: You can either press 'ESCAPE' button or click on the 'Cancel'
>> 54:             to close print dialog.
> 
> Basically, the only thing that's required from the user is to close the dialogs shown by pressing Esc or clicking Cancel?
> 
> Once they're dismissed, the test could finish automatically. If it's the case, it's better to explain it in the instructions.
> 
> If an exception is thrown, the test will finish automatically.
> 
> ---
> 
> It looks such a scenario is not covered by PassFailJFrame well: the instructions need to be shown for a short while before the test starts. After the user reads the instructions, the user clicks **Start** button. Then the instructions can be hidden or left on the screen (it depends on how long and complex the instructions are), and the test continues with its execution.
> 
> As soon as the test logic finishes, the test dismisses the instructions if they're still visible, and exits.
> 
> I know about at least three cases where a reduced functionality is required.

Are you saying this test would be better with an enhancement to PassFailJFrame ?
But it is OK right, just more clunky than it could be .. ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15554#discussion_r1330743505