[PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

[Jonathan Gibbons]

On 3/15/19 4:06 PM, Donald Kwakkel wrote:
> After discussion and conclusion on core-libs-dev the spec is changed
> that manifest classpath must be handled the same in java as javac. And
> Jonathan told me to continue now on this list.
>
> I created a fix + tests for
> https://bugs.openjdk.java.net/browse/JDK-8218268. Now the manifest
> classpath is behaving the same in javac and java for file paths as it
> was in java 8. See attached first patch.
>
> Now I would like to reuse the code of URLClassLoader (see second
> attached patch), but it seems I can not use SharedSecrets from
> FSInfo.java:

That's right, you can't.


>
> * For target buildtools_interim_langtools_modules_jdk.compiler.interim__the.BUILD_jdk.compiler.interim_batch:
> jdk/src/jdk.compiler/share/classes/com/sun/tools/javac/file/FSInfo.java:51:
> error: package jdk.internal.access does not exist
> import jdk.internal.access.SharedSecrets;
>
> Where should I locate the common code and how can it be called both
> from URLClassLoader and FSInfo?

As bad as it sounds, you should probably not try and share the code in 
this case.


> Kind Regards,
>
> Donald