RFR: 8253736: Cleanup some of WorkArounds and usage thereof

[Jonathan Gibbons]

On Thu, 1 Oct 2020 15:13:20 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> This cleanup is primarily focussed on the WorkArounds class, simplifying/removing code that is no longer required.
>> 
>> Also, simplified DocLint initialization such that it no longer needs a `JavacTask` and so the initiate code can be
>> moved out of `WorkArounds`.
>> The "constant value expression" in Utils is simplified to remove a redundant level of enclosing nested class for the
>> type-kind visitor.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java line 117:
> 
>> 115:
>> 116:     /*
>> 117:      * TODO: This method exists because of a bug in javac which does not
> 
> probably a good idea to include the bug ID here?

@vicente-romero-oracle This relates to a discussion we should have elsewhere, separately, about the interactions
between deprecation and packages, and whether we should support depicted packages. JLS does not list packages in the
list of kinds of elements that can be deprecated, in which case this comment is probably incorrect, as the bug may
actually be here in javadoc for trying to support deprecated packages!

-------------

PR: https://git.openjdk.java.net/jdk/pull/412