RFR: 8253736: Cleanup some of WorkArounds and usage thereof

Jonathan Gibbons jjg at openjdk.java.net
Thu Oct 1 17:25:15 UTC 2020


On Thu, 1 Oct 2020 15:18:44 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> This cleanup is primarily focussed on the WorkArounds class, simplifying/removing code that is no longer required.
>> 
>> Also, simplified DocLint initialization such that it no longer needs a `JavacTask` and so the initiate code can be
>> moved out of `WorkArounds`.
>> The "constant value expression" in Utils is simplified to remove a redundant level of enclosing nested class for the
>> type-kind visitor.
>
> just a nit comment, no need for another iteration, the changes looks good to me

@vicente-romero-oracle thanks for the review.
I raised the number of reviewers to have a javadoc reviewer participate as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/412


More information about the compiler-dev mailing list