Review request: JDK-8080108: [TEST_BUG] ERROR: No IPv6 address returned from platform
Chris Hegarty
chris.hegarty at oracle.com
Tue Aug 4 10:29:49 UTC 2015
Alexander,
Wow, that's a lot of boiler plate for a manual test. Surely a
README.txt, or similar would be sufficient?
I noticed that with your changes, now this test has a dependency on the
jdk.desktop module ( imports from java.awt.* ). Is it really necessary
to have a dialog window pop-up?
-Chris.
On 29/07/15 12:59, Alexander Fomin wrote:
> Hello,
>
> Please review the test bug fix
> https://bugs.openjdk.java.net/browse/JDK-8080108
>
> See webrev here
> http://cr.openjdk.java.net/~kshefov/8080108/webrev.00/
>
> The original test
> (com/sun/jndi/dns/IPv6NameserverPlatformParsingTest.java @bug 6991580)
> fails automatically if /etc/resolv.conf file doesn't contain IPv6
> nameserver entries.
> It's needed to edit /etc/resolv.conf manually before the test run, so
> this is a manual regression test.
> The test is intended to be run on non-Windows systems.
>
> Fix:
> - provided standard test machinery for regression manual tests with
> instructions for a user;
> - the test excluded for Windows.
>
> Tested on Linux and Windows(to make sure it's excluded).
>
> Thanks,
> Alexander
More information about the core-libs-dev
mailing list