RFR (JAXP): 8162598 XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace

[Daniel Fuchs]

Hi Christoph,

Looks good in general, even though the idiom
   if (existing instanceof Stack<?>)
caught my eye.

Thanks for the new test! I wonder if it should be
made more strict - with a golden record of the expected
results.

In particular, to check that the xmlns="" in element
<c> is removed only when it should.
Before your fix, it was always removed, even when it
should not have!

best regards,

-- daniel


On 28/07/16 14:10, Langer, Christoph wrote:
> Hi,
>
>
>
> please review my change for the XSLT namespace issue.
>
>
>
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8162598.1/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8162598
>
>
>
> The issue has already been discussed in this thread:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042525.html
>
>
>
> Apart from the real fix in LiteralElement.java, method translate(), I’ve
> done some further cleanups in a few places. @Joe: The cleanups collide
> with some places of your proposed change for
> https://bugs.openjdk.java.net/browse/JDK-8158084 where we’d like to do
> the same things. So we’ll have to synchronize on pushing.
>
>
>
> I’ve also enhanced the test case “TransformerTest” and added a method
> which does a regression test for the bug reported.
>
>
>
> Thanks in advance for reviewing.
>
>
>
> Best regards
>
> Christoph
>
>
>