RFR: 8353888: Implement JEP 510: Key Derivation Function API [v5]
Sean Mullan
mullan at openjdk.org
Fri May 2 12:56:50 UTC 2025
On Thu, 1 May 2025 14:50:31 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Finalize the KDF API.
>
> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>
> - merge
> - add a positive debug log and update exception message
> - enhancing exception messages and debug outputs
> - update @since tags as required by JEP 12
> - add enum back
> - the change
src/java.base/share/classes/javax/crypto/KDF.java line 481:
> 479:
> 480: // Rethrows the IAPE thrown by an implementation, adding an explanation
> 481: // on in which situation it fails.
suggest rewording as "for the situation in which it fails."
src/java.base/share/classes/javax/crypto/KDF.java line 491:
> 489: + "using the supplied derivation "
> 490: + "inputs, using the " + source + " "
> 491: + theOne.provider().getName()
Suggest rewording as: "inputs with the " + source + " " + theOne.provider().getName() + " provider."
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24520#discussion_r2071561925
PR Review Comment: https://git.openjdk.org/jdk/pull/24520#discussion_r2071567362
More information about the core-libs-dev
mailing list