RFR: 8353888: Implement JEP 510: Key Derivation Function API [v5]
Weijun Wang
weijun at openjdk.org
Fri May 2 18:31:52 UTC 2025
On Fri, 2 May 2025 12:50:41 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>>
>> - merge
>> - add a positive debug log and update exception message
>> - enhancing exception messages and debug outputs
>> - update @since tags as required by JEP 12
>> - add enum back
>> - the change
>
> src/java.base/share/classes/javax/crypto/KDF.java line 491:
>
>> 489: + "using the supplied derivation "
>> 490: + "inputs, using the " + source + " "
>> 491: + theOne.provider().getName()
>
> Suggest rewording as: "inputs with the " + source + " " + theOne.provider().getName() + " provider."
The exception message following uses `"The " + source + " provider " + theOne.provider.getName()`. Shall I also switch to `"The " + source + " " + theOne.provider.getName() + " provider"`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24520#discussion_r2071997676
More information about the core-libs-dev
mailing list