Changes in Makefile.am for IcedTea6-1.7.1 (PulseAudio issue)

[Andrew John Hughes]

On 9 March 2010 14:48, Pavel Tisnovsky <ptisnovs at redhat.com> wrote:
> Andrew John Hughes wrote:
>>
>> On 9 March 2010 12:59, Gary Benson <gbenson at redhat.com> wrote:
>>>
>>> Andrew John Hughes wrote:
>>>>
>>>> On 14:38 Tue 09 Mar     , Pavel Tisnovsky wrote:
>>>>>
>>>>> there is one new PulseAudio issue in IcedTea6-1.7.1 - library for
>>>>> wrong platform (ppc32) is used when IcedTea is built for ppc64
>>>>> platform.
>>>>>
>>>>> This issue can be easily fixed by small change in Makefile.am. I
>>>>> created patch for IcedTea6-1.7.1 (it is based on patch which Gary
>>>>> sent me yesterday - thanks very much btw :-) and successfully
>>>>> tested "patched" IcedTea6-1.7.1 on F10 i386 and F10 ppc. Is it
>>>>> possible to push this change to IcedTea6-1.7 repository (I suppose
>>>>> IcedTea6.1-7 and IcedTea6-1.7.1 has the same repo, am I right)?
>>>>
>>>> I'm a bit concerned about using something specific to Zero; is it
>>>> possible that this could be an issue on some multilib setups for
>>>> x86_64?  This fix looks ok for the 1.7 branch, but I'd rather we
>>>> generalised ARCHFLAG in the main tree so it is always set.
>>>
>>> If anything it should fix some multilib setups for x86_64, since
>>> they'll fail with the same error.
>>>
>>> ZERO_ARCHFLAG is just -m{31,32,64}.  It could easily be renamed
>>> as ARCHFLAG in the IcedTea makefiles...
>>>
>>
>> Exactly what I was thinking.
>
> So is it correct to rename ZERO_ARCHFLAG to ARCHFLAG, add this flag as
> compiler options to build these six PulseAudio-related sources and push
> Makefile.am to IcedTea6-1.7 repository?
>

No, please just apply the patch as originally posted to 1.7.  I'll
push the changed version to HEAD.

>>
>>> Cheers,
>>> Gary
>>>
>>> --
>>> http://gbenson.net/
>>>
>>
>>
>>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8