RFR: New section Making a change [v2]

Tobias Hartmann thartmann at openjdk.org
Tue Jul 9 06:50:44 UTC 2024


On Mon, 8 Jul 2024 23:53:54 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> The old section "Fixing a bug" was mostly outdated so it has been replaced with a section "Making a change" that holds content relevant to working with the source code and making changes. The still relevant parts of Fixing a bug has been moved to the appropriate places.
>> 
>> Another change that followed from this was the new section "Responsibilities of a Reviewer".
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed todo entry for the CSR section

src/guide/making-a-change.md line 33:

> 31: ## Copyright Headers
> 32: 
> 33: All source code files in OpenJDK has a header with copyright statements and a license. Since this is legal documentation it shall not be updated or modified without seeking guidance from your legal representative. For that reason this guide can't really give detailed information on what you can or should do. There are however a few generic things that can be clarified.

Suggestion:

All source code files in OpenJDK have a header with copyright statements and a license. Since this is legal documentation it shall not be updated or modified without seeking guidance from your legal representative. For that reason this guide can't really give detailed information on what you can or should do. There are however a few generic things that can be clarified.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/131#discussion_r1669839696


More information about the guide-dev mailing list