Request for reviews .02 (M): 6961697: move nmethod constants section before instruction section

[Vladimir Kozlov]

Christian,

Are these changes made above 6978355 changes? I did not find code_offset() definition in this changes?
Why you removed oops section print in nmethod.cpp?
What about FIXME commented assert in relocInfo.cpp?

Otherwise this looks good.

Thanks,
Vladimir

On 8/19/10 11:38 AM, Christian Thalinger wrote:
> On Thu, 2010-07-08 at 21:18 +0200, Christian Thalinger wrote:
>> I agree on that.  When I've finished the new webrev I will merge it with
>> the other workspace and do some performance evaluation.
>
> So here's the new version:
>
> http://cr.openjdk.java.net/~twisti/6961697/webrev.02/
>
> This one is completely different to the ones before and much simpler.
> The renaming part was moved to 6978355 and I only changed the order of
> the code sections:  consts, insts, stubs.  The CodeBuffer works as
> before and the memory layout is the same.  But when the CodeBuffer is
> later copied into a CodeBlob the consts sections moves to the beginning.
>
> I did a lot of testing with the changes of 6961690.
>