Request for reviews .02 (M): 6961697: move nmethod constants section before instruction section

Christian Thalinger christian.thalinger at oracle.com
Wed Aug 25 06:16:23 PDT 2010


On Thu, 2010-08-19 at 22:04 -0700, Vladimir Kozlov wrote:
> Christian,
> 
> Are these changes made above 6978355 changes? I did not find code_offset() definition in this changes?

Yes, it's on top of 6978355.

> Why you removed oops section print in nmethod.cpp?

Because it was printed twice.  That is a bug I introduced with:

6951083: oops and relocations should part of nmethod not CodeBlob

> What about FIXME commented assert in relocInfo.cpp?

I removed that in 6978355 but added it again here.  I can't remember if
that was by accident or I really hit the assert.  Should I uncomment it
again?

-- Christian



More information about the hotspot-compiler-dev mailing list