Request for reviews .02 (M): 6961697: move nmethod constants section before instruction section

[Tom Rodriguez]

I think rearranging the all the section names wasn't really needed particularly in CodeBuffer since the ordering the buffer didn't change.  You don't need to undo though it.  Please correct the comment here:

      // Here is the list of all possible sections, in order of ascending address.
+     SECT_FIRST = 0,
+     SECT_CONSTS = SECT_FIRST, // Non-instruction data:  Floats, jump tables, etc.
      SECT_INSTS,               // Executable instructions.
      SECT_STUBS,               // Outbound trampolines for supporting call sites.
      SECT_CONSTS,              // Non-instruction data:  Floats, jump tables, etc.
      SECT_LIMIT, SECT_NONE = -1

Since the address ordering in CodeBuffers hasn't changed.  I think relocate relocate_code_to should have some more comments explaining that reordering is occurring too.

Otherwise this looks ok.

tom

On Aug 19, 2010, at 11:38 AM, Christian Thalinger wrote:

> On Thu, 2010-07-08 at 21:18 +0200, Christian Thalinger wrote:
>> I agree on that.  When I've finished the new webrev I will merge it with
>> the other workspace and do some performance evaluation.
> 
> So here's the new version:
> 
> http://cr.openjdk.java.net/~twisti/6961697/webrev.02/
> 
> This one is completely different to the ones before and much simpler.
> The renaming part was moved to 6978355 and I only changed the order of
> the code sections:  consts, insts, stubs.  The CodeBuffer works as
> before and the memory layout is the same.  But when the CodeBuffer is
> later copied into a CodeBlob the consts sections moves to the beginning.
> 
> I did a lot of testing with the changes of 6961690.
>